Bug 1782983 - koji download-build should support resumption to avoid repeated downloads
Summary: koji download-build should support resumption to avoid repeated downloads
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: koji
Version: 30
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Mike McLean
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-12-12 18:39 UTC by Frank Ch. Eigler
Modified: 2020-04-22 23:04 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-04-22 22:45:05 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
proposed patch for http range (1.18 KB, patch)
2019-12-12 18:39 UTC, Frank Ch. Eigler
no flags Details | Diff

Description Frank Ch. Eigler 2019-12-12 18:39:56 UTC
Created attachment 1644537 [details]
proposed patch for http range

koji 1.19.1 in f30 

% koji download-build --latestfrom f32 kernel
works, but then
% koji download-build --latestfrom f32 kernel
downloads all the same files all over again

The attached patch uses the HTTP Range request header to avoid repeated downloading of existing complete or partially-completed files.  This makes repeated downloads almost instant.

Comment 1 Kevin Fenzi 2019-12-15 01:43:39 UTC
Would you be willing to file this upstream?

https://pagure.io/koji/

Comment 2 Kevin Fenzi 2020-04-22 22:45:05 UTC
Landed in 1.21.0. :) 

https://pagure.io/koji/pull-request/2080

Comment 3 Frank Ch. Eigler 2020-04-22 23:04:10 UTC
awesome, thanks!


Note You need to log in before you can comment on or make changes to this bug.