Spec Name or Url: http://fedora.lowlatency.de/review/w3c-libwww.spec SRPM Name or Url: http://fedora.lowlatency.de/review/w3c-libwww-5.4.0-15.src.rpm Description: Libwww is a general-purpose Web API written in C for Unix and Windows (Win32). With a highly extensible and layered API, it can accommodate many different types of applications including clients and robots. The purpose of libwww is to provide a highly optimized HTTP sample implementation, as well as other Internet protocols, and to serve as a testbed for protocol experiments.
I attach a patch with minor changes. Feel free to discard what you dislike. I am a bit puzzled by the end of the third paragraph in the app subpackage description: The line mode browser is a minimal line mode web browser; often useful to convert to ascii text. Currently unavailable until someone updates it to some new interfaces. (hint, hint...) Is it still true?
Created attachment 123445 [details] minor changes
I think it could be a good idea to explain why make LIBTOOL=/usr/bin/libtool is needed And also why not use %{?_smp_mflags}?
I will look into your patch and the issues you mentioned. This was just my first rewrite of the core spec so sorry for some bits I missed. Will get on it tonight when I am home again...
Already submitted (bug 175980), please close one of these as a dupe.
http://fedora.lowlatency.de/review/w3c-libwww.spec http://fedora.lowlatency.de/review/w3c-libwww-5.4.0-16.src.rpm Updated with your suggestions :) Lets see how the other submission progresses...
*** Bug 175980 has been marked as a duplicate of this bug. ***
Review: OK Package name OK Spec file name OK License good (BSD-style) OK License in spec matches. OK License is included OK Spec english/readable OK Source match upstream (md5sum: c3734ca6caa405707e134cc8c6d7e422) OK No packages in BR that are in the exceptions list. OK No locale string or desktop files OK Post scripts call ldconfig OK Builds on devel OK Installs and runs on devel OK Package owns all it's created directories. OK Permissions look good. OK Clean section looks good.
Anreas, you didn't took into account my Comment #1 about the paragrph stating that the line browser is unavailable. Ian, do you want to review the package? If so, you should assign the bug report to yourself, otherwise I'll do it.
Sorry forgot all about testing this... :) Will do so in a sec and get back to you...
Ok... fixed the description... www works just fine (from what I can tell...) http://fedora.lowlatency.de/review/w3c-libwww.spec http://fedora.lowlatency.de/review/w3c-libwww-5.4.0-17.src.rpm
I was going to approve, but I have found (by chance) an issue. It seems to me that w3c-libwww uses a very outdated version of expat, with code included. I filed a bug #179836 against the FC-4 version. I think it is better not to ship it before we get a return on that issue (but if somebody feels like doing a patch and testing, it'll be nice ;-). I also have an advice, it is to add a comment for each patch explaining what it does. It is optionnal, though, and can be done much later.
Hm, maybe I don't get this but both expat libs that get created are _not_ part of expat or expat-devel or did I miss something?
No you didn't miss anything, it seems that libxmlparse and libxmltok were merged in the expat library. The included expat seems to correspond with expat version below 1.2, that was at this page: http://www.jclark.com/xml/expat.html I haven't investigated precisely, but at least some symbols that are in xmlparse.h and xmltok.h are in expat.h.
Oddly, it looks like there was talk of making a 5.4.1 release last year: http://lists.w3.org/Archives/Public/www-lib/2005OctDec/0014.html That seems to be updated in CVS, but no release was pushed out. I see several security fixes in the Changelog in CVS, so perhaps you should base off a CVS snapshot? and/or check with the mailing list to get them moving again on a release? It would be good to link against the system expat, not sure how easy that will be to do however. As a temp measure, perhaps a patch to update them to the latest expat versions?
Ok I have a new release here: 1) it is based of current cvs 2) it builds without the included expat lib and links against the system expat I have not tried however to compile any programs against this so we will see if all works out or not... =) http://fedora.lowlatency.de/review/w3c-libwww-5.4.1-0.1.20060206cvs.src.rpm http://fedora.lowlatency.de/review/w3c-libwww.spec
- rpmlint shows those warnings. Maybe the no-version-in-last-changelog could be acted upon? Can be done after commit. W: w3c-libwww invalid-license W3C (see: http://www.w3.org/Consortium/Legal/copyright-software.html) W: w3c-libwww no-version-in-last-changelog W: w3c-libwww-apps no-documentation W: w3c-libwww-devel no-documentation - name meets the guidelines - meets the packaging guidelines - a diff against a cvs checkout give no difference - everything looks good Previous version was allready checked by Ian Burrell. APPROVED
Hm before I go out and push this: wmweather+ does not build because a header is missing (actually the config header from w3c-libww). I will see if I can fix this in wmweather+ or if it really should be fixed here before publishing it...
Ok, I resolved that by readding the wwwconfig.h file. Imported and pushed :) Thanks again for the review.