Bug 1783786 - Brightness slider showing on desktop system when it should be disabled
Summary: Brightness slider showing on desktop system when it should be disabled
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: kernel
Version: 37
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Kernel Maintainer List
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-12-15 17:46 UTC by Pepeg
Modified: 2023-12-05 20:59 UTC (History)
20 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-12-05 20:59:00 UTC
Type: Bug
Embargoed:
vda7uy49zpl: needinfo-


Attachments (Terms of Use)
Log for hardware description (16.10 KB, text/plain)
2019-12-15 17:46 UTC, Pepeg
no flags Details


Links
System ID Private Priority Status Summary Last Updated
GNOME Gitlab 1832 0 None None None 2019-12-15 17:46:38 UTC
GNOME Gitlab GNOME/gnome-shell/issues/1832 0 None None None 2019-12-15 17:46:38 UTC

Description Pepeg 2019-12-15 17:46:39 UTC
Created attachment 1645354 [details]
Log for hardware description

On clean install of Fedora 31 without modifying anything the brightness slider is shown in GNOME shell when it should be disabled because it has no use on desktop system. Installing and clicking on the right side of the top panel shows slider which shouldn't be there. This bug was previously posted on GNOME shell issues GitLab page and I as a poster of this bug was redirected here. Attachment to the GNOME GitLab issue is provided also as well as dmidecode.log per instructions.

Comment 1 Hans de Goede 2019-12-17 11:42:34 UTC
Thanks, I have written a kernel patch which should fix this.

Here is a scratch-build of the kernel with the the patch added, please give this a test run:
https://koji.fedoraproject.org/koji/taskinfo?taskID=39687007

Note this is still building atm, it should be done in a couple of hours.

See here for generic instructions for installing a kernel directly from koji:
https://fedorapeople.org/~jwrdegoede/kernel-test-instructions.txt

Note if you not have time to test right away, please at least download the files indicated in the instructions, test builds get removed after a couple of days to cleanup disk-space.

Comment 2 Justin M. Forbes 2020-03-03 16:16:51 UTC
*********** MASS BUG UPDATE **************

We apologize for the inconvenience.  There are a large number of bugs to go through and several of them have gone stale.  Due to this, we are doing a mass bug update across all of the Fedora 31 kernel bugs.

Fedora 31 has now been rebased to 5.5.7-200.fc31.  Please test this kernel update (or newer) and let us know if you issue has been resolved or if it is still present with the newer kernel.

If you have moved on to Fedora 32, and are still experiencing this issue, please change the version to Fedora 32.

If you experience different issues, please open a new bug report for those.

Comment 3 Hans de Goede 2020-03-03 16:32:22 UTC
The quirk which I wrote for this is in kernel 5.5.7, so this should be fixed, closing.

Comment 4 Fernando 2021-11-06 01:36:22 UTC
(In reply to Hans de Goede from comment #3)
> The quirk which I wrote for this is in kernel 5.5.7, so this should be
> fixed, closing.

Hello, I'm using fedora 35 and I still have this bug. I'm using the ryzen 7 5700G with integrated graphics. This problem was present on fedora 34 as well.

Comment 5 Lyosha Alexeev 2022-12-07 12:00:41 UTC
This is still an issue on Fedora 37 with Ryzen 7000 series.

Comment 6 Hans de Goede 2022-12-07 15:05:48 UTC
(In reply to Lyosha Alexeev from comment #5)
> This is still an issue on Fedora 37 with Ryzen 7000 series.

Yes this still seems to be an issue on most AMD APU based desktops.

Solving this unfortunately is not trivial.

I have emailed a contact at AMD asking for help with this.

Comment 7 Mario Limonciello 2022-12-07 19:41:28 UTC
I've sent out this series that I believe should help the problem:
https://patchwork.freedesktop.org/series/111745/

Can you have a try with it?

Comment 8 Fernando 2022-12-15 03:56:49 UTC
(In reply to Mario Limonciello from comment #7)
> I've sent out this series that I believe should help the problem:
> https://patchwork.freedesktop.org/series/111745/
> 
> Can you have a try with it?

It works, thank you very much.

Comment 9 Mario Limonciello 2022-12-15 04:13:42 UTC
Would you mind replying to the series with a "Tested-by" tag?
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes

Comment 10 Lyosha Alexeev 2022-12-21 12:58:24 UTC
This didn't work on a Ryzen 7000 series CPU with disabled iGPU, applied to kernel 6.1.0 - the brightness slider is still there.

Comment 11 Mario Limonciello 2022-12-21 13:06:17 UTC
Did you apply all 3 patches? The last one should have changed that behavior by default even if amdgpu isn't loaded.

Comment 12 Lyosha Alexeev 2022-12-22 20:01:57 UTC
(In reply to Mario Limonciello from comment #11)
> Did you apply all 3 patches? The last one should have changed that behavior
> by default even if amdgpu isn't loaded.

I did apply all changes from https://patchwork.freedesktop.org/series/111745/ with three files altered in total.

# dmidecode --string chassis-type
> Desktop

# ls /sys/class/backlight
> acpi_video0

# grep acpi_video_report_nolcd /proc/kallsyms
> 0000000000000000 r __kstrtab_acpi_video_report_nolcd	[video]
> 0000000000000000 r __kstrtabns_acpi_video_report_nolcd	[video]
> 0000000000000000 r __ksymtab_acpi_video_report_nolcd	[video]
> 0000000000000000 T acpi_video_report_nolcd	[video]

# grep native_reported_nolcd /proc/kallsyms 
> 0000000000000000 b native_reported_nolcd	[video]

Of course, it is possible that I might have messed something up in the process.

Comment 13 Mario Limonciello 2022-12-31 06:03:36 UTC
I think the problem is that you didn't get the later version of the series but tested v1.  V3 has a third patch you probably missed.  This is the one that also makes it work if amdgpu doesn't detect an APU.
https://patchwork.freedesktop.org/series/111755/

They're all merged into master now though.  I suggest you retry with 6.2-rc2.

Comment 14 Lyosha Alexeev 2022-12-31 23:11:26 UTC
I patched 6.1.2 with the patch in master, and it works now, thanks!

Comment 15 Aoife Moloney 2023-11-23 00:02:41 UTC
This message is a reminder that Fedora Linux 37 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora Linux 37 on 2023-12-05.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
'version' of '37'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, change the 'version' 
to a later Fedora Linux version. Note that the version field may be hidden.
Click the "Show advanced fields" button if you do not see it.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora Linux 37 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora Linux, you are encouraged to change the 'version' to a later version
prior to this bug being closed.

Comment 16 Aoife Moloney 2023-12-05 20:59:00 UTC
Fedora Linux 37 entered end-of-life (EOL) status on None.

Fedora Linux 37 is no longer maintained, which means that it
will not receive any further security or bug fix updates. As a result we
are closing this bug.

If you can reproduce this bug against a currently maintained version of Fedora Linux
please feel free to reopen this bug against that version. Note that the version
field may be hidden. Click the "Show advanced fields" button if you do not see
the version field.

If you are unable to reopen this bug, please file a new report against an
active release.

Thank you for reporting this bug and we are sorry it could not be fixed.


Note You need to log in before you can comment on or make changes to this bug.