Description of problem: When we invoke 'application --help' on none UTF-8 locales, applications help messages are not shown correctly. I'm attaching the patch. Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info:
Created attachment 123474 [details] Patch for Makefile.am, configure.in, popthelp.c, poptint.c, poptint.h
Linking popt to glib simply ain't gonna happen.
Linking popt causes some build errors in other modules/packages durling configure.in
NEEDINFO_ENG has been deprecated in favor of NEEDINFO or ASSIGNED. Changing status to ASSIGNED for ENG review.
Using glib in popt creates unresolvable dependency loops if dependencies are added to track the usage of glib, or tricky support problems for popt output changes when glib cannot be dlopen'ed, so the patch as written cannot be applied. Meanwhile, if you rewrite using iconv(3) (which is all that glib2 is using), then the patch is probably acceptable.
Created attachment 138119 [details] Patch for Makefile.am configure.in popthelp.c poptint.c and poptint.h Patch using iconv
Could you integrate the patch into HEAD?
Fedora Core 5 and Fedora Core 6 are, as we're sure you've noticed, no longer test releases. We're cleaning up the bug database and making sure important bug reports filed against these test releases don't get lost. It would be helpful if you could test this issue with a released version of Fedora or with the latest development / test release. Thanks for your help and for your patience. [This is a bulk message for all open FC5/FC6 test release bugs. I'm adding myself to the CC list for each bug, so I'll see any comments you make after this and do my best to make sure every issue gets proper attention.]
This problem does not depends on the distributers and not fixed in popt HEAD yet. Could you integrate the fix? This bug is one year ago.
Apologies, I did not see the rewritten patch using iconv. That looks acceptable. I'll try to look this week.
Moving this to devel.
Added to rpm cvs, will be in popt-1.10.9-0.4 when built. Thanks for the patience and the patch. UPSTREAM
Well...this issue already should be fixed in the popt package I added for my review request. It would be nice, if somebody could try the popt package I added to my review request and close this bug report if everything works with this package. Thanks.
Your patch is at least incooperated into popt 1.12-3 which should reach Rawhide soon. I'll close this bug report now.
Created attachment 172393 [details] Patch for popt/configure.ac and popt/popthelp.c Thanks for commiting the patch. I noticed the CVS repository today. It seems some of the codes are not commited yet so I'ld like to update the patch. Could you review the attachment? The configure.ac works with 'autoheader' command.
I forwarded your patch to upstream, got reviewed there and was applied some minutes ago into CVS.
Created attachment 172416 [details] Patch for isspace() cast in popt/popthelp.c Thanks much for the quick integration. Sorry, I'ld also like to integrate the cast part in the previous patch. Could you review the attached patch? On Solaris, the isspace() does not work correctly because the type of 'ch' and 'help' are signed char and they become minus values because multibyte chars are 8bit > 7bit so isspace() receives minus int. int isspace(int c); The suggested fix is we convert the char to unsigned char and can convert to plus int with the cast. Then the isspace() works on Solaris. Thanks.
Thanks much for your integrations.