Spec URL: https://fedorapeople.org/~mbooth/reviews/takari-polyglot.spec SRPM URL: https://fedorapeople.org/~mbooth/reviews/takari-polyglot-0.4.4-2.fc32.src.rpm Description: Polyglot for Maven is an experimental distribution of Maven that allows the expression of a POM in something other than XML. Fedora Account System Username: mbooth Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39690702 NOTES: This is a combination rename/unretirement review of the tesla-polyglot package. (The "Tesla" project was renamed upstream to "Takari")
I'll take this one.
Can you rename the .spec file to match the package name please? Having it differ makes fedora-review choke on the package. I'm continuing with the review manually in the meantime.
1. The URL redirects to https://github.com/takari/polyglot-maven, which is also the prefix for Source0. Use that value for URL too. You could then even replace the Source0 prefix with %{url}. 2. Obsoletes and Provides look correct, except shouldn't the obsoleted EVR be "0.4.4-2" instead of "0.4.4-1", matching the "first EVR" of the renamed package? 3. I assume you know what you're doing with the XPath modifications that are present. 4. License tag is correct, according to licensecheck. 5. Tests run and pass. 6. BR on mvn(org.apache.maven:maven-parent:pom:) seems to be superfluous, xmvn-builddep does not list it. 7. I'm not sure the LICENSE file is installed for every combination of subpackages. Additionally including in the -common subpackage should take care that, I think (but I didn't check every subpackage interdependency).
(In reply to Fabio Valentini from comment #3) > 1. The URL redirects to https://github.com/takari/polyglot-maven, which is > also the prefix for Source0. Use that value for URL too. > You could then even replace the Source0 prefix with %{url}. I never noticed that, fixed. > > 2. Obsoletes and Provides look correct, except shouldn't the obsoleted EVR > be "0.4.4-2" instead of "0.4.4-1", matching the "first EVR" of the renamed > package? Fixed. > > 3. I assume you know what you're doing with the XPath modifications that are > present. Ah, yeah -- all this fussing about is to avoid needing to ressurect the takari-* stack of packages. Trust me I'm a doctor [0] [0] Not actually a real doctor! > > 4. License tag is correct, according to licensecheck. > > 5. Tests run and pass. > > 6. BR on mvn(org.apache.maven:maven-parent:pom:) seems to be superfluous, > xmvn-builddep does not list it. > It is definitely needed, or you get this error: "Non-resolvable parent POM for org.apache.maven:maven:3.6.1: Cannot access central (https://repo.maven.apache.org/maven2) in offline mode and the artifact org.apache.maven:maven-parent:pom:33 has not been downloaded from it before. @ org.apache.maven:maven:3.6.1, /usr/share/maven-poms/maven/maven.pom, line 22, column 11 -> [Help 2]" I believe this is a shortcoming of xmvn-builddep. > 7. I'm not sure the LICENSE file is installed for every combination of > subpackages. > Additionally including in the -common subpackage should take care that, I > think (but I didn't check every subpackage interdependency). Good thought, fixed. Spec URL: https://fedorapeople.org/~mbooth/reviews/takari-polyglot.spec SRPM URL: https://fedorapeople.org/~mbooth/reviews/takari-polyglot-0.4.4-3.fc32.src.rpm
(In reply to Mat Booth from comment #4) > (In reply to Fabio Valentini from comment #3) > > 1. The URL redirects to https://github.com/takari/polyglot-maven, which is > > also the prefix for Source0. Use that value for URL too. > > You could then even replace the Source0 prefix with %{url}. > > I never noticed that, fixed. > > > > > 2. Obsoletes and Provides look correct, except shouldn't the obsoleted EVR > > be "0.4.4-2" instead of "0.4.4-1", matching the "first EVR" of the renamed > > package? > > Fixed. > > > > > 3. I assume you know what you're doing with the XPath modifications that are > > present. > > Ah, yeah -- all this fussing about is to avoid needing to ressurect the > takari-* stack of packages. Trust me I'm a doctor [0] > > [0] Not actually a real doctor! > > > > > 4. License tag is correct, according to licensecheck. > > > > 5. Tests run and pass. > > > > 6. BR on mvn(org.apache.maven:maven-parent:pom:) seems to be superfluous, > > xmvn-builddep does not list it. > > > > It is definitely needed, or you get this error: > > "Non-resolvable parent POM for org.apache.maven:maven:3.6.1: Cannot access > central (https://repo.maven.apache.org/maven2) in offline mode and the > artifact org.apache.maven:maven-parent:pom:33 has not been downloaded from > it before. @ org.apache.maven:maven:3.6.1, > /usr/share/maven-poms/maven/maven.pom, line 22, column 11 -> [Help 2]" > > I believe this is a shortcoming of xmvn-builddep. Probably. Sorry for the false negative :) > > 7. I'm not sure the LICENSE file is installed for every combination of > > subpackages. > > Additionally including in the -common subpackage should take care that, I > > think (but I didn't check every subpackage interdependency). > > Good thought, fixed. > > > Spec URL: https://fedorapeople.org/~mbooth/reviews/takari-polyglot.spec > SRPM URL: > https://fedorapeople.org/~mbooth/reviews/takari-polyglot-0.4.4-3.fc32.src.rpm Looks good now! Full fedora-review output below. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [?]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.4.21 starting (python version = 3.7.5)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled ccache INFO: enabled HW Info plugin Mock Version: 1.4.21 INFO: Mock Version: 1.4.21 Finish: chroot init INFO: installing package(s): /home/deca/Workspace/1784501-takari-polyglot/results/takari-polyglot-xml-0.4.4-2.fc32.noarch.rpm /home/deca/Workspace/1784501-takari-polyglot/results/takari-polyglot-javadoc-0.4.4-2.fc32.noarch.rpm /home/deca/Workspace/1784501-takari-polyglot/results/takari-polyglot-0.4.4-2.fc32.noarch.rpm /home/deca/Workspace/1784501-takari-polyglot/results/takari-polyglot-translate-plugin-0.4.4-2.fc32.noarch.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 32 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/deca/Workspace/1784501-takari-polyglot/results/takari-polyglot-xml-0.4.4-2.fc32.noarch.rpm /home/deca/Workspace/1784501-takari-polyglot/results/takari-polyglot-javadoc-0.4.4-2.fc32.noarch.rpm /home/deca/Workspace/1784501-takari-polyglot/results/takari-polyglot-0.4.4-2.fc32.noarch.rpm /home/deca/Workspace/1784501-takari-polyglot/results/takari-polyglot-translate-plugin-0.4.4-2.fc32.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: takari-polyglot-0.4.4-2.fc32.noarch.rpm takari-polyglot-xml-0.4.4-2.fc32.noarch.rpm takari-polyglot-translate-plugin-0.4.4-2.fc32.noarch.rpm takari-polyglot-javadoc-0.4.4-2.fc32.noarch.rpm takari-polyglot-0.4.4-2.fc32.src.rpm takari-polyglot-translate-plugin.noarch: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 1 warnings. Source checksums ---------------- https://github.com/takari/polyglot-maven/archive/polyglot-0.4.4.tar.gz : CHECKSUM(SHA256) this package : 3d75c7937ec289e04084d9bd74077850effceec2a492486c813f7a4e2012748e CHECKSUM(SHA256) upstream package : 3d75c7937ec289e04084d9bd74077850effceec2a492486c813f7a4e2012748e Requires -------- takari-polyglot (rpmlib, GLIBC filtered): java-headless javapackages-filesystem mvn(org.apache.maven.plugins:maven-compiler-plugin) mvn(org.codehaus.plexus:plexus-component-metadata) takari-polyglot-xml (rpmlib, GLIBC filtered): java-headless javapackages-filesystem mvn(io.takari.polyglot:polyglot-common) takari-polyglot-translate-plugin (rpmlib, GLIBC filtered): java-headless javapackages-filesystem mvn(io.takari.polyglot:polyglot-atom) mvn(io.takari.polyglot:polyglot-common) mvn(io.takari.polyglot:polyglot-xml) mvn(org.codehaus.plexus:plexus-utils) takari-polyglot-javadoc (rpmlib, GLIBC filtered): javapackages-filesystem Provides -------- takari-polyglot: mvn(io.takari.polyglot:polyglot:pom:) takari-polyglot tesla-polyglot takari-polyglot-xml: mvn(io.takari.polyglot:polyglot-xml) mvn(io.takari.polyglot:polyglot-xml:pom:) mvn(io.tesla.polyglot:tesla-polyglot-xml) mvn(io.tesla.polyglot:tesla-polyglot-xml:pom:) takari-polyglot-xml tesla-polyglot-xml takari-polyglot-translate-plugin: mvn(io.takari.polyglot:polyglot-translate-plugin) mvn(io.takari.polyglot:polyglot-translate-plugin:pom:) mvn(io.tesla.polyglot:tesla-polyglot-translate-plugin) mvn(io.tesla.polyglot:tesla-polyglot-translate-plugin:pom:) takari-polyglot-translate-plugin tesla-polyglot-translate-plugin takari-polyglot-javadoc: takari-polyglot-javadoc tesla-polyglot-javadoc Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1784501 Buildroot used: fedora-rawhide-x86_64 Active plugins: Java, Generic, Shell-api Disabled plugins: SugarActivity, Haskell, R, fonts, PHP, Python, C/C++, Perl, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks! Repo request: https://pagure.io/releng/fedora-scm-requests/issue/20715 F31 branch request: https://pagure.io/releng/fedora-scm-requests/issue/20716
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/takari-polyglot
Built for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=39707071 F31: https://koji.fedoraproject.org/koji/taskinfo?taskID=39707081