Bug 1784767 - webadmin - illegal char' in extend size text box while editing disk not marked as illegal
Summary: webadmin - illegal char' in extend size text box while editing disk not marke...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 4.4.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.4.0
: ---
Assignee: Ahmad Khiet
QA Contact: Daniel
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-12-18 09:48 UTC by Daniel
Modified: 2020-05-20 19:57 UTC (History)
3 users (show)

Fixed In Version: ovirt-engine 4.4.0-27 22b6f82
Clone Of:
Environment:
Last Closed: 2020-05-20 19:57:48 UTC
oVirt Team: Storage
Embargoed:
pm-rhel: ovirt-4.4+


Attachments (Terms of Use)
ui and engine logs (1.11 MB, application/gzip)
2019-12-18 09:48 UTC, Daniel
no flags Details
alias text box (37.98 KB, image/png)
2019-12-18 09:49 UTC, Daniel
no flags Details
extend size text box (85.41 KB, image/png)
2019-12-18 09:49 UTC, Daniel
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 106147 0 master MERGED webadmin: extend disk size textbox validation fix 2020-03-31 14:18:00 UTC

Description Daniel 2019-12-18 09:48:18 UTC
Created attachment 1646064 [details]
ui and engine logs

Description of problem:
when user try to insert illegal characters in extend disk size text box via web admin, it seems that nothing happens and user can't know why the "ok button" of the edit disk does not work as it should.

Version-Release number of selected component (if applicable):
4.4.0-0.9.master.el7

How reproducible:
100%

Steps to Reproduce:
1. Login to webadmin
2. Create new disk
3. Edit the created disk from step 2
4. Insert illegal chars' in the extend disk size text box (for example: a)

Actual results:
Nothing happens on the edit disk window.
In addition, an error occurred in the bottom right of the page.

Expected results:
red line around the text box and a note that illegal chars were insert.

Additional info:
print shots and logs (ui & engine) attached

Comment 1 Daniel 2019-12-18 09:49:24 UTC
Created attachment 1646065 [details]
alias text box

Comment 2 Daniel 2019-12-18 09:49:54 UTC
Created attachment 1646066 [details]
extend size text box

Comment 3 Sandro Bonazzola 2020-03-20 14:58:46 UTC
This bug is targeted to 4.4.3 and in modified state. can we re-target to 4.4.0 and move to QA?

Comment 4 Daniel 2020-04-01 10:57:55 UTC
Bug verified via web-admin.
When trying editing disk and insert some illegal characters, a red line around the text box with appropriate guideline appear as it should.
All work as expected.  

worked on:
rhvm-4.4.0-0.29.master.el8ev.noarch
vdsm-jsonrpc-java-1.5.4-1.el8ev.noarch
qemu-kvm-4.2.0-16.module+el8.2.0+6092+4f2391c1.x86_64
libvirt-client-6.0.0-15.module+el8.2.0+6106+b6345808.x86_64

Comment 5 Sandro Bonazzola 2020-05-20 19:57:48 UTC
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.