RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1785522 - netkvm: the driver does not use VIRTIO_F_ANY_LAYOUT when runs with modern virtio-net-pci device
Summary: netkvm: the driver does not use VIRTIO_F_ANY_LAYOUT when runs with modern vir...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: virtio-win
Version: 8.0
Hardware: x86_64
OS: Windows
unspecified
unspecified
Target Milestone: rc
: 8.0
Assignee: ybendito
QA Contact: Yu Wang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-12-20 06:16 UTC by ybendito
Modified: 2021-09-03 15:28 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-04-28 16:05:16 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-31379 0 None None None 2021-09-03 15:28:28 UTC
Red Hat Product Errata RHEA-2020:1757 0 None None None 2020-04-28 16:05:30 UTC

Description ybendito 2019-12-20 06:16:11 UTC 
Description of problem:

The virtio-net-pci device on Q35 reports VIRTIO_F_VERSION_1.
The driver does not take in account that this implies ANY_LAYOUT feature.
So, when the driver works with virtio-net-pci on Q35 it always splits the first buffer of the packet to two (one for virtio-net header, another one for the packet. This creates redundant operations in the driver and redundant operations in the host for each packet. 

Version-Release number of selected component (if applicable):

175

Expected results:

VIRTIO_F_VERSION_1 implies ANY_LAYOUT even if ANY_LAYOUT feature is not reported by the device (this is what Linux driver does)

Notes for QE:
When the fix is released, functional regression test and performance comparison test required.
Comment 1 Yu Wang 2019-12-20 08:41:28 UTC 
Hi Yuri,


For functional regression test and performance comparison test, witch aspect we should test?
For example, network i/o, network migration, network device hotplug/unplug or other tests?

And how to judge VIRTIO_F_ANY_LAYOUT is used when runs with modern virtio-net-pci device?

Thanks
Yu Wang
Comment 2 ybendito 2019-12-20 11:03:36 UTC 
(In reply to Yu Wang from comment #1)
> Hi Yuri,
> 
> 
> For functional regression test and performance comparison test, witch aspect
> we should test?
> For example, network i/o, network migration, network device hotplug/unplug
> or other tests?

IMO, network i/o is enough

> 
> And how to judge VIRTIO_F_ANY_LAYOUT is used when runs with modern
> virtio-net-pci device?

I'll ack this it as soon as the BZ will be 'modified'
Additionally this can be checked in driver's log at startup/enable.

> 
> Thanks
> Yu Wang
Comment 3 Yu Wang 2020-01-09 05:11:22 UTC 
Hi,

Reproduce this bug with build 175, cannot find VIRTIO_F_ANY_LAYOUT initialize

Test with build 176 , it shows VIRTIO_F_ANY_LAYOUT in traceview log:

00000192	netkvm.sys	4	7856	3	192	01\08\2020-23:28:41:296	 ParaNdis_InitializeContext[ParaNdis_InitializeContext] Assuming VIRTIO_F_ANY_LAYOUT for V1 device
00000193	netkvm.sys	4	7856	3	193	01\08\2020-23:28:41:300	 ParaNdis_InitializeContext status = 0x0

Test on win7-64,win8-32,win2012r2 and win10-64
virtio-win-prewhql-176
qemu-kvm-4.1.0-20.module+el8.1.1+5309+6d656f05.x86_64
kernel-4.18.0-147.3.1.el8_1.x86_64


So, this function has been used.

Wenli will do the performance comparison test. 

Thanks
Yu Wang
Comment 5 ybendito 2020-01-19 12:12:57 UTC 
Release in virtio-win 176
Comment 6 Yu Wang 2020-02-13 07:05:23 UTC 
Virtio-win-prewhql-178 netkvm function and WHQL Tests all passed,
And according to comment#4, performance tests passed. 
So this bug is verified.

Thanks
Yu Wang
Comment 12 errata-xmlrpc 2020-04-28 16:05:16 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:1757
Note You need to log in before you can comment on or make changes to this bug.