Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-rust_hawktracer_sys.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-rust_hawktracer_sys-0.3.0-1.fc32.src.rpm Description: Sys crate for the rust_hawktracer library. Fedora Account System Username: eclipseo
I will take this review.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Please look into the non-executable-script, wrong-script-end-of-line-encoding, and wrong-file-end-of-line-encoding rpmlint messages. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "Apache License (v2.0)", "*No copyright* Beerware License". 259 files have unknown license. Detailed output of licensecheck in /home/jamesjer/1785853-rust-rust_hawktracer_sys/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-rust_hawktracer_sys-devel-0.3.0-1.fc32.noarch.rpm rust-rust_hawktracer_sys+default-devel-0.3.0-1.fc32.noarch.rpm rust-rust_hawktracer_sys+bindgen-devel-0.3.0-1.fc32.noarch.rpm rust-rust_hawktracer_sys+generate_bindings-devel-0.3.0-1.fc32.noarch.rpm rust-rust_hawktracer_sys-0.3.0-1.fc32.src.rpm rust-rust_hawktracer_sys-devel.noarch: W: spelling-error Summary(en_US) Sys -> Mys, SOs, S's rust-rust_hawktracer_sys-devel.noarch: W: spelling-error %description -l en_US Sys -> Mys, SOs, S's rust-rust_hawktracer_sys-devel.noarch: W: spelling-error %description -l en_US sys -> says, sis, syn rust-rust_hawktracer_sys-devel.noarch: W: invalid-url URL: https://crates.io/crates/rust_hawktracer_sys HTTP Error 404: Not Found rust-rust_hawktracer_sys-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/rust_hawktracer_sys-0.3.0/.cargo-checksum.json rust-rust_hawktracer_sys-devel.noarch: E: non-executable-script /usr/share/cargo/registry/rust_hawktracer_sys-0.3.0/hawktracer/tools/generate_map_from_binary.sh 644 /bin/bash rust-rust_hawktracer_sys-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rust_hawktracer_sys-0.3.0/hawktracer/tools/generate_map_from_binary.sh rust-rust_hawktracer_sys-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rust_hawktracer_sys-0.3.0/src/internals/mod.rs rust-rust_hawktracer_sys-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/rust-rust_hawktracer_sys-devel/README.md rust-rust_hawktracer_sys+default-devel.noarch: W: spelling-error Summary(en_US) Sys -> Mys, SOs, S's rust-rust_hawktracer_sys+default-devel.noarch: W: spelling-error Summary(en_US) hawktracer -> hawk tracer, hawk-tracer, racetrack rust-rust_hawktracer_sys+default-devel.noarch: W: spelling-error %description -l en_US Sys -> Mys, SOs, S's rust-rust_hawktracer_sys+default-devel.noarch: W: spelling-error %description -l en_US hawktracer -> hawk tracer, hawk-tracer, racetrack rust-rust_hawktracer_sys+default-devel.noarch: W: spelling-error %description -l en_US sys -> says, sis, syn rust-rust_hawktracer_sys+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/rust_hawktracer_sys HTTP Error 404: Not Found rust-rust_hawktracer_sys+default-devel.noarch: W: no-documentation rust-rust_hawktracer_sys+bindgen-devel.noarch: W: spelling-error Summary(en_US) Sys -> Mys, SOs, S's rust-rust_hawktracer_sys+bindgen-devel.noarch: W: spelling-error Summary(en_US) hawktracer -> hawk tracer, hawk-tracer, racetrack rust-rust_hawktracer_sys+bindgen-devel.noarch: W: spelling-error %description -l en_US Sys -> Mys, SOs, S's rust-rust_hawktracer_sys+bindgen-devel.noarch: W: spelling-error %description -l en_US hawktracer -> hawk tracer, hawk-tracer, racetrack rust-rust_hawktracer_sys+bindgen-devel.noarch: W: spelling-error %description -l en_US bindgen -> bind gen, bind-gen, binding rust-rust_hawktracer_sys+bindgen-devel.noarch: W: spelling-error %description -l en_US sys -> says, sis, syn rust-rust_hawktracer_sys+bindgen-devel.noarch: W: invalid-url URL: https://crates.io/crates/rust_hawktracer_sys HTTP Error 404: Not Found rust-rust_hawktracer_sys+bindgen-devel.noarch: W: no-documentation rust-rust_hawktracer_sys+generate_bindings-devel.noarch: W: spelling-error Summary(en_US) Sys -> Mys, SOs, S's rust-rust_hawktracer_sys+generate_bindings-devel.noarch: W: spelling-error Summary(en_US) hawktracer -> hawk tracer, hawk-tracer, racetrack rust-rust_hawktracer_sys+generate_bindings-devel.noarch: W: spelling-error %description -l en_US Sys -> Mys, SOs, S's rust-rust_hawktracer_sys+generate_bindings-devel.noarch: W: spelling-error %description -l en_US hawktracer -> hawk tracer, hawk-tracer, racetrack rust-rust_hawktracer_sys+generate_bindings-devel.noarch: W: spelling-error %description -l en_US sys -> says, sis, syn rust-rust_hawktracer_sys+generate_bindings-devel.noarch: W: invalid-url URL: https://crates.io/crates/rust_hawktracer_sys HTTP Error 404: Not Found rust-rust_hawktracer_sys+generate_bindings-devel.noarch: W: no-documentation rust-rust_hawktracer_sys.src: W: spelling-error Summary(en_US) Sys -> Mys, SOs, S's rust-rust_hawktracer_sys.src: W: spelling-error Summary(en_US) hawktracer -> hawk tracer, hawk-tracer, racetrack rust-rust_hawktracer_sys.src: W: spelling-error %description -l en_US Sys -> Mys, SOs, S's rust-rust_hawktracer_sys.src: W: spelling-error %description -l en_US hawktracer -> hawk tracer, hawk-tracer, racetrack rust-rust_hawktracer_sys.src: W: invalid-url URL: https://crates.io/crates/rust_hawktracer_sys HTTP Error 404: Not Found 5 packages and 0 specfiles checked; 3 errors, 33 warnings. Rpmlint (installed packages) ---------------------------- rust-rust_hawktracer_sys+bindgen-devel.noarch: W: spelling-error Summary(en_US) Sys -> Mys, SOs, S's rust-rust_hawktracer_sys+bindgen-devel.noarch: W: spelling-error Summary(en_US) hawktracer -> hawk tracer, hawk-tracer, racetrack rust-rust_hawktracer_sys+bindgen-devel.noarch: W: spelling-error %description -l en_US Sys -> Mys, SOs, S's rust-rust_hawktracer_sys+bindgen-devel.noarch: W: spelling-error %description -l en_US hawktracer -> hawk tracer, hawk-tracer, racetrack rust-rust_hawktracer_sys+bindgen-devel.noarch: W: spelling-error %description -l en_US bindgen -> bind gen, bind-gen, binding rust-rust_hawktracer_sys+bindgen-devel.noarch: W: spelling-error %description -l en_US sys -> says, sis, syn rust-rust_hawktracer_sys+bindgen-devel.noarch: W: invalid-url URL: https://crates.io/crates/rust_hawktracer_sys HTTP Error 404: Not Found rust-rust_hawktracer_sys+bindgen-devel.noarch: W: no-documentation rust-rust_hawktracer_sys+default-devel.noarch: W: spelling-error Summary(en_US) Sys -> Mys, SOs, S's rust-rust_hawktracer_sys+default-devel.noarch: W: spelling-error Summary(en_US) hawktracer -> hawk tracer, hawk-tracer, racetrack rust-rust_hawktracer_sys+default-devel.noarch: W: spelling-error %description -l en_US Sys -> Mys, SOs, S's rust-rust_hawktracer_sys+default-devel.noarch: W: spelling-error %description -l en_US hawktracer -> hawk tracer, hawk-tracer, racetrack rust-rust_hawktracer_sys+default-devel.noarch: W: spelling-error %description -l en_US sys -> says, sis, syn rust-rust_hawktracer_sys+default-devel.noarch: W: invalid-url URL: https://crates.io/crates/rust_hawktracer_sys HTTP Error 404: Not Found rust-rust_hawktracer_sys+default-devel.noarch: W: no-documentation rust-rust_hawktracer_sys-devel.noarch: W: spelling-error Summary(en_US) Sys -> Mys, SOs, S's rust-rust_hawktracer_sys-devel.noarch: W: spelling-error %description -l en_US Sys -> Mys, SOs, S's rust-rust_hawktracer_sys-devel.noarch: W: spelling-error %description -l en_US sys -> says, sis, syn rust-rust_hawktracer_sys-devel.noarch: W: invalid-url URL: https://crates.io/crates/rust_hawktracer_sys HTTP Error 404: Not Found rust-rust_hawktracer_sys-devel.noarch: W: hidden-file-or-dir /usr/share/cargo/registry/rust_hawktracer_sys-0.3.0/.cargo-checksum.json rust-rust_hawktracer_sys-devel.noarch: E: non-executable-script /usr/share/cargo/registry/rust_hawktracer_sys-0.3.0/hawktracer/tools/generate_map_from_binary.sh 644 /bin/bash rust-rust_hawktracer_sys-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rust_hawktracer_sys-0.3.0/hawktracer/tools/generate_map_from_binary.sh rust-rust_hawktracer_sys-devel.noarch: E: wrong-script-end-of-line-encoding /usr/share/cargo/registry/rust_hawktracer_sys-0.3.0/src/internals/mod.rs rust-rust_hawktracer_sys-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/rust-rust_hawktracer_sys-devel/README.md rust-rust_hawktracer_sys+generate_bindings-devel.noarch: W: spelling-error Summary(en_US) Sys -> Mys, SOs, S's rust-rust_hawktracer_sys+generate_bindings-devel.noarch: W: spelling-error Summary(en_US) hawktracer -> hawk tracer, hawk-tracer, racetrack rust-rust_hawktracer_sys+generate_bindings-devel.noarch: W: spelling-error %description -l en_US Sys -> Mys, SOs, S's rust-rust_hawktracer_sys+generate_bindings-devel.noarch: W: spelling-error %description -l en_US hawktracer -> hawk tracer, hawk-tracer, racetrack rust-rust_hawktracer_sys+generate_bindings-devel.noarch: W: spelling-error %description -l en_US sys -> says, sis, syn rust-rust_hawktracer_sys+generate_bindings-devel.noarch: W: invalid-url URL: https://crates.io/crates/rust_hawktracer_sys HTTP Error 404: Not Found rust-rust_hawktracer_sys+generate_bindings-devel.noarch: W: no-documentation 4 packages and 0 specfiles checked; 3 errors, 28 warnings. Source checksums ---------------- https://crates.io/api/v1/crates/rust_hawktracer_sys/0.3.0/download#/rust_hawktracer_sys-0.3.0.crate : CHECKSUM(SHA256) this package : 1798e17a5cf2e9365285d429156b34808e1613fc0581a61d3e0ade04e21c87b5 CHECKSUM(SHA256) upstream package : 1798e17a5cf2e9365285d429156b34808e1613fc0581a61d3e0ade04e21c87b5 Requires -------- rust-rust_hawktracer_sys-devel (rpmlib, GLIBC filtered): (crate(cmake/default) >= 0.1.0 with crate(cmake/default) < 0.2.0) cargo rust-rust_hawktracer_sys+default-devel (rpmlib, GLIBC filtered): cargo crate(rust_hawktracer_sys) rust-rust_hawktracer_sys+bindgen-devel (rpmlib, GLIBC filtered): (crate(bindgen/default) >= 0.52.0 with crate(bindgen/default) < 0.53.0) cargo crate(rust_hawktracer_sys) rust-rust_hawktracer_sys+generate_bindings-devel (rpmlib, GLIBC filtered): (crate(bindgen/default) >= 0.52.0 with crate(bindgen/default) < 0.53.0) cargo crate(rust_hawktracer_sys) Provides -------- rust-rust_hawktracer_sys-devel: crate(rust_hawktracer_sys) rust-rust_hawktracer_sys-devel rust-rust_hawktracer_sys+default-devel: crate(rust_hawktracer_sys/default) rust-rust_hawktracer_sys+default-devel rust-rust_hawktracer_sys+bindgen-devel: crate(rust_hawktracer_sys/bindgen) rust-rust_hawktracer_sys+bindgen-devel rust-rust_hawktracer_sys+generate_bindings-devel: crate(rust_hawktracer_sys/generate_bindings) rust-rust_hawktracer_sys+generate_bindings-devel Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07 Command line :/usr/bin/fedora-review -b 1785853 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Java, PHP, SugarActivity, fonts, R, Haskell, Perl, Python, Ruby, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
New Spec URL: https://eclipseo.fedorapeople.org/for-review/rust-rust_hawktracer_sys.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/rust-rust_hawktracer_sys-0.3.0-1.fc32.src.rpm
I fixed the wrong line encoding and removed tools/ which is not used anyway.
Looks good. This package is APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rust_hawktracer_sys