Spec Name or Url: http://home.zonnet.nl/jwrdegoede/overgod.spec SRPM Name or Url: http://home.zonnet.nl/jwrdegoede/overgod-1.0-1.src.rpm Author's Description: For too long has humanity been ruled by cruel and disputatious gods! Fly through the various layers of the Celestial Oversphere to unseat those who control the universe. This is my latest game, Overgod. It's similar to my last game, Lacewing, but better in almost every way. Basically, you control a little vehicle in the middle of the screen and fly around and shoot things - a bit like asteroids, but the asteroids move independently and shoot back. You can also upgrade your vehicle in various ways. Some notes: I created the icon with gthumb from a bmp in SOURCE0, the license is thus GPL. If you try to build this on Rawhide, allegro-devel is currently broken on rawhide. It is fixed in CVS but can't be build because of buildsys trouble. So todo a testbuild of this package on rawhide, first checkout allegro from CVS, build that locally and install it. Also note that rawhide mockbuilds will also fail because of this and because rawhide has broken deps internally. The cfg file is only used for the initial defaults, after the first start all settings are read from and saved to ~/.overgod.cfg, thus it is not marked %config, also see the discussion in bug 178568
Should the sed replacement under %prep be in %build instead? I also could not get this to build on FC4.
Not in my book, it just converts a text format, something which could be done with a patch too (I've even concidered doing it in a patch). Nothing is being build here. Actually I've seen rpm's where even ./configure is in %prep, but thats just plain wrong. How / where does it fail with which message?
Created attachment 123585 [details] Failed buildout on FC4 This is the build error I get on FC4. allegro-4.0.3-13 allegro-devel-4.0.3-13 desktop-file-utils-0.10-1
Looks like your allegro is busted. It compiles fine on devel unfortunatly tou can't compile the allegro SRPM from devel on FC4 since it BuildRequires the new modular Xorg stuff.
MUST items: * rpmlint output clean * Name matches upstream; spec file named appropriately * License (GPL) ok, license text included in %doc * Specfile is legible and in Am. English * Sources match upstream (md5sum ok) * Package compiles and builds on FC5 i386 * BuildRequires ok. * no -devel package * Minimal documentation ok. * No localized text * No shared libraries * Not relocatable * 0wns directories that it creates * No duplicate files * Permissions look ok * %clean and %install both remove $RPM_BUILD_ROOT * Contains code and permissible content (game data files) * desktop file ok. SHOULD items: * license file included - mock build fails on FC4 i386 (see comment #3) * Program runs. * scriptlets ok. NEEDSWORK: * Don't use first-person references in a description. Try something like this instead: "For too long has humanity been ruled by cruel and disputatious gods! Fly through the various layers of the Celestial Oversphere to unseat those who control the universe. In Overgod you control a little vehicle in the middle of the screen and fly around and shoot things - a bit like asteroids, but the asteroids move independently and shoot back. You can also upgrade your vehicle in various ways." As noted in comment #3, the package won't build on FC4. I'm assuming you are considering this package for FC5 only?
Thanks for the review, I'll fix the description and post a new version tomorrow. About the building on FC-4, FC-5 is near so unless I get requests I'm not planning on an FC-4 release. If I get requests I'll file a bug against FC-4 allegro, as that needs fixing and/or updating for this.
Is there any chance that you'd want to package xpilot (www.xpilot.org), another Asteroids clone? :) It looks like it used to be in RH7.
Maybe xpilot NG would be a better choice? : http://xpilot.sourceforge.net/
Description has been fixed, new spec at: http://home.zonnet.nl/jwrdegoede/overgod.spec
All NEEDSWORK items addressed. ACCEPTED (I wasn't aware of xpilot-ng. It looks like a better choice)
Imported & Build