Spec Name or Url: http://fedora.ivazquez.net/files/extras/numpy.spec SRPM Name or Url: http://fedora.ivazquez.net/files/extras/numpy-0.9.4-1.src.rpm Description: The Numeric Python extensions is a set of extensions to the Python programming language which allows Python programmers to efficiently manipulate large sets of objects organized in grid-like fashion. These sets of objects are called arrays, and they can have any number of dimensions: one dimensional arrays are similar to standard Python sequences, two-dimensional arrays are similar to matrices from linear algebra. Note that one-dimensional arrays are also different from any other Python sequence, and that two-dimensional matrices are also different from the matrices of linear algebra. This package also contains a version of f2py that works properly with it.
Hi Ignacio, this is just a very quick look, not a full review: good: + source matches upstream + specfile looks sane + license looks OK needswork: - the license should probably (?) be in %doc - in %build, CFLAGS is set twice (redundant) - build on FC-4 fails with this message: + /usr/bin/python -c 'import pkg_resources, numpy ; numpy.test(1, 1)' Traceback (most recent call last): File "<string>", line 1, in ? ImportError: No module named pkg_resources error: Bad exit status from /var/tmp/rpm-tmp.44127 (%check)
Updated.
Created attachment 124151 [details] rpmlint output
Hi Ignacio, heres a more thorough review: good: + good parts from comment #1 still good + rpmlint produces a bunch of warnings and errors but taking a look at them it appears that they're all just brain-dead rpmlint annoyances + package builds in mock for fc4-i386 + BR list looks good + shared libs looks good (no *.la) + dir ownership OK + no %files dupes + permissions OK + has correct clean bits + code not content + some headers and libs are included but its acceptable + ran some simple examples and no segfaults -- good and I don't see any blockers so its APPROVED.
Built under FC4 and devel.