DescriptionOlimp Bockowski
2019-12-30 12:32:42 UTC
Description of problem:
RHCOS is not taken into consideration for (older versions) urlfetcher.py / urldetect.py (newer versions)
for urlfetcher.py (versions RHEL still uses) the enhancement would be easy as:
--- urlfetcher.py 2019-12-27 13:53:04.540313804 +0100
+++ /usr/share/virt-manager/virtinst/urlfetcher.py 2019-12-27 13:45:58.064900044 +0100
@@ -708,6 +708,8 @@
]
_hvm_paths = [("images/pxeboot/vmlinuz",
"images/pxeboot/initrd.img"), # Fedora
+ ("images/vmlinuz",
+ "images/initramfs.img"), # RHCOS
("ppc/ppc64/vmlinuz",
"ppc/ppc64/initrd.img"), # CenOS 7 ppc64le
for urldetect.py maybe a new class: _RHCOSDistro(_DistroTree)
Use case:
virt-install with --boot kernel=/tmp/rhcos-4.2.0-x86_64-installer-kernel,initrd=/tmp/rhcos-4.2.0-x86_64-installer-initramfs.img
...
kernel_args=coreos.inst.image_url=http://${IP}/rhcos-4.2.0-x86_64-metal-bios.raw.gz
Moving to RHCOS component. If the intention is for this ISO content to be installable, RHCOS can provide a .treeinfo file, which RH distros use to tell tools where in the tree the kernel+initrd are stored.
Example: https://dl.fedoraproject.org/pub/archive/fedora/linux/releases/30/Workstation/x86_64/os/.treeinfo
But RHEL/Centos have provided similar for a decade.
For virt-install most of that doesn't need to be provided. Really just [general] OS ID stuff, and images-$arch sections.
We've moved this BZ along as a low priority, "nice to have" feature for almost four OCP releases (nearly 9 months). It has never received the priority to be worked on and I don't anticipate it's priority changing in the short to medium term. As such, this will be closed as WONTFIX.
If this is a high priority business need or customer problem, please reopen with the necessary justification. Alternatively, it would be acceptable for a motivated engineer to submit patches to https://github.com/coreos/coreos-assembler that would generate the .treeinfo during the build process.
Description of problem: RHCOS is not taken into consideration for (older versions) urlfetcher.py / urldetect.py (newer versions) for urlfetcher.py (versions RHEL still uses) the enhancement would be easy as: --- urlfetcher.py 2019-12-27 13:53:04.540313804 +0100 +++ /usr/share/virt-manager/virtinst/urlfetcher.py 2019-12-27 13:45:58.064900044 +0100 @@ -708,6 +708,8 @@ ] _hvm_paths = [("images/pxeboot/vmlinuz", "images/pxeboot/initrd.img"), # Fedora + ("images/vmlinuz", + "images/initramfs.img"), # RHCOS ("ppc/ppc64/vmlinuz", "ppc/ppc64/initrd.img"), # CenOS 7 ppc64le for urldetect.py maybe a new class: _RHCOSDistro(_DistroTree) Use case: virt-install with --boot kernel=/tmp/rhcos-4.2.0-x86_64-installer-kernel,initrd=/tmp/rhcos-4.2.0-x86_64-installer-initramfs.img ... kernel_args=coreos.inst.image_url=http://${IP}/rhcos-4.2.0-x86_64-metal-bios.raw.gz