Bug 1787218 - Review Request: python-aiopg - Postgres integration with asyncio
Summary: Review Request: python-aiopg - Postgres integration with asyncio
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-01-01 15:47 UTC by Fabian Affolter
Modified: 2020-04-11 19:29 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-04-05 00:15:30 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Fabian Affolter 2020-01-01 15:47:04 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiopg.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiopg-1.0.0-1.fc31.src.rpm

Project URL: https://aiopg.readthedocs.io

Description:
aiopg is a library for accessing a PostgreSQL database from the asyncio
(PEP-3156/tulip) framework. It wraps asynchronous features of the Psycopg
database driver.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=40027026

rpmlint output:
$ rpmlint python-aiopg-1.0.0-1.fc31.src.rpm 
python-aiopg.src: W: spelling-error Summary(en_US) Postgres -> Postures, Postgraduates
python-aiopg.src: W: spelling-error Summary(en_US) asyncio -> syncopation
python-aiopg.src: W: spelling-error %description -l en_US asyncio -> syncopation
python-aiopg.src:46: W: macro-in-comment %check
python-aiopg.src:47: W: macro-in-comment %{buildroot}
python-aiopg.src:47: W: macro-in-comment %{python3_sitelib}
python-aiopg.src:47: W: macro-in-comment %{python3_version}
1 packages and 0 specfiles checked; 0 errors, 7 warnings.

$ rpmlint python3-aiopg-1.0.0-1.fc31.noarch.rpm 
python3-aiopg.noarch: W: spelling-error Summary(en_US) Postgres -> Postures, Postgraduates
python3-aiopg.noarch: W: spelling-error Summary(en_US) asyncio -> syncopation
python3-aiopg.noarch: W: spelling-error %description -l en_US asyncio -> syncopation
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

Fedora Account System Username: fab


I'm not sure how to deal with psycopg2-binary at the moment.

Comment 1 Robert-André Mauchin 🐧 2020-01-07 17:32:17 UTC
 - Package is not installable:

DEBUG util.py:582:  Error: 
DEBUG util.py:582:   Problem: conflicting requests
DEBUG util.py:582:    - nothing provides python3.8dist(psycopg2-binary) >= 2.7 needed by python3-aiopg-1.0.0-1.fc32.noarch

You need to package psycopg2-binary as well.


 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Comment 2 Fabian Affolter 2020-03-23 21:36:04 UTC
Thanks for the feedback.

* Mon Mar 23 2020 Fabian Affolter <mail> - 1.0.0-2
- Make tests optional
- Don't use psycopg2-binary

Updated files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiopg.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-aiopg-1.0.0-2.fc31.src.rpm

Comment 3 Robert-André Mauchin 🐧 2020-03-24 17:15:36 UTC
Package approved.

Comment 4 Fabian Affolter 2020-03-24 21:27:34 UTC
Thanks for the review.

Comment 5 Gwyn Ciesla 2020-03-25 13:17:12 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-aiopg

Comment 6 Fedora Update System 2020-03-27 08:08:46 UTC
FEDORA-2020-8971b1d7ee has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-8971b1d7ee

Comment 7 Fedora Update System 2020-03-27 08:10:51 UTC
FEDORA-2020-48cea908e1 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-48cea908e1

Comment 8 Fedora Update System 2020-03-27 08:18:10 UTC
FEDORA-EPEL-2020-8fe9c815da has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-8fe9c815da

Comment 9 Fedora Update System 2020-03-28 01:44:09 UTC
FEDORA-EPEL-2020-8fe9c815da has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-8fe9c815da

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2020-03-28 02:42:50 UTC
FEDORA-2020-48cea908e1 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-48cea908e1 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-48cea908e1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2020-03-28 14:59:00 UTC
FEDORA-2020-8971b1d7ee has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-8971b1d7ee \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-8971b1d7ee

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2020-04-05 00:15:30 UTC
FEDORA-2020-8971b1d7ee has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2020-04-05 03:03:27 UTC
FEDORA-2020-48cea908e1 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2020-04-11 19:29:00 UTC
FEDORA-EPEL-2020-8fe9c815da has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.