Bug 1787443 (python-pytest-isort) - Review Request: python-pytest-isort - Pytest plugin to check import ordering using isort
Summary: Review Request: python-pytest-isort - Pytest plugin to check import ordering ...
Keywords:
Status: CLOSED ERRATA
Alias: python-pytest-isort
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: python-pytest-toolbox python-devtools
TreeView+ depends on / blocked
 
Reported: 2020-01-02 21:08 UTC by Fabian Affolter
Modified: 2020-01-17 05:06 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-01-16 22:29:56 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Fabian Affolter 2020-01-02 21:08:56 UTC
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-pytest-isort.spec
SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-pytest-isort-0.3.1-1.fc31.src.rpm

Project URL: http://github.com/moccu/pytest-isort/

Description:
py.test plugin to check import ordering using isort.

Koji scratch build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=40055953

rpmlint output:
$ rpmlint python3-pytest-isort-0.3.1-1.fc31.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint python-pytest-isort-0.3.1-1.fc31.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Fedora Account System Username: fab

Comment 1 Robert-André Mauchin 🐧 2020-01-06 17:44:51 UTC
python3-pytest-isort.noarch: E: non-readable /usr/lib/python3.8/site-packages/__pycache__/pytest_isort.cpython-38-PYTEST.pyc 600

Should probably fix this:

rm -rf %{buildroot}%{python3_sitelib}/__pycache__/pytest_isort.cpython-%{python3_version_nodots}-PYTEST.pyc


 - License ok
 - Latest version packaged
 - Builds in mock
 - Conforms to Packaging Guidelines

Package approved. Please fix the aforementioned issue before import.

Comment 2 Gwyn Ciesla 2020-01-06 20:27:15 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-isort

Comment 3 Fabian Affolter 2020-01-07 12:45:59 UTC
Thanks for the review

Comment 4 Fedora Update System 2020-01-07 12:53:41 UTC
FEDORA-2020-30ed72b6c7 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-30ed72b6c7

Comment 5 Fedora Update System 2020-01-07 12:58:21 UTC
FEDORA-2020-b22b517e01 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b22b517e01

Comment 6 Fedora Update System 2020-01-08 11:19:49 UTC
python-pytest-isort-0.3.1-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b22b517e01

Comment 7 Fedora Update System 2020-01-08 14:16:18 UTC
python-pytest-isort-0.3.1-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-30ed72b6c7

Comment 8 Fedora Update System 2020-01-16 22:29:56 UTC
python-pytest-isort-0.3.1-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2020-01-17 05:06:06 UTC
python-pytest-isort-0.3.1-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.