Bug 1787506 - "s2i build with a quota Building from a template" test is failing with wrong MEMORYSWAP value
Summary: "s2i build with a quota Building from a template" test is failing with wrong ...
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Build
Version: 4.3.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.4.0
Assignee: Adam Kaplan
QA Contact: wewang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-01-03 07:00 UTC by wewang
Modified: 2020-02-03 21:56 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-02-03 21:56:35 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Comment 1 wewang 2020-01-03 07:09:57 UTC
Related issues: https://github.com/containers/buildah/issues/1213

Comment 4 Adam Kaplan 2020-02-03 21:56:35 UTC
Per [1], I don't think restoring MEMORYSWAP settings will happen any time soon. My understanding is that this feature made sense when we used Docker, but is obsolete since we've moved to use buildah:

> The OpenShift builder uses buildah's chroot isolation, which doesn't implement setting control group settings.
> 
> Because the builder is run in a container, and the we can count on that container having its memory.limit_in_bytes limit set on its behalf by the runtime (CRI-O), so we don't have to do anything for that limit, and a couple of others.

@Cesar the issues you reported seem unrelated to this BZ - tests are failing because the binary source is timing out uploading to the build pod.

[1] https://github.com/containers/buildah/issues/1213#issuecomment-571277448


Note You need to log in before you can comment on or make changes to this bug.