Spec URL: https://smani.fedorapeople.org/review/perl-MooX-Role-Logger.spec SRPM URL: https://smani.fedorapeople.org/review/perl-MooX-Role-Logger-0.005-1.fc32.src.rpm Description: Universal logging via Log::Any Fedora Account System Username: smani
URL and Source0 address are usable. Ok. TODO: Please use <https://metacpan.org/release/MooX-Role-Logger> as the URL. The current one points to a file in that distribution. Source0 archive (SHA-256: d82325bb63f66ac82241f05ea4237ee33206bdd27415cbb6a889be6d5d6d800c) is original. Ok. Summary verified from lib/MooX/Role/Logger.pm. Ok. Description verified from lib/MooX/Role/Logger.pm. Ok. License verified from t/moox.t, t/moosex.t, README, Makefile.PL, LICENSE, lib/MooX/Role/Logger.pm, and lib/MooseX/Role/Logger.pm. FIX: Spell the license tag as "ASL 2.0". See <https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses> for allowed identifiers. No XS code, noarch BuildArch is Ok. FIX: Build-require 'perl-interpreter' instead of 'perl'. The latter brings in many unneeded dependencies. FIX: Constrain 'perl(ExtUtils::MakeMaker)' with '>= 6.17' (Makefile.PL:8). TODO: Constrain Perl version by build-requiring 'perl(:VERSION) >= 5.6)' (Makefile.PL:6). FIX: Constrain 'perl(Test::More)' with '>= 0.96' (META.json:68). FIX: Author tests are not executed and thus do not require their dependencies: perl(English), perl(File::Temp), perl(IO::Handle), perl(IPC::Open3), perl(Pod::Coverage::TrustPod), perl(Pod::Wordlist), perl(Test::CPAN::Meta), perl(Test::Pod), perl(Test::Pod::Coverage), perl(Test::Spelling). FIX: If you add 'NO_PACKLIST=1' argument to 'perl Makefile.PL' line and constrain 'perl(ExtUtils::MakeMaker)' dependency with '>= 6.76', you can remove the 'rm -f %{buildroot}%{perl_vendorarch}/auto/MooX/Role/Logger/.packlist' line from %install section. Otherwise build-require 'coreutils' for the rm command. All tests pass. Ok. $ rpmlint perl-MooX-Role-Logger.spec ../SRPMS/perl-MooX-Role-Logger-0.005-1.fc32.src.rpm ../RPMS/noarch/perl-MooX-Role-Logger-0.005-1.fc32.noarch.rpm sh: /usr/bin/python2: No such file or directory perl-MooX-Role-Logger.src: W: invalid-license ASLv2.0 perl-MooX-Role-Logger.noarch: W: invalid-license ASLv2.0 2 packages and 1 specfiles checked; 0 errors, 2 warnings. FIX: Fix the license tag. $ rpm -q -lv p ../RPMS/noarch/perl-MooX-Role-Logger-0.005-1.fc32.noarch.rpm package p is not installed drwxr-xr-x 2 root root 0 Jan 7 13:31 /usr/share/doc/perl-MooX-Role-Logger -rw-r--r-- 1 root root 871 Sep 24 2014 /usr/share/doc/perl-MooX-Role-Logger/Changes -rw-r--r-- 1 root root 3984 Sep 24 2014 /usr/share/doc/perl-MooX-Role-Logger/README drwxr-xr-x 2 root root 0 Jan 7 13:31 /usr/share/licenses/perl-MooX-Role-Logger -rw-r--r-- 1 root root 11500 Sep 24 2014 /usr/share/licenses/perl-MooX-Role-Logger/LICENSE -r--r--r-- 1 root root 2794 Jan 7 13:31 /usr/share/man/man3/MooX::Role::Logger.3pm.gz -r--r--r-- 1 root root 1428 Jan 7 13:31 /usr/share/man/man3/MooseX::Role::Logger.3pm.gz drwxr-xr-x 2 root root 0 Jan 7 13:31 /usr/share/perl5/vendor_perl/MooX drwxr-xr-x 2 root root 0 Jan 7 13:31 /usr/share/perl5/vendor_perl/MooX/Role -r--r--r-- 1 root root 5088 Sep 24 2014 /usr/share/perl5/vendor_perl/MooX/Role/Logger.pm drwxr-xr-x 2 root root 0 Jan 7 13:31 /usr/share/perl5/vendor_perl/MooseX drwxr-xr-x 2 root root 0 Jan 7 13:31 /usr/share/perl5/vendor_perl/MooseX/Role -r--r--r-- 1 root root 856 Sep 24 2014 /usr/share/perl5/vendor_perl/MooseX/Role/Logger.pm FIX: Add write permissions on regular files. This is achieved by appending '%{_fixperms} %{buildroot}/*' line to %install section. $ rpm -q --requires -p ../RPMS/noarch/perl-MooX-Role-Logger-0.005-1.fc32.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.1) 1 perl(Log::Any) 1 perl(Moo::Role) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-MooX-Role-Logger-0.005-1.fc32.noarch.rpm | sort -f | uniq -c 1 perl(MooseX::Role::Logger) = 0.005 1 perl(MooX::Role::Logger) = 0.005 1 perl-MooX-Role-Logger = 0.005-1.fc32 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-MooX-Role-Logger-0.005-1.fc32.noarch.rpm Binary dependencies are resolvable. Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all 'FIX' items, consider fixing the 'TODO' items and provide a new spec file. Resolution: Pacakge NOT approved. The package builds in F32 (https://koji.fedoraproject.org/koji/taskinfo?taskID=40227815). Ok.
Spec URL: https://smani.fedorapeople.org/review/perl-MooX-Role-Logger.spec SRPM URL: https://smani.fedorapeople.org/review/perl-MooX-Role-Logger-0.005-2.fc32.src.rpm %changelog * Tue Jan 07 2020 Sandro Mani <manisandro> - 0.005-2 - Fix license tag - Fix / constrain BRs - Pass NO_PACKLIST=1 to Makefile.PL - Run fixperms on buildroot
> TODO: Please use <https://metacpan.org/release/MooX-Role-Logger> as the URL. The current one points to a file in that distribution. Ignored. Ok. > FIX: Spell the license tag as "ASL 2.0". See <https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses> for allowed identifiers. Ok. > FIX: Build-require 'perl-interpreter' instead of 'perl'. The latter brings in many unneeded dependencies. Ok. > FIX: Constrain 'perl(ExtUtils::MakeMaker)' with '>= 6.17' (Makefile.PL:8). Ok. > TODO: Constrain Perl version by build-requiring 'perl(:VERSION) >= 5.6)' (Makefile.PL:6). Ok. > FIX: Constrain 'perl(Test::More)' with '>= 0.96' (META.json:68). Ok. > FIX: Author tests are not executed and thus do not require their dependencies: perl(English), perl(File::Temp), perl(IO::Handle), perl(IPC::Open3), perl(Pod::Coverage::TrustPod), perl(Pod::Wordlist), perl(Test::CPAN::Meta), perl(Test::Pod), perl(Test::Pod::Coverage), perl(Test::Spelling). FIX: I can still see perl(Test::Spelling) there. Please remove it too. > FIX: If you add 'NO_PACKLIST=1' argument to 'perl Makefile.PL' line and constrain 'perl(ExtUtils::MakeMaker)' dependency with '>= 6.76', you can remove the 'rm -f %{buildroot}%{perl_vendorarch}/auto/MooX/Role/Logger/.packlist' line from %install section. Otherwise build-require 'coreutils' for the rm command. Ok. $ rpmlint perl-MooX-Role-Logger.spec ../SRPMS/perl-MooX-Role-Logger-0.005-2.fc32.src.rpm ../RPMS/noarch/perl-MooX-Role-Logger-0.005-2.fc32.noarch.rpm sh: /usr/bin/python2: No such file or directory 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. > FIX: Add write permissions on regular files. This is achieved by appending '%{_fixperms} %{buildroot}/*' line to %install section. $ rpm -q -lv -p ../RPMS/noarch/perl-MooX-Role-Logger-0.005-2.fc32.noarch.rpm drwxr-xr-x 2 root root 0 Jan 7 15:46 /usr/share/doc/perl-MooX-Role-Logger -rw-r--r-- 1 root root 871 Sep 24 2014 /usr/share/doc/perl-MooX-Role-Logger/Changes -rw-r--r-- 1 root root 3984 Sep 24 2014 /usr/share/doc/perl-MooX-Role-Logger/README drwxr-xr-x 2 root root 0 Jan 7 15:46 /usr/share/licenses/perl-MooX-Role-Logger -rw-r--r-- 1 root root 11500 Sep 24 2014 /usr/share/licenses/perl-MooX-Role-Logger/LICENSE -rw-r--r-- 1 root root 2794 Jan 7 15:46 /usr/share/man/man3/MooX::Role::Logger.3pm.gz -rw-r--r-- 1 root root 1428 Jan 7 15:46 /usr/share/man/man3/MooseX::Role::Logger.3pm.gz drwxr-xr-x 2 root root 0 Jan 7 15:46 /usr/share/perl5/vendor_perl/MooX drwxr-xr-x 2 root root 0 Jan 7 15:46 /usr/share/perl5/vendor_perl/MooX/Role -rw-r--r-- 1 root root 5088 Sep 24 2014 /usr/share/perl5/vendor_perl/MooX/Role/Logger.pm drwxr-xr-x 2 root root 0 Jan 7 15:46 /usr/share/perl5/vendor_perl/MooseX drwxr-xr-x 2 root root 0 Jan 7 15:46 /usr/share/perl5/vendor_perl/MooseX/Role -rw-r--r-- 1 root root 856 Sep 24 2014 /usr/share/perl5/vendor_perl/MooseX/Role/Logger.pm File permissions and layout are Ok. Package builds in F32 (https://koji.fedoraproject.org/koji/taskinfo?taskID=40233544). Ok. Please correct the FIX item before building this package. Resolution: Package APPROVED.
>> TODO: Please use <https://metacpan.org/release/MooX-Role-Logger> as the URL. The current one points to a file in that distribution. > Ignored. Ok. Whoops, missed that. Will fix on import, along with perl(Test::Spelling) Thanks for the review! (I'm also fixing the other perl packages I posted for review based on your comments here).
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-MooX-Role-Logger