RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1788035 - [ansible-freeipa] Not able to remove cmd members from sudo rule.
Summary: [ansible-freeipa] Not able to remove cmd members from sudo rule.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: ansible-freeipa
Version: 8.2
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: rc
: 8.0
Assignee: Rafael Jeffman
QA Contact: ipa-qe
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-01-06 08:09 UTC by Varun Mylaraiah
Modified: 2023-02-12 20:49 UTC (History)
2 users (show)

Fixed In Version: ansible-freeipa-0.1.8-2.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-04-28 16:01:57 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker FREEIPA-9422 0 None None None 2023-02-12 20:49:15 UTC
Red Hat Issue Tracker RHELPLAN-37378 0 None None None 2023-02-12 20:47:31 UTC
Red Hat Product Errata RHBA-2020:1705 0 None None None 2020-04-28 16:02:04 UTC

Description Varun Mylaraiah 2020-01-06 08:09:53 UTC 
Description of problem:
Not able to remove cmd members from sudo rule in Sudo module.

Version-Release number of selected component (if applicable):
ansible-freeipa-0.1.8-1.el8.noarch



Steps to Reproduce:
Before running playbook
======================
On Master:
[root@master ~]# ipa sudorule-show sudorule1
  Rule name: sudorule1
  Enabled: TRUE
  Users: testuser01
  User Groups: group_test01
  Hosts: host01.ipadomain.test
  Host Groups: freeipa-team
  Sudo Allow Commands: /usr/bin/df


[root@ansible ~]# cat 029_sudorule_delete_members.yaml
---
- name: Playbook to handle sudorules
  hosts: ipaserver
  become: true

  tasks:
  - ipasudorule:
      ipaadmin_password: <xxxxx>
      name: sudorule1
      user: testuser01
      cmd: /usr/bin/df
      action: member
      state: absent

[root@ansible ~]# ansible-playbook -vv -i inventory/server.hosts 029_sudorule_delete_members.yaml 
ansible-playbook 2.9.2
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.6/site-packages/ansible
  executable location = /usr/bin/ansible-playbook
  python version = 3.6.8 (default, Dec  5 2019, 15:45:45) [GCC 8.3.1 20191121 (Red Hat 8.3.1-5)]
Using /etc/ansible/ansible.cfg as config file

PLAYBOOK: 029_sudorule_delete_members.yaml ***************************************************************************
1 plays in 029_sudorule_delete_members.yaml

PLAY [Playbook to handle sudorules] **********************************************************************************

TASK [Gathering Facts] ***********************************************************************************************
task path: /root/029_sudorule_delete_members.yaml:2
ok: [master.ipadomain.test]
META: ran handlers

TASK [ipasudorule] ***************************************************************************************************
task path: /root/029_sudorule_delete_members.yaml:7
changed: [master.ipadomain.test] => {"changed": true}
META: ran handlers
META: ran handlers

PLAY RECAP ***********************************************************************************************************
master.ipadomain.test      : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   


After running playbook
======================
On Master:
[root@master ~]# ipa sudorule-show sudorule1
  Rule name: sudorule1
  Enabled: TRUE
  User Groups: group_test01
  Hosts: host01.ipadomain.test
  Host Groups: freeipa-team
  Sudo Allow Commands: /usr/bin/df
  Sudo Deny Commands: /usr/bin/df


Actual results:
 Instead of removing cmd member from "Sudo Allow Commands", it is adding to “Sudo Deny Commands”

Expected results:
Should remove from "Sudo Allow Commands".

Additional info:
In CLI We have separate options to add and remove for both "Sudo Allow Commands" and “Sudo Deny Commands”
sudorule-add-allow-command -- Add commands and sudo command groups affected by Sudo Rule.
sudorule-add-deny-command -- Add commands and sudo command groups affected by Sudo Rule.
sudorule-remove-allow-command -- Remove commands and sudo command groups affected by Sudo Rule.
sudorule-remove-deny-command -- Remove commands and sudo command groups affected by Sudo Rule.
Comment 1 Rafael Jeffman 2020-02-04 12:15:54 UTC 
Here is the upstream PR https://github.com/freeipa/ansible-freeipa/pull/178
Comment 5 Varun Mylaraiah 2020-03-05 11:59:52 UTC 
Verified

Manual execution console output:
================================
# rpm -q ansible-freeipa
ansible-freeipa-0.1.8-3.el8.noarch

[root@master ~]# ipa sudorule-show sudorule035
  Rule name: sudorule035
  Enabled: TRUE
  Sudo Allow Commands: /usr/bin/df


[root@ansible ~]# cat sudo_0035.yaml
---
- name: Playbook to handle sudorules
  hosts: ipaserver
  become: true

  tasks:
  - ipasudorule:
      ipaadmin_password: <xxxxxxx>
      name: sudorule035
      allow_sudocmd: /usr/bin/df
      action: member
      state: absent

[root@ansible ~]# ansible-playbook -vv -i inventory/server.hosts sudo_0035.yaml 
ansible-playbook 2.9.5
  config file = /etc/ansible/ansible.cfg
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3.6/site-packages/ansible
  executable location = /usr/bin/ansible-playbook
  python version = 3.6.8 (default, Dec  5 2019, 15:45:45) [GCC 8.3.1 20191121 (Red Hat 8.3.1-5)]
Using /etc/ansible/ansible.cfg as config file

PLAYBOOK: sudo_0035.yaml *********************************************************************************************
1 plays in sudo_0035.yaml

PLAY [Playbook to handle sudorules] **********************************************************************************

TASK [Gathering Facts] ***********************************************************************************************
task path: /root/sudo_0035.yaml:2
ok: [master.ipadomain.test]
META: ran handlers

TASK [ipasudorule] ***************************************************************************************************
task path: /root/sudo_0035.yaml:7
changed: [master.ipadomain.test] => {"changed": true}
META: ran handlers
META: ran handlers

PLAY RECAP ***********************************************************************************************************
master.ipadomain.test      : ok=2    changed=1    unreachable=0    failed=0    skipped=0    rescued=0    ignored=0   

[root@master ~]# ipa sudorule-show sudorule035
  Rule name: sudorule035
  Enabled: TRUE
Comment 6 Varun Mylaraiah 2020-03-06 10:47:44 UTC 
Automated test console output:
===============================

2020-03-06T10:34:11 ansible_freeipa_tests/sudo_module.py::Testsudorule01_02_09_07::test_delete_sudorule_members 
2020-03-06T10:34:11 [1m-------------------------------- live log call ---------------------------------[0m
2020-03-06T10:34:11 [pytest_multihost.host.Host.master.ParamikoTransport] [32mINFO[0m RUN ['kinit', 'admin']
2020-03-06T10:34:11 [pytest_multihost.host.Host.master.ParamikoTransport] [32mINFO[0m RUN ['ipa', 'sudorule-show', 'sudorule_1788024']
2020-03-06T10:34:12 [pytest_multihost.host.Host.master.ParamikoTransport] [32mINFO[0m RUN ['kdestroy', '-A']
2020-03-06T10:34:12 [pytest_multihost.host.Host.ansible.ParamikoTransport] [32mINFO[0m WRITE inventory/sudo.hosts
2020-03-06T10:34:12 [pytest_multihost.host.Host.ansible.ParamikoTransport] [32mINFO[0m PUT sudo_module.yml
2020-03-06T10:34:12 [pytest_multihost.host.Host.ansible.ParamikoTransport] [32mINFO[0m RUN ['ansible-playbook', '--ssh-extra-args="-o StrictHostKeyChecking=no"', '-vv', '-i', 'inventory/sudo.hosts', 'sudo_module.yml']
2020-03-06T10:34:18 [pytest_multihost.host.Host.master.ParamikoTransport] [32mINFO[0m RUN ['kinit', 'admin']
2020-03-06T10:34:18 [pytest_multihost.host.Host.master.ParamikoTransport] [32mINFO[0m RUN ['ipa', 'sudorule-show', 'sudorule_1788024']
2020-03-06T10:34:20 [pytest_multihost.host.Host.master.ParamikoTransport] [32mINFO[0m RUN ['kdestroy', '-A']
2020-03-06T10:34:20 [32mPASSED[0m[36m [ 75%][0m
Comment 8 errata-xmlrpc 2020-04-28 16:01:57 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1705
Note You need to log in before you can comment on or make changes to this bug.