Description of problem:
$ oc get vm test --show-labels
NAME AGE RUNNING VOLUME LABELS
test 10m true app=test,flavor.template.kubevirt.io/Custom=true,os.template.kubevirt.io/centos6.0=true,vm.kubevirt.io/template-namespace=default,vm.kubevirt.io/template.revision=1,vm.kubevirt.io/template.version=v0.8.1,vm.kubevirt.io/template=uploaddisk,workload.template.kubevirt.io/server=true
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1. Create a VM with custom Flavor and then check the labels.
@Guohua: Im not sure - why should it be lowercase?
The whole page are lowercase except once letter is uppercase, I thought it should be lowercase for cosmetic.
If it's not necessary, free to close this bug.
If it is just cosmetics I will close it for now. Changing it would mean that we should have some logic to handle VMs created before this change and also the ones after this change. Not too hard but I would like to avoid it if there is no practical reason for that.
We have to align with vm-import-operator project which will be using this label as well in lowercase variant: https://github.com/kubevirt/vm-import-operator/pull/168
We can add logic to our UI to accept both legacy 'Custom and new 'custom' labels. We should also fallback to Custom when this label is missing
We concluded that there is no value in having this label as it is not supported by common templates. We should fallback to the same behaviour as when we the label is missing. We should remove the use of this label in the UI and in vm-import-operator.
Verified that the label is not used anymore.
Verified in console release-4.5 branch commit: 5994c64ee529b650bae348ef78ebc23dca8db5c5
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.
For information on the advisory, and where to find the updated
files, follow the link below.
If the solution does not work for you, open a new bug report.