Bug 1789009 - [RFE] Move the Suffix in the Memory Text Boxes to Drop Down Combo Boxes
Summary: [RFE] Move the Suffix in the Memory Text Boxes to Drop Down Combo Boxes
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: future
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: ---
Assignee: Lucia Jelinkova
QA Contact: Lukas Svaty
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-01-08 15:09 UTC by Steven Rosenberg
Modified: 2022-04-10 09:02 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-04-08 16:48:10 UTC
oVirt Team: Virt
Embargoed:
pm-rhel: ovirt-4.5?
pm-rhel: planning_ack?
pm-rhel: devel_ack?
pm-rhel: testing_ack?


Attachments (Terms of Use)
New Virtual Machine Memory Text Boxes screenshot displaying the current implementation (67.65 KB, image/png)
2020-01-08 15:09 UTC, Steven Rosenberg
no flags Details
Create new VM- Dropdown select for unit of memory.png (584.06 KB, image/png)
2020-01-13 16:06 UTC, Laura Wright
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Bugzilla 1719990 0 unspecified CLOSED (l10n) VMs cannot be created when using the French web interface. 2021-02-22 00:41:40 UTC

Description Steven Rosenberg 2020-01-08 15:09:52 UTC
Created attachment 1650734 [details]
New Virtual Machine Memory Text Boxes screenshot displaying the current implementation

Description of problem: When Creating or Editing a VM and Modifying any of the Memory Values, the suffix such as MB for megabytes, TB for terabytes or GB for gigabytes reside within the Text Box after the numeric values. Not only does this make it challenging for the user to enter in the values, but modifying the suffix to say MP causes the values to be zero when leaving the Text Box. The suffix values are also dependent upon language translations. This has become an issue with French, which uses MO instead of MB, so that the parsing that validates the suffix as MB breaks the update mechanism.

Also the on the fly conversion to megabytes from terabytes or gigabytes is confusing resulting in large numbers and makes their modifications difficult. 

In order to resolve these issues and make the user's experience user friendly, it would be easier to move the suffix to a Drop Down Combo Box where the user can easily choose the following:

MB
TB
GB

The values can then be displayed as per the suffix specified instead of converting to megabytes on the fly, and then on validation they can be converted to megabytes as needed. Auto normalization on reloading should be considered as well, such as preserving the suffix accordingly. 


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Enter the New Virtual Machine or Edit Virtual Machine screen and choose the System Tab.
2. One can see that Memory Size, Maximum Memory, and Physical Memory Guaranteed have the MB suffix within the Text Box or in French Mo. 
3. Change the default to say MP or other invalid value.

Actual results: The value on leaving the Text Box is reset to 0.


Expected results:

A more user friendly approach so that the user can choose the desired suffix easily without side affects or language dependencies.

Additional info:

Comment 1 Steven Rosenberg 2020-01-08 15:19:35 UTC
Could you provide a wire frame design for adding a Drop Down Combo Box for the Memory Suffix as per this report?

Comment 2 Laura Wright 2020-01-13 16:06:27 UTC
Created attachment 1651907 [details]
Create new VM- Dropdown select for unit of memory.png

Here is the design suggestion for updating the units of memory to be more easily edited by the user. I would suggest using the PatternFly 4 text field component (https://www.patternfly.org/v4/documentation/core/components/form), dropdown component (https://www.patternfly.org/v4/documentation/core/components/dropdown#component-title), and a 8px spacer from the PatternFly4 spacer system (https://www.patternfly.org/v4/design-guidelines/styles/spacers#main-content). Let me know if you have any questions or comments about the suggested components or design.

Comment 3 Steven Rosenberg 2020-01-14 15:51:23 UTC
(In reply to Laura Wright from comment #2)
> Created attachment 1651907 [details]
> Create new VM- Dropdown select for unit of memory.png
> 
> Here is the design suggestion for updating the units of memory to be more
> easily edited by the user. I would suggest using the PatternFly 4 text field
> component
> (https://www.patternfly.org/v4/documentation/core/components/form), dropdown
> component
> (https://www.patternfly.org/v4/documentation/core/components/
> dropdown#component-title), and a 8px spacer from the PatternFly4 spacer
> system
> (https://www.patternfly.org/v4/design-guidelines/styles/spacers#main-
> content). Let me know if you have any questions or comments about the
> suggested components or design.

I discussed this issue with Sharon and there are two issues with patternfly 4:

1. None of the existing controls use patternfly 4 currently, so there may be many issues related to this request.
2. The look and feel would be inconsistent if we are only implementing this for the memory controls.

The recommendation is to use PatternFly 3. Support for Patternfly 4 would be a separate issue and would require an upgrade to the entire system.

Comment 4 Laura Wright 2020-01-14 16:45:10 UTC
Using PatternFly 3 components that have the same functionality and behavior work for me. The PatternFly 4 version of it can be more of a future facing iteration.

Comment 6 Sandro Bonazzola 2022-03-29 16:16:40 UTC
We are past 4.5.0 feature freeze, please re-target.

Comment 7 Michal Skrivanek 2022-04-08 16:48:10 UTC
no updates for a long time, missed 4.5 GA, closing


Note You need to log in before you can comment on or make changes to this bug.