Bug 1789283 - Review Request: perl-Net-Facebook-Oauth2 - Simple Perl wrapper around Facebook OAuth 2.0 protocol
Summary: Review Request: perl-Net-Facebook-Oauth2 - Simple Perl wrapper around Faceboo...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-01-09 09:21 UTC by Xavier Bachelot
Modified: 2020-01-19 11:42 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-01-19 11:42:23 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Xavier Bachelot 2020-01-09 09:21:10 UTC
Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Net-Facebook-Oauth2.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Net-Facebook-Oauth2-0.11-1.fc32.src.rpm

Description: 
Net::Facebook::Oauth2 gives you a way to simply access FaceBook Oauth
2.0 protocol.

Fedora Account System Username: xavierb

Comment 1 Xavier Bachelot 2020-01-17 12:23:32 UTC
Hi Jitka,

This module suffers from mostly the same shortcomings you noticed in perl-Time-Fake.

Updated spec and srpm: 
Spec URL: https://www.bachelot.org/fedora/SPECS/perl-Net-Facebook-Oauth2.spec
SRPM URL: https://www.bachelot.org/fedora/SRPMS/perl-Net-Facebook-Oauth2-0.11-1.fc32.src.rpm

Changelog:
- Fix Source0 URL.
- Add missing BR:s.
- Replace PERL_INSTALL_ROOT with DESTDIR.
- Use %%{?perl_default_filter} macro.

Regards,
Xavier

Comment 3 Jitka Plesnikova 2020-01-17 12:53:20 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Net-Facebook-Oauth2-0.11-1.fc32.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Carp)
      1 perl(JSON::MaybeXS)
      1 perl(LWP::Protocol::https)
      1 perl(LWP::UserAgent)
      1 perl(:MODULE_COMPAT_5.30.1)
      1 perl(strict)
      1 perl(URI)
      1 perl(URI::Escape)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Net-Facebook-Oauth2-0.11-1.fc32.noarch.rpm | sort | uniq -c
      1 perl(Net::Facebook::Oauth2) = 0.11
      1 perl-Net-Facebook-Oauth2 = 0.11-1.fc32
Binary provides are Ok.

$ rpmlint ./perl-Net-Facebook-Oauth2*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Resolution:
Approved

Comment 4 Xavier Bachelot 2020-01-17 12:58:07 UTC
Thanks for the review Jitka :-)

Repo request:
https://pagure.io/releng/fedora-scm-requests/issue/21445

Comment 5 Gwyn Ciesla 2020-01-17 14:47:47 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Net-Facebook-Oauth2

Comment 6 Xavier Bachelot 2020-01-19 11:42:23 UTC
Built for Rawhide, F31, F30, EL8, EL7, EL6.


Note You need to log in before you can comment on or make changes to this bug.