RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1789707 - Fix resource leaks, Fix using of undefined value
Summary: Fix resource leaks, Fix using of undefined value
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: createrepo_c
Version: 8.2
Hardware: Unspecified
OS: Unspecified
medium
unspecified
Target Milestone: rc
: 8.0
Assignee: amatej
QA Contact: Eva Mrakova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-01-10 08:36 UTC by Jaroslav Rohel
Modified: 2020-11-04 03:11 UTC (History)
0 users

Fixed In Version: createrepo_c-0.15.10-1.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-04 03:09:16 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2020:4700 0 None None None 2020-11-04 03:09:28 UTC

Description Jaroslav Rohel 2020-01-10 08:36:38 UTC
Description of problems:

1. The value of "ret" variable is not defined at these places in cr_read() in file compression_wrapper.c:
1152: if (cr_file->stat && ret != CR_CW_ERR)
1164:     return ret;

Solution:
Initialize "ret" variable to CR_CW_ERR value at the beginning of the function or set "ret" variable to CR_CW_ERR value before break at line 1138:

--------
2. There are resource leaks in function dump_merged_metadata() in file mergerepo.c.
Allocation of resources:
878: cr_ContentStat *pri_zck_stat = cr_contentstat_new(CR_CHECKSUM_SHA256, NULL);
879: cr_ContentStat *fil_zck_stat = cr_contentstat_new(CR_CHECKSUM_SHA256, NULL);
880: cr_ContentStat *oth_zck_stat = cr_contentstat_new(CR_CHECKSUM_SHA256, NULL);
These resources leaks on more places in the function.

--------
3. There is resource leak in cr_metadata_locate_and_load_xml() in file load_metadata.c.
Allocation:
673: ml = cr_locate_metadata(repopath, TRUE, &tmp_err);
It leaks at line 683.

Version-Release number of selected component (if applicable):
createrepo_c-0.15.1-1.el8

Comment 2 amatej 2020-01-10 14:12:27 UTC
Created a PR here: https://github.com/rpm-software-management/createrepo_c/pull/199

Comment 9 errata-xmlrpc 2020-11-04 03:09:16 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (createrepo_c bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4700


Note You need to log in before you can comment on or make changes to this bug.