Bug 1789916 - tigervnc CXXFLAGS should explicitly set -std=c++11
Summary: tigervnc CXXFLAGS should explicitly set -std=c++11
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: tigervnc
Version: rawhide
Hardware: All
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Jan Grulich
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-01-10 17:31 UTC by Pat Riehecky
Modified: 2020-01-31 02:00 UTC (History)
4 users (show)

Fixed In Version: tigervnc-1.10.1-2.fc30 tigervnc-1.10.1-2.fc31
Clone Of:
Environment:
Last Closed: 2020-01-31 01:12:21 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Pat Riehecky 2020-01-10 17:31:54 UTC
Description of problem:

TigerVNC is using parts of the C++11 standard within their code base.  The CXXFLAGS should be explicitly set to use that behavior so that the compiler knows to use the expected behavior there.


Version-Release number of selected component (if applicable):tigervnc-1.10.1-1.fc31


How reproducible:
100%

Steps to Reproduce:
1. Rebuild the RPM with a compiler that defaults to use C++99
2.
3.

Actual results:
/builddir/build/BUILD/tigervnc-1.10.1/common/rfb/util.h:68:21: warning: non-static data member initializers only available with -std=c++11 or -std=gnu++11 [enabled by default]
     size_t length = 0;
                     ^
/builddir/build/BUILD/tigervnc-1.10.1/common/rfb/util.h: In destructor 'rfb::CharArray::~CharArray()':
/builddir/build/BUILD/tigervnc-1.10.1/common/rfb/util.h:60:15: error: 'nullptr' was not declared in this scope
         buf = nullptr;
               ^


Expected results:
Builds as expected

Additional info:

Change :

export CXXFLAGS="$CFLAGS"

to

export CXXFLAGS="$CFLAGS -std=c++11"

Comment 1 Fedora Update System 2020-01-14 01:43:39 UTC
tigervnc-1.10.1-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e4a8ad0d12

Comment 2 Fedora Update System 2020-01-14 02:48:25 UTC
tigervnc-1.10.1-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-067347e8f7

Comment 3 Fedora Update System 2020-01-31 01:12:21 UTC
tigervnc-1.10.1-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 4 Fedora Update System 2020-01-31 02:00:12 UTC
tigervnc-1.10.1-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.