Bug 1789919 - Review Request: freewrl - FreeWRL is an X3D/VRML open source viewer
Summary: Review Request: freewrl - FreeWRL is an X3D/VRML open source viewer
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-01-10 17:35 UTC by J. Scheurich
Modified: 2020-01-13 15:40 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-01-13 15:04:46 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description J. Scheurich 2020-01-10 17:35:23 UTC
Spec URL: https://wdune.ourproject.org/examples/freewrl.spec
SRPM URL: https://wdune.ourproject.org/examples/freewrl-4.0-1.src.rpm
Description: 
FreeWRL is an X3D/VRML open source viewer for Windows, Linux, OSX and Android.

FreeWRL has had a long track record, is here to stay. X3D Components get added, problems get resolved. 
Fedora Accoount System Username: mufti11

Comment 1 Antonio T. (sagitter) 2020-01-10 19:50:32 UTC
Hi J.

Why do you disable debuginfo package:

%global debug_package %{nil}

?

Comment 2 J. Scheurich 2020-01-11 04:49:39 UTC
It do not build without disabling the debuginfo
I have no idea why

The problem is something with empty *debuginfo*.list 8-(

Comment 3 Antonio T. (sagitter) 2020-01-11 11:46:58 UTC
Do a scratch-build without any obstacles for debuginfo files and post a link to the build log, please.

Comment 4 Robert-André Mauchin 🐧 2020-01-13 00:25:46 UTC
 - Use the source from the official website, not from "wdune", you can't just copy source tike that. Ask upstream to publish the source for 4.0.0 on their Sourceforge. Alternatively generate the source from the GIT repo but don't put on your server, instead just put the tar.gz as source: but add comment explaining how you generated the tar.gz

I would recommend:

# git clone https://git.code.sf.net/p/freewrl/git freewrl
# cd freewrl/freex3d/
# git archive --format tar.gz --prefix freewrl-4.0.0/ 36b721ca374d695c10af8137c943f27f12503014 > freewrl-4.0.0.tar.gz
Source: freewrl-4.0.0.tar.gz

 - Missing dist tag:

Release: 1%{?dist}

 - Why? This is surely not needed as build time:

BuildRequires: bitstream-vera-sans-fonts

 - This should be a Requires, not a BuildRequires:

Requires: desktop-file-utils

 - Why does it Requires Firefoy??

Requires: firefox

 - No:

%global debug_package %{nil}

You need to find why it's not working as expected. Mostly because you installed the library as 0644 instead of 0755: it needs to be executable to be stripped:

install -m 0755 -p ../freewrl-git/freex3d/src/lib/.libs/libFreeWRL.so.4.1.0 $RPM_BUILD_ROOT/%{_libexecdir}/libFreeWRL.so.4.1.0

Same, remove that junk:

echo > debugsourcefiles.list
echo >> debugsourcefiles.list

/usr/lib/rpm/find-debuginfo.sh

 - Are you sure there isn't a make install script? Yes there is.

 - No:

install -m 644 -p ../freewrl-git/freex3d/COPYING $RPM_BUILD_ROOT/%{_datadir}/freewrl
install -m 644 -p ../freewrl-git/freex3d/COPYING.LESSER $RPM_BUILD_ROOT/%{_datadir}/freewrl

 Don't install these licenses in datadir. Instead include them with %license in %files.

%license COPYING COPYING.LESSER

 - Glob the extension for man pages as the compression may change in the future:

%{_mandir}/man1/freewrl.1.*

 - Fix your changelog entry:

* Fri Jan 10 2020 J Scheurich <mufti11> - 4.0-1
- Initial packaging

 - the library should not go to libexecdir but libdir

 - Add docs:

%doc AUTHORS ChangeLog NEWS README TODO xAI-DESIGN.README


Reworked SPEC to work with more stuff (OpenCL, OpenGL), there are two bugs related to OpenCL that should be fixed upstream but I'm not touching Sourceforge with a ten foot pole.

======================================================================================================================
Name:     freewrl
Summary:  X3D/VRML open source viewer
Version:  4.0
Release:  1%{?dist}
License:  GPLv3+
URL:      http://freewrl.sourceforge.net/
# git clone https://git.code.sf.net/p/freewrl/git freewrl
# cd freewrl/freex3d/
# git archive --format tar.gz --prefix freewrl-4.0/ 36b721ca374d695c10af8137c943f27f12503014 > freewrl-4.0.tar.gz
Source:   freewrl-4.0.tar.gz
BuildRequires: gcc-g++
BuildRequires: autoconf
BuildRequires: automake
BuildRequires: libtool
BuildRequires: pkgconfig(fontconfig)
BuildRequires: pkgconfig(freealut)
BuildRequires: pkgconfig(freetype2)
BuildRequires: pkgconfig(gl)
BuildRequires: pkgconfig(glu)
BuildRequires: pkgconfig(imlib2)
BuildRequires: pkgconfig(libcurl)
BuildRequires: pkgconfig(libjpeg)
BuildRequires: pkgconfig(liblo)
BuildRequires: pkgconfig(libpng)
BuildRequires: pkgconfig(libxml-2.0)
BuildRequires: pkgconfig(ode)
BuildRequires: pkgconfig(openal)
BuildRequires: pkgconfig(OpenCL)
BuildRequires: pkgconfig(x11)
BuildRequires: pkgconfig(xaw7)
BuildRequires: pkgconfig(xmu)
BuildRequires: pkgconfig(xproto)
BuildRequires: pkgconfig(xt)
BuildRequires: pkgconfig(xxf86vm)
BuildRequires: pkgconfig(zlib)
Requires: %{name}-libs = %{version}-%{release}
Requires: desktop-file-utils
Recommends: bitstream-vera-sans-fonts
Recommends: firefox
Recommends: ImageMagick
Recommends: sox
Recommends: wget

%description
FreeWRL is an X3D/VRML open source viewer for Windows, Linux, OSX and Android.

%package libs
Summary: FreeWRL library

%description libs
Library files for FreeWRL.

%package devel
Summary: FreeWRL development files
Requires: %{name}-libs%{?_isa} = %{version}-%{release}

%description devel
Development files for FreeWRL.

%prep
%autosetup
# Typo in OpenCL code
sed -i "s|#if (defined(_MSC_VER)|#if (defined(_MSC_VER))|" src/lib/opencl/OpenCL_Utils.h
# Bug in OpenCL code
sed -i "s|float awidth = (float) tg->Bindable.naviinfo.width;|struct sNaviInfo *naviinfo;\n	        naviinfo = (struct sNaviInfo *)tg->Bindable.naviinfo;\n	        float awidth = (float) naviinfo->width;|" src/lib/scenegraph/Collision.c

%build
autoreconf -fiv
%configure --enable-rbp --with-OpenCL=yes
%make_build

%install
%make_install
rm -f %{buildroot}%{_libdir}/*.{a,la}

%files
%doc AUTHORS ChangeLog NEWS README TODO xAI-DESIGN.README
%license COPYING COPYING.LESSER
%{_bindir}/freewrl
%{_bindir}/freewrl_msg
%{_datadir}/applications/freewrl.desktop
%{_datadir}/pixmaps/freewrl.png
%{_mandir}/man1/freewrl.1.*

%files libs
%{_libdir}/libFreeWRL.so.4*

%files devel
%{_includedir}/libFreeWRL.h
%{_libdir}/libFreeWRL.so
%{_libdir}/pkgconfig/libFreeWRL.pc

%changelog
* Fri Jan 10 2020 J Scheurich <mufti11> - 4.0-1
- Initial packaging

=================================================================================================================

Comment 5 Tom "spot" Callaway 2020-01-13 15:04:46 UTC
The freewrl package is already in Fedora: https://src.fedoraproject.org/rpms/freewrl/

Comment 6 J. Scheurich 2020-01-13 15:35:55 UTC
> The freewrl package is already in Fedora

True
I give up the review request

Comment 7 Tom "spot" Callaway 2020-01-13 15:40:29 UTC
(In reply to J. Scheurich from comment #6)
> > The freewrl package is already in Fedora
> 
> True
> I give up the review request

Patches/pull requests for improvements are always appreciated. :)


Note You need to log in before you can comment on or make changes to this bug.