Bug 1790149 - Review Request: ocaml-markup - Error-recovering streaming HTML5 and XML parsers for OCaml
Summary: Review Request: ocaml-markup - Error-recovering streaming HTML5 and XML parse...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1789211 1790146
Blocks: 1790152
TreeView+ depends on / blocked
 
Reported: 2020-01-12 04:59 UTC by Jerry James
Modified: 2020-01-22 02:26 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-01-22 02:26:43 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Jerry James 2020-01-12 04:59:54 UTC
Spec URL: https://jjames.fedorapeople.org/ocaml-markup/ocaml-markup.spec
SRPM URL: https://jjames.fedorapeople.org/ocaml-markup/ocaml-markup-0.8.2-1.fc32.src.rpm
RPMLINTRC URL: https://jjames.fedorapeople.org/ocaml-markup/ocaml-markup.rpmlintrc
Fedora Account System Username: jjames
Description: Markup.ml is a pair of parsers implementing the HTML5 and XML specifications, including error recovery.  Usage is simple, because each parser is a function from byte streams to parsing signal streams.

In addition to being error-correcting, the parsers are:
- **streaming**: parsing partial input and emitting signals while more
  input is still being received;
- **lazy**: not parsing input unless you have requested the next parsing
  signal, so you can easily stop parsing part-way through a document;
- **non-blocking**: they can be used with Lwt, but still provide a
  straightforward synchronous interface for simple usage; and
- **one-pass**: memory consumption is limited since the parsers don't
  build up a document representation, nor buffer input beyond a small
  amount of lookahead.

The parsers detect character encodings automatically, and emit everything in UTF-8.  The HTML parser understands SVG and MathML, in addition to HTML5.

Comment 1 Robert-André Mauchin 🐧 2020-01-12 17:48:33 UTC
Package approved.



Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License", "*No copyright* Expat
     License". 25 files have unknown license. Detailed output of
     licensecheck in /home/bob/packaging/review/ocaml-markup/review-ocaml-
     markup/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 296960 bytes in 28 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ocaml-
     markup-lwt-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ocaml-markup-0.8.2-1.fc32.x86_64.rpm
          ocaml-markup-devel-0.8.2-1.fc32.x86_64.rpm
          ocaml-markup-lwt-0.8.2-1.fc32.x86_64.rpm
          ocaml-markup-lwt-devel-0.8.2-1.fc32.x86_64.rpm
          ocaml-markup-debuginfo-0.8.2-1.fc32.x86_64.rpm
          ocaml-markup-debugsource-0.8.2-1.fc32.x86_64.rpm
          ocaml-markup-0.8.2-1.fc32.src.rpm
ocaml-markup.x86_64: W: spelling-error Summary(en_US) parsers -> parser, parses, parers
ocaml-markup.x86_64: W: spelling-error %description -l en_US parsers -> parser, parses, parers
ocaml-markup.x86_64: W: spelling-error %description -l en_US lookahead -> look ahead, look-ahead, lookalike
ocaml-markup-lwt.x86_64: W: no-documentation
ocaml-markup-lwt-devel.x86_64: W: no-documentation
ocaml-markup.src: W: spelling-error Summary(en_US) parsers -> parser, parses, parers
ocaml-markup.src: W: spelling-error %description -l en_US parsers -> parser, parses, parers
ocaml-markup.src: W: spelling-error %description -l en_US lookahead -> look ahead, look-ahead, lookalike
7 packages and 0 specfiles checked; 0 errors, 8 warnings.

Comment 2 Gwyn Ciesla 2020-01-13 22:32:51 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-markup

Comment 3 Jerry James 2020-01-22 02:26:43 UTC
Built in Rawhide.


Note You need to log in before you can comment on or make changes to this bug.