Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1791310

Summary:	Migration fails if backup storage location's Spec.Config["insecureSkipTLSVerify"] is empty
Product:	OpenShift Container Platform	Reporter:	Scott Seago <sseago>
Component:	Migration Tooling	Assignee:	Sam Lucidi <slucidi>
Status:	CLOSED ERRATA	QA Contact:	Xin jiang <xjiang>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.3.0	CC:	ernelson, jmatthew, sregidor
Target Milestone:	---
Target Release:	4.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-06 20:21:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Scott Seago 2020-01-15 13:57:03 UTC

Description of problem:
If the configuration element for "insecureSkipTLSVerify" is missing, migration fails because the associated ResticRepository fails with a 'NotReady' status with the following error message: 'strconv.ParseBool: parsing "": invalid syntax'

Version-Release number of selected component (if applicable): 4.3.0


How reproducible:
Always

Steps to Reproduce:
1. Create a BackupStorageLocation without Spec.Config.InsecureSkipTLSVerify
2. Migrate a MigPlan with restic copy of PVs using this BSL

Actual results:
Migration fails on backup with this error message: `restic repository is not ready: strconv.ParseBool: parsing \"\": invalid syntax"`

Expected results:
Migration succeeds

Additional info:

Comment 1 Scott Seago 2020-01-15 13:59:18 UTC

PR is already merged for this: https://github.com/fusor/velero/pull/49

Comment 3 Sergio 2020-01-22 13:01:20 UTC

Verified in CAM 1.1 stage

Velero
    imageID: registry.stage.redhat.io/rhcam-1-1/openshift-migration-velero-rhel8@sha256:89e56f7f08802e92a763ca3c7336209e58849b9ac9ea90ddc76d9b94d981b8b9
    imageID: registry.stage.redhat.io/rhcam-1-1/openshift-migration-plugin-rhel8@sha256:9c6eceba0c422b9f375c3ab785ff392093493ce33def7c761d7cedc51cde775d
    imageID: registry.stage.redhat.io/rhcam-1-1/openshift-migration-velero-plugin-for-aws-rhel8@sha256:5235eeeee330165eef77ac8d823eed384c9108884f6be49c9ab47944051af91e
    imageID: registry.stage.redhat.io/rhcam-1-1/openshift-migration-velero-plugin-for-gcp-rhel8@sha256:789b12ff351d3edde735b9f5eebe494a8ac5a94604b419dfd84e87d073b04e9e
    imageID: registry.stage.redhat.io/rhcam-1-1/openshift-migration-velero-plugin-for-microsoft-azure-rhel8@sha256:b98f1c61ba347aaa0c8dac5c34b6be4b8cce20c8ff462f476a3347d767ad0a93

This situation cannot happen if BackupStorageLocation resources are created automatically from the MigPlan resource, since they always have value "true" or "false".

In order to reproduce it, the BackupStorageLocation resource was modified manually after the plan creation in order to remove the field "insecureSkipTLSVerify".

Migrations finished OK, and no problem was found.

Comment 5 errata-xmlrpc 2020-02-06 20:21:05 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:0440