RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1791537 - [machines] Editing network interface will cause network source changed to wrong characters.
Summary: [machines] Editing network interface will cause network source changed to wro...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: cockpit-appstream
Version: 8.2
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: rc
: 8.2
Assignee: Katerina Koukiou
QA Contact: YunmingYang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-01-16 05:48 UTC by YunmingYang
Modified: 2023-04-28 11:43 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-04-28 15:43:08 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHELPLAN-32481 0 None None None 2023-04-28 11:43:53 UTC
Red Hat Product Errata RHBA-2020:1639 0 None None None 2020-04-28 15:43:15 UTC

Description YunmingYang 2020-01-16 05:48:37 UTC
Description of problem:
Editing network interface will cause network source changed to wrong characters.

Version-Release number of selected component (if applicable):
cockpit-machines-210-1.el8.noarch
libvirt-dbus-1.2.0-3.module+el8.1.0+4066+0f1aadab.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare a linux bridge and an off VM
2. Switch to the 'Network Interfaces' tab of the VM
3. Click 'Edit' button, then click 'Add', no changing for the network interface which is edited

Actual results:
The source of the edited network interface will be changed to wrong characters

Expected results:
The network interfaces can be saved correctly

Additional info:
There is another way to reproduce this issue:
1. Prepare a linux bridge and an off VM
2. Switch to the 'Network Interfaces' tab of the VM
3. Edit the network interface to the bridge which is created in step 1
4. Delete the bridge, then create a new one
5. Edit the VM network interface to the new bridge

Comment 1 YunmingYang 2020-01-16 06:03:46 UTC
Sorry for miss a step in 'Steps to Reproduce:' before step 3:
the network interface which is edited should be changed 'Interface Type' to 'Bridge to LAN' firstly.And the source should be chosen to the bridge which is created in step 1.

There is also another condition which can reproduce:
1. Prepare a linux bridge and an off VM
2. Switch to the 'Network Interfaces' tab of the VM
3. Change the network interface to 'Diect attachment', and choose the bridge which is created in the step 1 for the source.
4. Re-click 'Add Network Interfaces' button, then click 'Add' button without changing

Comment 2 Katerina Koukiou 2020-01-16 12:18:26 UTC
@YunmingYang how do you create the bridge?

If you create it by libvirt CLI, aka with `# virsh iface-bridge $IFACE $BRIDGE_NAME` things should work as expected, but if you create the bridge by some other way the new bridge will not be available in the cockpit-machines UI till you refresh the page because we won't have gotten any event which will lead us to update our net node devices list.

Comment 3 Martin Pitt 2020-01-16 18:00:25 UTC
Katerina fixes this in https://github.com/cockpit-project/cockpit/pull/13408 , thanks!

Comment 4 YunmingYang 2020-01-17 03:08:20 UTC
@Katerina, I created the bridge through cockpit UI. In fact, I refresh the page after creating the bridge, sorry for missing this step in the 'Steps to Reproduce'

Comment 5 Simon Kobyda 2020-01-21 17:04:27 UTC
Does the other bridge you created have the same name as the bridge you deleted?

Comment 6 Xianghua Chen 2020-01-22 03:29:05 UTC
It has different name for the second bridge.
But I tried the same name too, it has the same problem. 
I think the name does not matter because the steps in comment 1 can also reproduce the problem.

Comment 8 Xianghua Chen 2020-02-06 03:42:54 UTC
Verified with package:
cockpit-machines-211-1.el8.noarch
libvirt-dbus-1.2.0-3.module+el8.1.0+4066+0f1aadab.x86_64

Steps:
1. Prepare an off VM 
2. Prepare a linux bridge on "Networking" page
3. Refresh the "Virtual Machines" Page, switch to the 'Network Interfaces' tab of the VM
4. Edit the network interface to the bridge which is created in step 2
5. Click 'Edit' button, then click 'Add', no changing for the network interface which is edited
6. Delete the bridge on "Networking" page, then create a new one with different name
7. Refresh the "Virtual Machines" Page, edit the VM network interface to the new bridge

In step 4, the source is changed to the new bridge.
In step 5, the source of the edited network interface will not be changed to wrong characters
In step 7, the source can be changed to the new bridge created in step 6

So verified.

Comment 10 errata-xmlrpc 2020-04-28 15:43:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1639


Note You need to log in before you can comment on or make changes to this bug.