Bug 1791961 - python-IPy fails to build with Python 3.9: uses Thread.isAlive()
Summary: python-IPy fails to build with Python 3.9: uses Thread.isAlive()
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-IPy
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON39 F33FTBFS
TreeView+ depends on / blocked
 
Reported: 2020-01-16 19:07 UTC by Miro Hrončok
Modified: 2020-06-02 22:59 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-02 22:59:56 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2020-01-16 19:07:24 UTC
python-IPy fails to build with Python 3.9.0a2.

======================================================================
ERROR: testContains (__main__.IPSetChecks)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/IPy-0.81/test/test_IPy.py", line 832, in setUp
    self.t = IPy.IPSet(self.a)
  File "/builddir/build/BUILD/IPy-0.81/IPy.py", line 1023, in __init__
    if not isinstance(iterable, collections.Iterable):
AttributeError: module 'collections' has no attribute 'Iterable'

======================================================================
ERROR: testVersionSeparation (__main__.IPSetChecks)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/IPy-0.81/test/test_IPy.py", line 832, in setUp
    self.t = IPy.IPSet(self.a)
  File "/builddir/build/BUILD/IPy-0.81/IPy.py", line 1023, in __init__
    if not isinstance(iterable, collections.Iterable):
AttributeError: module 'collections' has no attribute 'Iterable'

See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The abstract base classes in collections.abc no longer are exposed in the regular collections module. This will help create a clearer distinction between the concrete classes and the abstract base classes."



======================================================================
ERROR: testNulNetmask (__main__.RegressionTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/IPy-0.81/test/test_IPy.py", line 853, in testNulNetmask
    ip = timeout(IPy.IP, ["0.0.0.0/0.0.0.0"], timeout_duration=0.250, default=None)
  File "/builddir/build/BUILD/IPy-0.81/test/test_IPy.py", line 820, in timeout
    if it.isAlive():
AttributeError: 'InterruptableThread' object has no attribute 'isAlive'


See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The isAlive() method of threading.Thread has been removed. It was deprecated since Python 3.8. Use is_alive() instead."


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01148689-python-IPy/

For all our attempts to build python-IPy with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-IPy/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Hugo van Kemenade 2020-01-20 20:29:50 UTC
There's already a pending PR to fix this: https://github.com/autocracy/python-ipy/pull/66

Comment 2 Ben Cotton 2020-02-11 17:31:52 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 3 Miro Hrončok 2020-02-28 09:05:27 UTC
In Python 3.9.0a4 we have managed to revert the change that disables importing abstract base classes (collections.abc) directly form the regular collections module. It was reverted to ease transition for projects that did not yet actually dropped support for Python 2.7. The removal is scheduled for Python 3.10 instead.

Leaving this open for the second problem.

Comment 4 Miro Hrončok 2020-05-25 13:01:12 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 5 Miro Hrončok 2020-05-29 07:11:18 UTC
Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.

Comment 6 Adam Williamson 2020-06-02 22:59:56 UTC
Fixed: https://koji.fedoraproject.org/koji/taskinfo?taskID=45332641


Note You need to log in before you can comment on or make changes to this bug.