python-collada fails to build with Python 3.9.0a2. ERROR: test_effect_saving (collada.tests.test_material.TestMaterial) ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/pycollada-0.6/collada/tests/test_material.py", line 66, in test_effect_saving loaded_effect = collada.material.Effect.load(self.dummy, {}, File "/builddir/build/BUILD/pycollada-0.6/collada/material.py", line 613, in load try: props[key] = Effect._loadShadingParam(collada, localscope, pnode) File "/builddir/build/BUILD/pycollada-0.6/collada/material.py", line 659, in _loadShadingParam children = node.getchildren() AttributeError: 'xml.etree.ElementTree.Element' object has no attribute 'getchildren' (14 errors like this in total) See https://docs.python.org/3.9/whatsnew/3.9.html#removed "Methods getchildren() and getiterator() in the ElementTree module have been removed. They were deprecated in Python 3.2. Use functions list() and iter() instead. The xml.etree.cElementTree module has been removed." For the build logs, see: https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01148855-python-collada/ For all our attempts to build python-collada with Python 3.9, see: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-collada/ Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/ Let us know here if you have any questions. Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9. A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon. We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle. Changing version to 32.
Upstream closed the issue (for questionable reasons). What are the next steps? Do you want me to help you with the patch (they have indicated they's merge it)? Is should be quite straightforward.
That would be very helpful! I might be able to figure it out but may not have time in the near future. If you can get it patched, I'll take care of submitting the PR upstream.
I applied your pull request as a patch to master, verified it builds with current rawhide, and commited it. I think that should be enough to close this bug?
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-collada/ yes! thank you.