Bug 1793021 - python-test_server fails to build with Python 3.9: imports abc from collections
Summary: python-test_server fails to build with Python 3.9: imports abc from collections
Keywords:
Status: CLOSED DUPLICATE of bug 1926091
Alias: None
Product: Fedora
Classification: Fedora
Component: python-test_server
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Raphael Groner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON39
TreeView+ depends on / blocked
 
Reported: 2020-01-20 14:06 UTC by Miro Hrončok
Modified: 2021-02-17 16:44 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-02-28 09:07:59 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github lorien test_server issues 23 0 None open Importing ABC directly from collections module was removed in Python 3.9 2021-02-17 16:43:32 UTC

Description Miro Hrončok 2020-01-20 14:06:57 UTC
python-test_server fails to build with Python 3.9.0a2.

_________________________ ERROR collecting test/bug.py _________________________
ImportError while importing test module '/builddir/build/BUILD/test_server-0.0.31/test/bug.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test/bug.py:7: in <module>
    from test_server import WaitTimeoutError
test_server/__init__.py:1: in <module>
    from test_server.server import *  # noqa pylint: disable=wildcard-import
test_server/server.py:9: in <module>
    from collections import defaultdict, Iterable
E   ImportError: cannot import name 'Iterable' from 'collections' (/usr/lib64/python3.9/collections/__init__.py)
______________________ ERROR collecting test/callbacks.py ______________________
ImportError while importing test module '/builddir/build/BUILD/test_server-0.0.31/test/callbacks.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test/callbacks.py:7: in <module>
    from .util import (# pylint: disable=unused-import
test/util.py:3: in <module>
    from test_server import TestServer
test_server/__init__.py:1: in <module>
    from test_server.server import *  # noqa pylint: disable=wildcard-import
test_server/server.py:9: in <module>
    from collections import defaultdict, Iterable
E   ImportError: cannot import name 'Iterable' from 'collections' (/usr/lib64/python3.9/collections/__init__.py)
_______________________ ERROR collecting test/server.py ________________________
ImportError while importing test module '/builddir/build/BUILD/test_server-0.0.31/test/server.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test/server.py:15: in <module>
    from test_server import TestServer, WaitTimeoutError
test_server/__init__.py:1: in <module>
    from test_server.server import *  # noqa pylint: disable=wildcard-import
test_server/server.py:9: in <module>
    from collections import defaultdict, Iterable
E   ImportError: cannot import name 'Iterable' from 'collections' (/usr/lib64/python3.9/collections/__init__.py)
________________________ ERROR collecting test/util.py _________________________
ImportError while importing test module '/builddir/build/BUILD/test_server-0.0.31/test/util.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
test/util.py:3: in <module>
    from test_server import TestServer
test_server/__init__.py:1: in <module>
    from test_server.server import *  # noqa pylint: disable=wildcard-import
test_server/server.py:9: in <module>
    from collections import defaultdict, Iterable
E   ImportError: cannot import name 'Iterable' from 'collections' (/usr/lib64/python3.9/collections/__init__.py)
!!!!!!!!!!!!!!!!!!! Interrupted: 4 errors during collection !!!!!!!!!!!!!!!!!!!!

See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The abstract base classes in collections.abc no longer are exposed in the regular collections module. This will help create a clearer distinction between the concrete classes and the abstract base classes."


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01162352-python-test_server/

For all our attempts to build python-test_server with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-test_server/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karthikeyan Singaravelan 2020-01-22 12:50:31 UTC
Upstream issue : https://github.com/lorien/test_server/issues/23

Comment 2 Ben Cotton 2020-02-11 17:28:45 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 3 Raphael Groner 2020-02-15 10:12:16 UTC
Maybe try to rebuild with the proposed patch mentioned in the upstream issue.

Comment 4 Miro Hrončok 2020-02-28 09:07:59 UTC
In Python 3.9.0a4 we have managed to revert the change that disables importing abstract base classes (collections.abc) directly form the regular collections module. It was reverted to ease transition for projects that did not yet actually dropped support for Python 2.7. The removal is scheduled for Python 3.10 instead.

We are mass closing all the bug reports about build failures that were caused by this. Expect a new Bugzilla report in case this package fails to build with Python 3.9 for a different reason as well.

In case you haven't done this already, we highly recommend to talk to your upstream and get this fixed anyway, because this will return in Python 3.10 and Python upstream is very unlikely to postpone this once more. In case you've already done that, thank you (this message is mass posted to all the relevant Bugzillas).

Comment 5 Raphael Groner 2021-02-17 16:44:22 UTC

*** This bug has been marked as a duplicate of bug 1926091 ***


Note You need to log in before you can comment on or make changes to this bug.