Description of problem: Spec URL: https://copr-be.cloud.fedoraproject.org/results/mkyral/kf5-unstable/fedora-31-x86_64/01167928-kf5-kquickcharts/kf5-kquickcharts.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mkyral/kf5-unstable/fedora-31-x86_64/01167928-kf5-kquickcharts/kf5-kquickcharts-5.66.0-1.fc31.src.rpm Description: The KF5 module that provides a set of charts that can be used from QtQuick applications. Fedora Account System Username: mkyral Additional info: New KF5 module thet has been introduced in KF5-5.66. It is required by the plasma-5.18 notification widget to work properly.
- Should be ok like this: License: LGPLv2+ and GPLv2+ and: License: LGPLv2+ - URL should not point to Baloo: URL: https://community.kde.org/Baloo #URL: https://cgit.kde.org/%{framework}.git Maybe use https://cgit.kde.org/kquickcharts.git/about/ ? - Explicitly BR gcc-c++ - Not needed anymore unless EPEL: %ldconfig_scriptlets libs - -devel is missing correct Requires arch, version and release: %package devel Summary: Development files for %{name} # KDE e.V. may determine that future LGPL versions are accepted License: LGPLv2 or LGPLv3 Requires: %{name}-libs%{?_isa} = %{version}-%{release} - You should own these directories: [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/qt5/qml/org/kde/quickcharts, /usr/lib64/cmake/KF5QuickCharts, /usr/lib64/qt5/qml/org/kde/quickcharts/controls - Rework Summary: no longer than 80 characters, no dot at the end: kf5-kquickcharts.x86_64: W: summary-ended-with-dot C The KF5 module that provides a set of charts that can be used from QtQuick applications. kf5-kquickcharts.x86_64: E: summary-too-long C The KF5 module that provides a set of charts that can be used from QtQuick applications. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "LGPL (v2.1 or v3)", "Expat License". 25 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/kf5-kquickcharts/review- kf5-kquickcharts/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/qt5/qml/org/kde/quickcharts, /usr/lib64/cmake/KF5QuickCharts, /usr/lib64/qt5/qml/org/kde/quickcharts/controls [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [!]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in kf5-kquickcharts-devel , kf5-kquickcharts-libs [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: kf5-kquickcharts-5.66.0-1.fc32.x86_64.rpm kf5-kquickcharts-devel-5.66.0-1.fc32.x86_64.rpm kf5-kquickcharts-libs-5.66.0-1.fc32.x86_64.rpm kf5-kquickcharts-debugsource-5.66.0-1.fc32.x86_64.rpm kf5-kquickcharts-5.66.0-1.fc32.src.rpm kf5-kquickcharts.x86_64: W: summary-ended-with-dot C The KF5 module that provides a set of charts that can be used from QtQuick applications. kf5-kquickcharts.x86_64: E: summary-too-long C The KF5 module that provides a set of charts that can be used from QtQuick applications. kf5-kquickcharts.x86_64: E: description-line-too-long C The KF5 module that provides a set of charts that can be used from QtQuick applications.. kf5-kquickcharts.x86_64: W: only-non-binary-in-usr-lib kf5-kquickcharts.x86_64: W: no-documentation kf5-kquickcharts-devel.x86_64: W: only-non-binary-in-usr-lib kf5-kquickcharts-devel.x86_64: W: no-documentation kf5-kquickcharts-libs.x86_64: W: no-documentation kf5-kquickcharts.src: W: summary-ended-with-dot C The KF5 module that provides a set of charts that can be used from QtQuick applications. kf5-kquickcharts.src: E: summary-too-long C The KF5 module that provides a set of charts that can be used from QtQuick applications. kf5-kquickcharts.src: E: description-line-too-long C The KF5 module that provides a set of charts that can be used from QtQuick applications.. kf5-kquickcharts.src:19: W: macro-in-comment %{framework} kf5-kquickcharts.src: E: specfile-error warning: Macro expanded in comment on line 19: %{framework}.git 5 packages and 0 specfiles checked; 5 errors, 8 warnings.
I hope you don't mind me stepping in, but this is currently blocking Plasma in Rawhide so I did some correction myself: Spec URL: https://jgrulich.fedorapeople.org/kf5-kquickcharts/kf5-kquickcharts.spec SRPM URL: https://jgrulich.fedorapeople.org/kf5-kquickcharts/kf5-kquickcharts-5.66.0-1.fc31.src.rpm Description: The Quick Charts module provides a set of charts that can be used from QtQuick applications. They are intended to be used for both simple display of data as well as continuous display of high-volume data (often referred to as plotters). The charts use a system called distance fields for their accelerated rendering, which provides ways of using the GPU for rendering 2D shapes without loss of quality. Fedora Account System Username: jgrulich
(In reply to Jan Grulich from comment #2) > I hope you don't mind me stepping in, but this is currently blocking Plasma > in Rawhide so I did some correction myself: You should own /usr/lib64/qt5/qml/org/kde/quickcharts/controls too. Package is approved with your correction but please fix the aforementioned issue.
Thanks. I fixed it.
Martine, it needs to be you who asks for the repository, because you are the author of this bug, can you please do that? Just run: fedpkg request-repo kf5-kquickcharts 1793041 fedpkg request-branch --repo kf5-kquickcharts f30 fedpkg request-branch --repo kf5-kquickcharts f31
Thanks a lot for fixing! Repo requested: https://pagure.io/releng/fedora-scm-requests/issue/21772 https://pagure.io/releng/fedora-scm-requests/issue/21773 https://pagure.io/releng/fedora-scm-requests/issue/21774
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/kf5-kquickcharts
Can you please add me (rdieter) as admin in pagure, and give @kde-sig group commit rights? Thanks. (Or just do item 1, and I can do the second)