Bug 1793087 - [Test-only] Fix deployOrWipeTestingInfrastrucure in BeforeTestSuitSetup for CDI
Summary: [Test-only] Fix deployOrWipeTestingInfrastrucure in BeforeTestSuitSetup for CDI
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: Container Native Virtualization (CNV)
Classification: Red Hat
Component: Storage
Version: 2.2.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Maya Rashish
QA Contact: Qixuan Wang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-01-20 16:12 UTC by Israel Pinto
Modified: 2020-03-11 14:14 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-11 14:07:01 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Israel Pinto 2020-01-20 16:12:35 UTC
Description of problem:
We found that if we run kubevirt test with  -installed-namespace=openshift-cnv 
the CDI deployment is  deleted.
With installed-namespace=kubevirt-hyperconverged all works.

Version-Release number of selected component (if applicable):
CNV-2.2

It's tests BZ.

Comment 1 Maya Rashish 2020-01-21 08:45:45 UTC
I wonder if we're about to make a similar bug report for how it manages storageclasses (unconditionally creates at the start of testing, and destroys at the end)
https://github.com/kubevirt/kubevirt/blob/d072d7ffcbba8d862e79db7749fd0effe2ca2f4e/tests/utils.go#L556-L559

Comment 2 Maya Rashish 2020-01-21 10:44:29 UTC
Targeting 2.3.0 because we can avoid this issue by not using --deploy-testing-infra.
This flag sets up missing bits in the environment, our test environment should have all the parts it needs to run the tests.

Comment 3 Natalie Gavrielov 2020-01-22 13:25:38 UTC
Minimal risk for 2.2 release so let's try to backport it there

Comment 4 Maya Rashish 2020-01-22 13:39:03 UTC
I initially assumed that we want the flag to not exist because it's likely to damage clusters.
That's a really risky thing to backport at all.

What are you hoping to fix?

Comment 5 Adam Litke 2020-01-22 21:24:05 UTC
We just want to make sure the 2.2 branch of kubevirt functional tests has your fix too so that the tests don't cause this issue in the future.

Comment 6 Maya Rashish 2020-01-26 13:55:01 UTC
Still confused. I believe we should avoid using this code by not passing the flag --deploy-testing-infra
Downstream always has CDI. We don't need the kubevirt tier 1 tests to deploy CDI for us.
The flag doesn't do anything positive, and it does do something negative (delete CDI in the end).

Comment 7 Adam Litke 2020-02-05 13:27:17 UTC
Tareq can we remove the command line flag '--deploy-testing-infra' from the d/s test invocation since all components will have been installed already by HCO?

Comment 10 Maya Rashish 2020-03-09 15:28:53 UTC
Tareq says he would like to keep using this flag.
I don't think there's anything to do in this bug, unless I misunderstood it.

Comment 11 Adam Litke 2020-03-10 20:17:49 UTC
Israel is there anything to do or has this now been resolved?

Comment 12 Israel Pinto 2020-03-11 14:07:01 UTC
We can close this BZ.


Note You need to log in before you can comment on or make changes to this bug.