Bug 1793436 - Review Request: perl-YAML-PP - YAML 1.2 processor
Summary: Review Request: perl-YAML-PP - YAML 1.2 processor
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1793185
TreeView+ depends on / blocked
 
Reported: 2020-01-21 11:18 UTC by Jitka Plesnikova
Modified: 2020-01-22 07:11 UTC (History)
2 users (show)

Fixed In Version: perl-YAML-PP-0.018-1.fc32
Clone Of:
Environment:
Last Closed: 2020-01-22 07:11:26 UTC
Type: ---
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Jitka Plesnikova 2020-01-21 11:18:18 UTC
Spec URL: https://jplesnik.fedorapeople.org/perl-YAML-PP/perl-YAML-PP.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-YAML-PP/perl-YAML-PP-0.018-1.fc32.src.rpm

Description:
YAML::PP is a modern, modular YAML processor.
It aims to support C<YAML 1.2> and C<YAML 1.1>. See L<http://yaml.org/>.

Fedora Account System Username: jplesnik

Comment 1 Petr Pisar 2020-01-21 12:21:04 UTC
URL and Source0 addresses are usable. Ok.
Source0 archive (SHA-256: 9daeed5b5aece184fba92023fa84762a52c046f5c58ea285f99afcb0b73e25e9) is original. Ok.

TODO: Remove a trailing slash from the URL tag value.

Summary verified from lib/YAML/PP.pm. Ok.
Description verified from lib/YAML/PP.pm. Ok.

FIX: Remove a POD markup from the description.

License verified from lib/YAML/PP.pm, Makefile.PL, LICENSE, and README. OK.
No XS code, noarch BuildArch is Ok.

TODO: Build-require 'perl(boolean)' (t/22.dump-bool.t) for optional tests.

All tests pass. Ok.

$ rpmlint perl-YAML-PP.spec ../SRPMS/perl-YAML-PP-0.018-1.fc32.src.rpm ../RPMS/noarch/perl-YAML-PP-0.018-1.fc32.noarch.rpm 
sh: /usr/bin/python2: No such file or directory
perl-YAML-PP.noarch: W: no-manual-page-for-binary yamlpp5-events
perl-YAML-PP.noarch: W: no-manual-page-for-binary yamlpp5-highlight
perl-YAML-PP.noarch: W: no-manual-page-for-binary yamlpp5-load
perl-YAML-PP.noarch: W: no-manual-page-for-binary yamlpp5-load-dump
perl-YAML-PP.noarch: W: no-manual-page-for-binary yamlpp5-parse-emit
2 packages and 1 specfiles checked; 0 errors, 5 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-YAML-PP-0.018-1.fc32.noarch.rpm
-rwxr-xr-x    1 root     root                      538 Jan 21 13:04 /usr/bin/yamlpp5-events
-rwxr-xr-x    1 root     root                      534 Jan 21 13:04 /usr/bin/yamlpp5-highlight
-rwxr-xr-x    1 root     root                      404 Jan 21 13:04 /usr/bin/yamlpp5-load
-rwxr-xr-x    1 root     root                      437 Jan 21 13:04 /usr/bin/yamlpp5-load-dump
-rwxr-xr-x    1 root     root                     1175 Jan 21 13:04 /usr/bin/yamlpp5-parse-emit
drwxr-xr-x    2 root     root                        0 Jan 21 13:04 /usr/share/doc/perl-YAML-PP
-rw-r--r--    1 root     root                     1438 Jul  6  2019 /usr/share/doc/perl-YAML-PP/CONTRIBUTING.md
-rw-r--r--    1 root     root                     5959 Jul  6  2019 /usr/share/doc/perl-YAML-PP/Changes
-rw-r--r--    1 root     root                      343 Jul  6  2019 /usr/share/doc/perl-YAML-PP/README
drwxr-xr-x    2 root     root                        0 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/etc
-rw-r--r--    1 root     root                     1427 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/etc/generate-examples.pl
-rw-r--r--    1 root     root                     1614 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/etc/generate-grammar.pl
-rw-r--r--    1 root     root                    12721 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/etc/grammar.yaml
-rw-r--r--    1 root     root                     1170 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/etc/json-numbers.pl
-rw-r--r--    1 root     root                     9371 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/etc/test-suite-html.pl
-rw-r--r--    1 root     root                     1139 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/etc/yaml-numbers.pl
drwxr-xr-x    2 root     root                        0 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/examples
drwxr-xr-x    2 root     root                        0 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/examples/external-vars-templates
-rw-r--r--    1 root     root                     1604 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/examples/external-vars-templates/ext.pl
-rw-r--r--    1 root     root                      129 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/examples/external-vars-templates/ext.yaml
-rw-r--r--    1 root     root                     1061 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/examples/schema-ixhash.pm
-rw-r--r--    1 root     root                     2903 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/examples/schema-perl.pm
-rw-r--r--    1 root     root                      526 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/examples/schemas.pl
-rw-r--r--    1 root     root                    13333 Jan 21 13:04 /usr/share/doc/perl-YAML-PP/examples/yaml-schema.yaml
drwxr-xr-x    2 root     root                        0 Jan 21 13:04 /usr/share/licenses/perl-YAML-PP
-rw-r--r--    1 root     root                    18349 Jul  6  2019 /usr/share/licenses/perl-YAML-PP/LICENSE
-rw-r--r--    1 root     root                     8115 Jan 21 13:04 /usr/share/man/man3/YAML::PP.3pm.gz
-rw-r--r--    1 root     root                     1480 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Common.3pm.gz
-rw-r--r--    1 root     root                     1694 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Constructor.3pm.gz
-rw-r--r--    1 root     root                     1697 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Emitter.3pm.gz
-rw-r--r--    1 root     root                     2802 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Grammar.3pm.gz
-rw-r--r--    1 root     root                     1308 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Highlight.3pm.gz
-rw-r--r--    1 root     root                     1473 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Perl.3pm.gz
-rw-r--r--    1 root     root                     1106 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Schema.3pm.gz
-rw-r--r--    1 root     root                     1662 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Schema::Binary.3pm.gz
-rw-r--r--    1 root     root                     1349 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Schema::Core.3pm.gz
-rw-r--r--    1 root     root                     1335 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Schema::Failsafe.3pm.gz
-rw-r--r--    1 root     root                     2306 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Schema::Include.3pm.gz
-rw-r--r--    1 root     root                     1440 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Schema::JSON.3pm.gz
-rw-r--r--    1 root     root                     2029 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Schema::Merge.3pm.gz
-rw-r--r--    1 root     root                     3694 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Schema::Perl.3pm.gz
-rw-r--r--    1 root     root                     1652 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Schema::Tie::IxHash.3pm.gz
-rw-r--r--    1 root     root                     1439 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Schema::YAML1_1.3pm.gz
-rw-r--r--    1 root     root                     1192 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Type::MergeKey.3pm.gz
-rw-r--r--    1 root     root                     1400 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Writer.3pm.gz
-rw-r--r--    1 root     root                     1490 Jan 21 13:04 /usr/share/man/man3/YAML::PP::Writer::File.3pm.gz
drwxr-xr-x    2 root     root                        0 Jan 21 13:04 /usr/share/perl5/vendor_perl/YAML
drwxr-xr-x    2 root     root                        0 Jan 21 13:04 /usr/share/perl5/vendor_perl/YAML/PP
-rw-r--r--    1 root     root                    21069 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP.pm
-rw-r--r--    1 root     root                     6243 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Common.pm
-rw-r--r--    1 root     root                     8578 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Constructor.pm
-rw-r--r--    1 root     root                     5759 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Dumper.pm
-rw-r--r--    1 root     root                    19991 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Emitter.pm
-rw-r--r--    1 root     root                     1923 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Exception.pm
-rw-r--r--    1 root     root                    37398 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Grammar.pm
-rw-r--r--    1 root     root                     5439 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Highlight.pm
-rw-r--r--    1 root     root                    28178 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Lexer.pm
-rw-r--r--    1 root     root                     2066 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Loader.pm
-rw-r--r--    1 root     root                    36660 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Parser.pm
-rw-r--r--    1 root     root                     1525 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Perl.pm
-rw-r--r--    1 root     root                     1544 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Reader.pm
-rw-r--r--    1 root     root                     3377 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Render.pm
-rw-r--r--    1 root     root                     4637 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Representer.pm
drwxr-xr-x    2 root     root                        0 Jan 21 13:04 /usr/share/perl5/vendor_perl/YAML/PP/Schema
-rw-r--r--    1 root     root                    10534 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Schema.pm
-rw-r--r--    1 root     root                     2233 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Schema/Binary.pm
-rw-r--r--    1 root     root                     3611 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Schema/Core.pm
-rw-r--r--    1 root     root                      602 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Schema/Failsafe.pm
-rw-r--r--    1 root     root                     6498 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Schema/Include.pm
-rw-r--r--    1 root     root                     4441 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Schema/JSON.pm
-rw-r--r--    1 root     root                     2402 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Schema/Merge.pm
-rw-r--r--    1 root     root                    20929 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Schema/Perl.pm
drwxr-xr-x    2 root     root                        0 Jan 21 13:04 /usr/share/perl5/vendor_perl/YAML/PP/Schema/Tie
-rw-r--r--    1 root     root                     2378 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Schema/Tie/IxHash.pm
-rw-r--r--    1 root     root                     6522 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Schema/YAML1_1.pm
drwxr-xr-x    2 root     root                        0 Jan 21 13:04 /usr/share/perl5/vendor_perl/YAML/PP/Type
-rw-r--r--    1 root     root                      385 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Type/MergeKey.pm
drwxr-xr-x    2 root     root                        0 Jan 21 13:04 /usr/share/perl5/vendor_perl/YAML/PP/Writer
-rw-r--r--    1 root     root                     1256 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Writer.pm
-rw-r--r--    1 root     root                     1839 Jul  6  2019 /usr/share/perl5/vendor_perl/YAML/PP/Writer/File.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-YAML-PP-0.018-1.fc32.noar[test@fedora-32 SPECS]$ rpm -q --requires -p ../RPMS/noarch/perl-YAML-PP-0.018-1.fc32.noarch.rpm | sort -f | uniq -c
      1 /usr/bin/perl
      1 perl(:MODULE_COMPAT_5.30.1)
      1 perl(B)
      1 perl(B::Deparse)
      1 perl(base)
      1 perl(boolean)
      1 perl(Carp)
      1 perl(constant)
      2 perl(Data::Dumper)
      1 perl(Encode)
      1 perl(Exporter)
      1 perl(File::Basename)
      1 perl(HTML::Entities)
      1 perl(JSON::PP)
      1 perl(MIME::Base64)
      1 perl(Module::Load)
      1 perl(overload)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Term::ANSIColor)
      1 perl(Tie::IxHash)
      1 perl(warnings)
      1 perl(YAML::PP)
      1 perl(YAML::PP::Common)
      1 perl(YAML::PP::Constructor)
      1 perl(YAML::PP::Dumper)
      1 perl(YAML::PP::Emitter)
      1 perl(YAML::PP::Exception)
      1 perl(YAML::PP::Grammar)
      1 perl(YAML::PP::Highlight)
      1 perl(YAML::PP::Lexer)
      1 perl(YAML::PP::Loader)
      1 perl(YAML::PP::Parser)
      1 perl(YAML::PP::Reader)
      1 perl(YAML::PP::Render)
      1 perl(YAML::PP::Representer)
      1 perl(YAML::PP::Schema)
      1 perl(YAML::PP::Schema::JSON)
      1 perl(YAML::PP::Schema::Perl)
      1 perl(YAML::PP::Type::MergeKey)
      1 perl(YAML::PP::Writer)
      1 perl(YAML::PP::Writer::File)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
TODO: Remove the explicit 'perl(Data::Dumper)' requirement. It's autodetected.
TODO: Constrain 'perl(Scalar::Util)' dependency with '>= 1.07' (META.json:38).

$ rpm -q --provides -p ../RPMS/noarch/perl-YAML-PP-0.018-1.fc32.noarch.rpm | sort -f | uniq -c
      1 perl(YAML::PP) = 0.018
      1 perl(YAML::PP::Common) = 0.018
      1 perl(YAML::PP::Constructor) = 0.018
      1 perl(YAML::PP::Dumper) = 0.018
      1 perl(YAML::PP::Emitter) = 0.018
      1 perl(YAML::PP::Exception) = 0.018
      1 perl(YAML::PP::Grammar) = 0.018
      1 perl(YAML::PP::Highlight) = 0.018
      1 perl(YAML::PP::Lexer) = 0.018
      1 perl(YAML::PP::Loader) = 0.018
      1 perl(YAML::PP::Parser) = 0.018
      1 perl(YAML::PP::Perl) = 0.018
      1 perl(YAML::PP::Reader) = 0.018
      1 perl(YAML::PP::Reader::File)
      1 perl(YAML::PP::Render) = 0.018
      1 perl(YAML::PP::Representer) = 0.018
      1 perl(YAML::PP::Schema) = 0.018
      1 perl(YAML::PP::Schema::Binary) = 0.018
      1 perl(YAML::PP::Schema::Core) = 0.018
      1 perl(YAML::PP::Schema::Failsafe) = 0.018
      1 perl(YAML::PP::Schema::Include) = 0.018
      1 perl(YAML::PP::Schema::JSON) = 0.018
      1 perl(YAML::PP::Schema::Merge) = 0.018
      1 perl(YAML::PP::Schema::Perl) = 0.018
      1 perl(YAML::PP::Schema::Tie::IxHash) = 0.018
      1 perl(YAML::PP::Schema::YAML1_1) = 0.018
      1 perl(YAML::PP::Type::MergeKey) = 0.018
      1 perl(YAML::PP::Writer) = 0.018
      1 perl(YAML::PP::Writer::File) = 0.018
      1 perl-YAML-PP = 0.018-1.fc32
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-YAML-PP-0.018-1.fc32.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in F32 (https://koji.fedoraproject.org/koji/taskinfo?taskID=40815730). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.
Please correct the 'FIX' item and consider fixing the 'TODO' items before building this package.
Resolution: Package APPROVED.

Comment 2 Gwyn Ciesla 2020-01-21 16:47:31 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-YAML-PP

Comment 3 Jitka Plesnikova 2020-01-22 07:11:26 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.