Bug 1793508 - python-xmp-toolkit fails to build with Python 3.9: Exempi function failure ("unknown error")
Summary: python-xmp-toolkit fails to build with Python 3.9: Exempi function failure ("...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: python-xmp-toolkit
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Elliott Sales de Andrade
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1841802 (view as bug list)
Depends On:
Blocks: PYTHON39 F33FTBFS 1841653 1841764
TreeView+ depends on / blocked
 
Reported: 2020-01-21 13:50 UTC by Miro Hrončok
Modified: 2020-07-01 01:50 UTC (History)
7 users (show)

Fixed In Version: python-xmp-toolkit-2.0.1-8.fc32
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-06-23 15:08:51 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
freedesktop.org Gitlab libopenraw/exempi/issues/20 0 None None None 2020-03-16 20:07:26 UTC

Description Miro Hrončok 2020-01-21 13:50:27 UTC
python-xmp-toolkit fails to build with Python 3.9.0a2.

======================================================================
ERROR: test_can_put_xmp (test.test_files.XMPFilesTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/test/test_files.py", line 222, in test_can_put_xmp
    xmpfile.open_file( filename, **kwargs )
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/libxmp/files.py", line 116, in open_file
    _cexempi.files_open( self.xmpfileptr, file_path, open_flags )
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/libxmp/exempi.py", line 459, in files_open
    EXEMPI.xmp_files_open(xfptr, filename.encode('utf-8'), options)
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/libxmp/exempi.py", line 1702, in check_error
    raise XMPError(msg)
libxmp.XMPError: Exempi function failure ("unknown error").
======================================================================
ERROR: test_exempi_bad_combinations (test.test_files.XMPFilesTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/test/test_files.py", line 252, in test_exempi_bad_combinations
    xmpfile.open_file( filename, **kwargs )
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/libxmp/files.py", line 116, in open_file
    _cexempi.files_open( self.xmpfileptr, file_path, open_flags )
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/libxmp/exempi.py", line 459, in files_open
    EXEMPI.xmp_files_open(xfptr, filename.encode('utf-8'), options)
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/libxmp/exempi.py", line 1702, in check_error
    raise XMPError(msg)
libxmp.XMPError: Exempi function failure ("unknown error").
======================================================================
ERROR: test_get_xmp (test.test_files.XMPFilesTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/test/test_files.py", line 203, in test_get_xmp
    xmpfile = XMPFiles( file_path=filename, **kwargs )
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/libxmp/files.py", line 79, in __init__
    self.open_file( file_path, **kwargs )
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/libxmp/files.py", line 116, in open_file
    _cexempi.files_open( self.xmpfileptr, file_path, open_flags )
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/libxmp/exempi.py", line 459, in files_open
    EXEMPI.xmp_files_open(xfptr, filename.encode('utf-8'), options)
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/libxmp/exempi.py", line 1702, in check_error
    raise XMPError(msg)
libxmp.XMPError: Exempi function failure ("unknown error").
======================================================================
ERROR: test_open_file_with_options (test.test_files.XMPFilesTestCase)
Try all open options
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/test/test_files.py", line 162, in test_open_file_with_options
    xmpfile.open_file(filename, **kwargs)
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/libxmp/files.py", line 116, in open_file
    _cexempi.files_open( self.xmpfileptr, file_path, open_flags )
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/libxmp/exempi.py", line 459, in files_open
    EXEMPI.xmp_files_open(xfptr, filename.encode('utf-8'), options)
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/libxmp/exempi.py", line 1702, in check_error
    raise XMPError(msg)
libxmp.XMPError: Exempi function failure ("unknown error").
======================================================================
FAIL: test_formats (test.test_exempi.TestExempi)
Verify that check_file_format function works as expected.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/python-xmp-toolkit-2.0.1/test/test_exempi.py", line 440, in test_formats
    self.assertEqual(actual_format, expected_format)
AssertionError: 538976288 != 1195984416
----------------------------------------------------------------------

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01170144-python-xmp-toolkit/

For all our attempts to build python-xmp-toolkit with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-xmp-toolkit/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2020-02-11 17:31:01 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 2 Miro Hrončok 2020-03-16 13:28:49 UTC
Elliott, could you please have look and report this upstream if needed? Thanks.

Comment 3 Elliott Sales de Andrade 2020-03-16 20:07:26 UTC
This is a bug in the underlying library, exempi.

Comment 4 Elliott Sales de Andrade 2020-05-20 09:25:13 UTC
Also CC exempi maintainer, as maybe they can patch it, or perhaps poke upstream better.

Comment 5 Miro Hrončok 2020-05-25 13:02:08 UTC
This comment is mass posted to all bugs blocking the Python 3.9 tracker, sorry if it is not 100 % relevant. When in doubt, please ask.


The Python 3.9 rebuild is in progress in a Koji side tag.

If you fix this bug, please don't rebuild the package in regular rawhide, but do it in the side tag with:

    $ fedpkg build --target=f33-python

The rebuild is progressing slowly and it is possible this package won't have all the required build dependencies yet. If that's the case, please just leave the fix committed and pushed and we will eventually rebuild it for you.

You are not asked to go and try rebuild all the missing dependencies yourself. If you know there is a bootstrap loop in the dependencies, let me know and we can untangle it together.

If you want to test your fix or reproduce the failure, you can still use the Copr repo mentioned in the initial comment of this bug: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Comment 6 Miro Hrončok 2020-05-29 07:11:58 UTC
Python 3.9 update: The f33-python side tag is currently being merged.

New builds in f33-python are no longer possible, but python3 is not yet updated to Python 3.9 in rawhide. You can check when Python is Python 3.9 with:

    $ koji wait-repo f33-build --build python3.9-3.9.0~b1-3.fc3

And build the packages normally after that.

Comment 7 Miro Hrončok 2020-05-29 16:23:55 UTC
*** Bug 1841802 has been marked as a duplicate of this bug. ***

Comment 9 Elliott Sales de Andrade 2020-05-29 22:36:48 UTC
No, it is not the second reminder. The FTI bug was just opened and marked duplicate today. Please fix the script to count from the time the bug blocks the FTI bug.

Comment 10 Miro Hrončok 2020-05-30 07:05:42 UTC
1) I've already notified Igor the minut this happened in many bugs.

2) Igor is not cced here, so he cannot see your response to this.

Comment 11 Nils Philippsen 2020-06-22 16:16:35 UTC
I've written this reply in the upstream Exempi ticket:


> Apparently XMP is only supported for GIF89a. Here's the relevant snippet from the XMP spec:
> 
> > 1.1.2 GIF (Graphic Interchange Format)
> >...
> >NOTE The "Application Extension" mechanism used for XMP was added in the 89a revision of GIF; the GIF 87a standard does not support it. XMP should not be placed into GIF 87a files.
> 
> I guess that the test image was created with an old version of exempi which didn't care about the version of the format. I've submitted a pull request converting the file to GIF89a, which fixes tests here.

The pull request is here: https://github.com/python-xmp-toolkit/python-xmp-toolkit/pull/84

Comment 12 Fedora Update System 2020-06-22 19:54:58 UTC
FEDORA-2020-befd8e4f27 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-befd8e4f27

Comment 13 Elliott Sales de Andrade 2020-06-22 19:58:33 UTC
Although the exempi developer may end up fixing things differently, I've backported the updated test image from the above PR from Nils.

Comment 14 Fedora Update System 2020-06-23 01:05:25 UTC
FEDORA-2020-befd8e4f27 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-befd8e4f27`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-befd8e4f27

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Igor Raits 2020-06-23 07:12:42 UTC
Hello,

Please note that this comment was generated automatically. If you feel that this output has mistakes, please contact me via email (ignatenkobrain).

All subpackages of a package agaisnt which this bug was filled are now installable or removed from Fedora 33.

Thanks for taking care of it!

Comment 16 Fedora Update System 2020-07-01 01:50:31 UTC
FEDORA-2020-befd8e4f27 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.