Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1794128

Summary:	CAM should not allow users to `move` Azure volumes
Product:	OpenShift Container Platform	Reporter:	Dylan Murray <dymurray>
Component:	Migration Tooling	Assignee:	Scott Seago <sseago>
Status:	CLOSED ERRATA	QA Contact:	Xin jiang <xjiang>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.2.0	CC:	ernelson, sregidor
Target Milestone:	---
Target Release:	4.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-06 20:21:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dylan Murray 2020-01-22 18:03:38 UTC

Description of problem:
Currently CAM allows users to select `move` for PVs backed by Azure Disks. This should not be allowed because Azure requires some additional values to be populated such as resource group and subscriptions which will not be the same on the migrated cluster.

Version-Release number of selected component (if applicable):
4.2.0

How reproducible:
100%

Steps to Reproduce:
1. Create a migration plan that includes Azure PVs
2. Select `move` for the PV
3. Migration may succeed or fail but the PV will not be usable

Actual results:
Migration may succeed or fail but the PV will not be usable

Expected results:
User is unable to select `move` for Azure PVs

Additional info:

Comment 1 Scott Seago 2020-01-22 18:07:09 UTC

Fix is here: https://github.com/fusor/mig-controller/pull/407

Comment 3 Sergio 2020-01-23 15:51:25 UTC

Verified in CAM 1.1 stage

Controller:
    imageID: image-registry.openshift-image-registry.svc:5000/rhcam-1-1/openshift-migration-rhel7-operator@sha256:ef64569bd0f2551ea24c63abacc48dfb049bf05c37cdb427789abad6da42c09f
UI:
    imageID: image-registry.openshift-image-registry.svc:5000/rhcam-1-1/openshift-migration-ui-rhel8@sha256:ecd81e11af0a17bfdd4e6afce1bf60f422115ed3545ad2b0d055f0fded87e422


Move is not an option for Azure Disk volumes (managed-premium storage class)
This is the resulting plan, showing only one supported action: "copy"

apiVersion: migration.openshift.io/v1alpha1
kind: MigPlan
metadata:
  annotations:
    touch: 69b5d6e3-3794-4f46-939c-62c3b3a06f77
  creationTimestamp: "2020-01-23T15:47:09Z"
  generation: 2
  name: testmove
  namespace: openshift-migration
  resourceVersion: "632987"
  selfLink: /apis/migration.openshift.io/v1alpha1/namespaces/openshift-migration/migplans/testmove
  uid: 3a0cb77b-18f1-41f6-825f-94e4abba0673
spec:
  destMigClusterRef:
    name: host
    namespace: openshift-migration
  migStorageRef:
    name: azure
    namespace: openshift-migration
  namespaces:
  - verifyazure
  persistentVolumes:
  - capacity: 1Gi
    name: pvc-f9b315ca-1025-4029-830a-c9e7d43eb35f
    pvc:
      accessModes:
      - ReadWriteOnce
      name: nginx-html
      namespace: verifyazure
    selection:
      action: copy
      copyMethod: filesystem
      storageClass: managed-premium
    storageClass: managed-premium
    supported:
      actions:
      - copy
      copyMethods:
      - filesystem
      - snapshot
  - capacity: 1Gi
    name: pvc-fc899cb1-b716-451a-8254-82073b231f80
    pvc:
      accessModes:
      - ReadWriteOnce
      name: nginx-logs
      namespace: verifyazure
    selection:
      action: copy
      copyMethod: filesystem
      storageClass: managed-premium
    storageClass: managed-premium
    supported:
      actions:
      - copy
      copyMethods:
      - filesystem
      - snapshot
  srcMigClusterRef:
    name: azure43source
    namespace: openshift-migration
status:
  conditions:
  - category: Required
    lastTransitionTime: "2020-01-23T15:47:10Z"
    message: The `persistentVolumes` list has been updated with discovered PVs.
    reason: Done
    status: "True"
    type: PvsDiscovered
  - category: Required
    lastTransitionTime: "2020-01-23T15:47:11Z"
    message: The storage resources have been created.
    status: "True"
    type: StorageEnsured
  - category: Required
    lastTransitionTime: "2020-01-23T15:47:13Z"
    message: The migration registry resources have been created.
    status: "True"
    type: RegistriesEnsured
  - category: Required
    lastTransitionTime: "2020-01-23T15:47:13Z"
    message: The migration plan is ready.
    status: "True"
    type: Ready

Comment 5 errata-xmlrpc 2020-02-06 20:21:05 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:0440