Bug 1794334 - veusz fails to build with Python 3.9: invalid open() mode U
Summary: veusz fails to build with Python 3.9: invalid open() mode U
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: veusz
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jeremy Sanders
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON39
TreeView+ depends on / blocked
 
Reported: 2020-01-23 10:28 UTC by Miro Hrončok
Modified: 2020-03-08 23:07 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-08 23:07:22 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Miro Hrončok 2020-01-23 10:28:12 UTC
veusz fails to build with Python 3.9.0a2.

+ /usr/bin/python3 tests/runselftest.py
Testing output
2d_irregular.vsz
Traceback (most recent call last):
  File "/builddir/build/BUILD/veusz-3.1/tests/runselftest.py", line 306, in <module>
    runTests(test_saves=options.test_saves,
  File "/builddir/build/BUILD/veusz-3.1/tests/runselftest.py", line 235, in runTests
    renderVszTest(infile, outfile, test_saves=test_saves,
  File "/builddir/build/BUILD/veusz-3.1/tests/runselftest.py", line 152, in renderVszTest
    doc.load(invsz, mode=mode)
  File "/builddir/build/BUILDROOT/veusz-3.1-1.fc32.x86_64/usr/lib64/python3.9/site-packages/veusz/document/doc.py", line 513, in load
    loader.loadDocument(
  File "/builddir/build/BUILDROOT/veusz-3.1-1.fc32.x86_64/usr/lib64/python3.9/site-packages/veusz/document/loader.py", line 273, in loadDocument
    with io.open(filename, 'rU', encoding='utf-8') as f:
ValueError: invalid mode: 'rU'

See https://docs.python.org/3.9/whatsnew/3.9.html#changes-in-the-python-api

"open(), io.open(), codecs.open() and fileinput.FileInput no longer accept 'U' (“universal newline”) in the file mode. This flag was deprecated since Python 3.3. In Python 3, the “universal newline” is used by default when a file is open in text mode. The newline parameter of open() controls how universal newlines works."



For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01173306-veusz/

For all our attempts to build veusz with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/veusz/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karthikeyan Singaravelan 2020-01-24 14:05:04 UTC
Reported upstream : https://github.com/veusz/veusz/issues/371

Comment 2 Ben Cotton 2020-02-11 17:26:21 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 3 Jeremy Sanders 2020-03-08 20:10:25 UTC
Upstream bug fix was merged and appeared in Veusz 3.2. I've built this in Rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2020-82b9f0aceb

I've not tried building this under Python 3.9 alpha, however.

Comment 4 Miro Hrončok 2020-03-08 23:07:22 UTC
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/veusz/ says succeeded. Thank You.


Note You need to log in before you can comment on or make changes to this bug.