Spec URL: https://github.com/TomasTomecek/nyancat/blob/eebbd651fcde1a2b500c2b02750c644aed1f0413/nyancat.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/packit/TomasTomecek-nyancat-1/srpm-builds/01178509/nyancat-1.5.2.7.geebbd65-1.fc30.src.rpm Description: Nyan Cat is the name of a YouTube video uploaded in April 2011, which became an internet meme. The video merged a Japanese pop song with an animated cartoon cat with a Pop-Tart for a torso, flying through space, and leaving a rainbow trail behind it. Fedora Account System Username: ttomecek
*** Bug 824083 has been marked as a duplicate of this bug. ***
Spec URL: https://raw.githubusercontent.com/TomasTomecek/nyancat/eebbd651fcde1a2b500c2b02750c644aed1f0413/nyancat.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/packit/TomasTomecek-nyancat-1/srpm-builds/01178509/nyancat-1.5.2.7.geebbd65-1.fc30.src.rpm forgot to use the raw url for spec
Spec URL: https://raw.githubusercontent.com/TomasTomecek/nyancat/5983b2eaae752bbace63ddadc0691af59c3b291a/nyancat.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/packit/TomasTomecek-nyancat-2/srpm-builds/01192113/nyancat-1.5.2-2.g5983b2ea.fc30.src.rpm third time's the charm
># upstream doesn't ship manpage yet: The man page is in the repo, it's just not included in the install script - which you don't use either way, so I see no reason why not to install the man page manually. ># %%{_mandir}/man1/nyancat.1.gz Do not assume that man pages will be gzipped; use a wildcard that can match any compression method (including no compression). https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages >%doc If it's gonna be empty, just remove it. >%license This should not be empty. Either ask upstream to provide a LICENCE file, or you can use awk to extract the copyright header (and thus, the licence) from src/nyancat.c: $ awk '1;/\*\//{exit}' < src/nyancat.c > LICENSE
(In reply to Artur Iwicki from comment #4) > ># upstream doesn't ship manpage yet: > The man page is in the repo, it's just not included in the install script - > which you don't use either way, so I see no reason why not to install the > man page manually. But the manpage is not included in the tarball: https://github.com/klange/nyancat/pull/54 > >%license > This should not be empty. Either ask upstream to provide a LICENCE file, or > you can use awk to extract the copyright header (and thus, the licence) from > src/nyancat.c: > $ awk '1;/\*\//{exit}' < src/nyancat.c > LICENSE yeah, the license file is not part in the upstream repo thank you for the comments
Spec URL: https://raw.githubusercontent.com/TomasTomecek/nyancat/704d271ba1ac0a4736e44fb206a6475cc4e333e4/nyancat.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/packit/TomasTomecek-nyancat-2/srpm-builds/01206320/nyancat-1.5.2-3.g704d271b.fc30.src.rpm
>But the manpage is not included in the tarball: Uhh, are you sure? When I fetch the Source0 URL specified in the spec I get a tarball that has nyancat-1.5.2/nyancat.1 happily sitting there.
Hm, you're right. The github archive contains everything while the archive generated with `make dist` contains only a handful of files - that's what I was using. Thanks for helping me out!
Spec URL: https://raw.githubusercontent.com/TomasTomecek/nyancat/8a323f84067a3cbdda116c366b724e70b4d592fe/nyancat.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/packit/TomasTomecek-nyancat-2/srpm-builds/01207709/nyancat-1.5.2-4.g8a323f84.fc30.src.rpm
>%build >make %{?_smp_mflags} nyancat You should call "%set_build_flags" before invoking make. >install -m 0544 nyancat.1 %{buildroot}/%{_mandir}/man1/ 0544 is read+execute,read,read - I think you wanted read+write,read,read = 0644 here. >awk '1;/\*\//{exit}' < src/nyancat.c > LICENSE Personally, I'd move this to %prep.
Good points, thank you!
Bump, just missing %set_build_flags from https://raw.githubusercontent.com/TomasTomecek/nyancat/c67dc905e26babcf2254b4a226be5ae02f238bb9/nyancat.spec and then should be good
I wish %set_build_flags was documented somewhere. Couldn't find any docs for it. Spec URL: https://raw.githubusercontent.com/TomasTomecek/nyancat/fe37d0684a453499dddeb1a397963913a0044124/nyancat.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/packit/TomasTomecek-nyancat-2/fedora-rawhide-x86_64/01315881-nyancat/nyancat-1.5.2-5.gfe37d068.fc33.src.rpm
Taking a brief peek at "rpmbuild --showrc", %{set_build_flags} is called automatically when using %{configure}, %{cmake} or %{meson} - I guess that because of this, most Fedora packages have no need to call it explicitly in %build. Still, yeah, it would be a good idea to add that somewhere to the packaging docs - I think the C/C++ guidelines would be the most appropriate place.
Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/nyancat See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 11 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/nyancat/review- nyancat/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: nyancat-1.5.2-4.fc33.x86_64.rpm nyancat-debuginfo-1.5.2-4.fc33.x86_64.rpm nyancat-debugsource-1.5.2-4.fc33.x86_64.rpm nyancat-1.5.2-4.fc33.src.rpm nyancat.x86_64: W: name-repeated-in-summary C Nyancat nyancat.x86_64: W: spelling-error %description -l en_US Nyan -> Nan, Cyan, Ryan nyancat.src: W: name-repeated-in-summary C Nyancat nyancat.src: W: spelling-error %description -l en_US Nyan -> Nan, Cyan, Ryan 4 packages and 0 specfiles checked; 0 errors, 4 warnings.
Robert, thank you very much for completing the review.