Bug 1795232 - Apply Patternfly 4 styles and layouts to error and non-webadmin pages
Summary: Apply Patternfly 4 styles and layouts to error and non-webadmin pages
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.Core
Version: 4.4.0
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.4.0
: ---
Assignee: Scott Dickerson
QA Contact: Ivana Saranova
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-01-27 13:54 UTC by Scott Dickerson
Modified: 2020-05-20 20:01 UTC (History)
2 users (show)

Fixed In Version: ovirt-engine 4.4.0-26 b5b5c99ca2f
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-05-20 20:01:27 UTC
oVirt Team: UX
Embargoed:
pm-rhel: ovirt-4.4+
sdickers: devel_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 106579 0 master MERGED engine: Update non-webadmin pages to PF4 2020-03-20 16:48:32 UTC

Description Scott Dickerson 2020-01-27 13:54:27 UTC
Description of problem:
After the initial PF4 changes, the 404 error page on oVirt 4.4 do not look correct.  All of the non-application JSP pages need to be evaluated.

Looking at the ovirt-engine repo, a quick find on JSPs:

 > find . -name '.jsp' ! -path '*target'
 ./frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp
 ./backend/manager/modules/enginesso/src/main/webapp/WEB-INF/credentialsChange.jsp
 ./backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp
 ./backend/manager/modules/enginesso/src/main/webapp/WEB-INF/400.jsp
 ./backend/manager/modules/welcome/src/main/webapp/WEB-INF/405.jsp
 ./backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp
 ./backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp
 ./backend/manager/modules/services/src/main/webapp/novnc-main.jsp

Files that do not need PF4 updates:
 - GwtHostPage.jsp (part of webadmin)

These have initial PF4 changes, but can also adopt additional PF4 layouts instead of PF3 layouts:
 - login.jsp
 - ovirt-engine.jsp

Files that need PF4 work:
 - credentialsChange.jsp
 - 400.jsp
 - 405.jsp
 - 404.jsp


Version-Release number of selected component (if applicable):
4.4

Comment 1 Scott Dickerson 2020-01-27 14:55:06 UTC
Follows up https://bugzilla.redhat.com/1549486

Comment 2 Scott Dickerson 2020-01-28 03:50:58 UTC
Screen shots from patch 106579:
  https://ibb.co/VDxbx48 - Welcome Page
  https://ibb.co/W3Gt7d4 - Login Page
  https://ibb.co/0ZPCNMX - Change Password
  https://ibb.co/GFLqsxF - 404 (same pattern for 400, 405)

Comment 3 Laura Wright 2020-02-03 20:46:47 UTC
The layouts for all of them look good to me!

Comment 4 Ivana Saranova 2020-03-21 00:04:59 UTC
404 error page is missing. Only plain white page with Not Found and title Error.
It feels a bit weird to have oVirt description under the oVirt logo on login page but not on change password page which is essentially the same format as login page.

Tested in:
ovirt-engine-4.4.0-0.0.master.20200317103500.git3e2b0274306.el8.noarch
ovirt-engine-4.4.0-0.26.master.el8ev.noarch

firefox-74.0-3.fc31.x86_64
firefox-68.6.0
google-chrome-stable-80.0.3987.149-1.x86_64

Comment 5 Scott Dickerson 2020-03-21 21:30:32 UTC
(In reply to Ivana Saranova from comment #4)
> 404 error page is missing. Only plain white page with Not Found and title
> Error.

What url did you test?  Error pages will only show up if the URL path starts at "/ovirt-engine".

For example, "http://fqdn/hello" will not be covered by the updated 404 error page.  However, "http://fqdn/ovirt-engine/hello" will.

> It feels a bit weird to have oVirt description under the oVirt logo on login
> page but not on change password page which is essentially the same format as
> login page.

All of the pages that were updated were verified by UXD, so that shouldn't be a problem.  There are a few minor changes that need to be done as a followup, so I'll add this one to the list.

> 
> Tested in:
> ovirt-engine-4.4.0-0.0.master.20200317103500.git3e2b0274306.el8.noarch
> ovirt-engine-4.4.0-0.26.master.el8ev.noarch
> 
> firefox-74.0-3.fc31.x86_64
> firefox-68.6.0
> google-chrome-stable-80.0.3987.149-1.x86_64

Comment 6 Ivana Saranova 2020-03-23 14:11:44 UTC
I'm sorry, seems like an error on my part. Rebooting my machine and deleting cache in my browsers solved the issue somehow.
Moving to verified, since you clarified that the missing description is by design.

Verified in:
ovirt-engine-4.4.0-0.0.master.20200317103500.git3e2b0274306.el8.noarch
ovirt-engine-4.4.0-0.26.master.el8ev.noarch

firefox-74.0-3.fc31.x86_64
firefox-68.6.0
google-chrome-stable-80.0.3987.149-1.x86_64

Comment 7 Sandro Bonazzola 2020-05-20 20:01:27 UTC
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.