Bug 1795232
| Summary: | Apply Patternfly 4 styles and layouts to error and non-webadmin pages | ||
|---|---|---|---|
| Product: | [oVirt] ovirt-engine | Reporter: | Scott Dickerson <sdickers> |
| Component: | Frontend.Core | Assignee: | Scott Dickerson <sdickers> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Ivana Saranova <isaranov> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 4.4.0 | CC: | bugs, lwright |
| Target Milestone: | ovirt-4.4.0 | Flags: | pm-rhel:
ovirt-4.4+
sdickers: devel_ack+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | ovirt-engine 4.4.0-26 b5b5c99ca2f | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-05-20 20:01:27 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | UX | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Scott Dickerson
2020-01-27 13:54:27 UTC
Follows up https://bugzilla.redhat.com/1549486 Screen shots from patch 106579: https://ibb.co/VDxbx48 - Welcome Page https://ibb.co/W3Gt7d4 - Login Page https://ibb.co/0ZPCNMX - Change Password https://ibb.co/GFLqsxF - 404 (same pattern for 400, 405) The layouts for all of them look good to me! 404 error page is missing. Only plain white page with Not Found and title Error. It feels a bit weird to have oVirt description under the oVirt logo on login page but not on change password page which is essentially the same format as login page. Tested in: ovirt-engine-4.4.0-0.0.master.20200317103500.git3e2b0274306.el8.noarch ovirt-engine-4.4.0-0.26.master.el8ev.noarch firefox-74.0-3.fc31.x86_64 firefox-68.6.0 google-chrome-stable-80.0.3987.149-1.x86_64 (In reply to Ivana Saranova from comment #4) > 404 error page is missing. Only plain white page with Not Found and title > Error. What url did you test? Error pages will only show up if the URL path starts at "/ovirt-engine". For example, "http://fqdn/hello" will not be covered by the updated 404 error page. However, "http://fqdn/ovirt-engine/hello" will. > It feels a bit weird to have oVirt description under the oVirt logo on login > page but not on change password page which is essentially the same format as > login page. All of the pages that were updated were verified by UXD, so that shouldn't be a problem. There are a few minor changes that need to be done as a followup, so I'll add this one to the list. > > Tested in: > ovirt-engine-4.4.0-0.0.master.20200317103500.git3e2b0274306.el8.noarch > ovirt-engine-4.4.0-0.26.master.el8ev.noarch > > firefox-74.0-3.fc31.x86_64 > firefox-68.6.0 > google-chrome-stable-80.0.3987.149-1.x86_64 I'm sorry, seems like an error on my part. Rebooting my machine and deleting cache in my browsers solved the issue somehow. Moving to verified, since you clarified that the missing description is by design. Verified in: ovirt-engine-4.4.0-0.0.master.20200317103500.git3e2b0274306.el8.noarch ovirt-engine-4.4.0-0.26.master.el8ev.noarch firefox-74.0-3.fc31.x86_64 firefox-68.6.0 google-chrome-stable-80.0.3987.149-1.x86_64 This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020. Since the problem described in this bug report should be resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |