Spec URL: https://mblaha.fedorapeople.org/sdbus-cpp.spec SRPM URL: https://mblaha.fedorapeople.org/sdbus-cpp-0.7.8-1.fc30.src.rpm Description: High-level C++ D-Bus library for Linux designed to provide easy-to-use yet powerful API in modern C++ Fedora Account System Username: mblaha
I have the following comments: - please do not glob the SONAME from the shared library in %files, this is as far as I know either not allowed or strongly discouraged - upstream has a test suite that is neither built nor executed in %check, why? - upstream provides a way to build a full API documentation, I would suggest to build it and put it into a devel-doc subpackage - (minor) there's no need for the -p1 flag in %autosetup, you're not patching anything - (minor) consider changing `BuildRequires: cmake` to `BuildRequires: cmake > 3.6` - (minor) the spec from the source rpm and the link do not match, but the differences are just in the %changelog Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License (v2.1 or later)". 40 files have unknown license. Detailed output of licensecheck in /home/dan/fedora-scm/1795249-sdbus- cpp/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 153600 bytes in 10 files. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in sdbus- cpp-devel , sdbus-cpp-xml2cpp [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.
Thanks for the review! Running the tests is tricky. The cmake directly downloads google tests libraries using git from github.com which does not work when the builder does not have access to the network (see the scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=41238632). I tried to replace it using packaged version of the library (BuildRequires: pkgconfig(gtest)), but this did not work neither due to using of some features not available in released version yet. (e.g. GTEST_SKIP). All other issues should be now fixed.
(In reply to Marek Blaha from comment #2) > Thanks for the review! > > Running the tests is tricky. The cmake directly downloads google tests > libraries using git from github.com which does not work when the builder > does not have access to the network (see the scratch build > https://koji.fedoraproject.org/koji/taskinfo?taskID=41238632). > > I tried to replace it using packaged version of the library (BuildRequires: > pkgconfig(gtest)), but this did not work neither due to using of some > features not available in released version yet. (e.g. GTEST_SKIP). Fair enough. You might want to try to persuade upstream to support a stable gtest not to download it from the internet at configuration time, but I'd leave this up to you. > > All other issues should be now fixed. Thank you, package approved!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/sdbus-cpp