Spec URL: https://rdieter.fedorapeople.org/rpms/phonon-qt4/phonon-qt4.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/phonon-qt4/phonon-qt4-4.10.3-10.fc31.src.rpm Description: Multimedia framework api for Qt4 Fedora Account System Username: rdieter A compat package, of sorts, latest phonon packages support Qt5+ only, so this is needed for legacy Qt4 applications
- BR gcc-c++ explicitly - Add cmake/COPYING-CMAKE-SCRIPTS to the %license - Add "and BSD" to the License field for said script and avv a comment explaining the License breakdown - Add a comment for each patch explaining why they are needed - Consider verifying the archive with gpgverify in %prep [!]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. - The Header and changelog entry are not consistent: Version: 4.10.3 Release: 10%{?dist} %changelog * Wed Jul 31 2019 Rex Dieter <rdieter> - 4.10.3-1 - 4.10.3 - phonon.kde.org does not resolve, is there no other official URL? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING-CMAKE-SCRIPTS is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* BSD 3-clause "New" or "Revised" License", "BSD 3-clause "New" or "Revised" License", "LGPL (v2.1 or v3)", "GPL (v2.1) LGPL (v2.1 or v3)", "GPL (v2.1) GNU Lesser General Public License (v2.1)", "GNU General Public License (v2)", "GNU Lesser General Public License (v2)", "LGPL (v2 or v3)". 222 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/phonon-qt4/review-phonon- qt4/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/kde4/plugins/phonon_backend(phonon), /usr/share/kde4/services/phononbackends(phonon), /usr/share/phonon(phonon), /usr/include/KDE(phonon-devel), /usr/include/KDE/Phonon(phonon-devel), /usr/include/KDE/Phonon/Experimental(phonon-devel), /usr/include/phonon(phonon-devel), /usr/include/phonon/Phonon(phonon- devel), /usr/include/phonon/experimental(phonon-devel), /usr/lib64/cmake(qjson-devel, libsavitar-devel, pulseaudio-libs-devel, uid_wrapper, telepathy-qt5-devel, telepathy-qt4-devel, leatherman- devel, PackageKit-Qt5-devel, libssh-devel, qt5-qtbase, marble-astro- devel, kqtquickcharts, qjson-qt5-devel, openobex-devel, libdynaplugz- devel, marble-widget-qt5-devel, libarcus-lulzbot-devel, phonon- qt5-devel, cmake-filesystem, qaccessibilityclient-devel, libarcus- devel, phonon-devel), /usr/lib64/cmake/phonon(phonon-devel), /usr/share/phonon/buildsystem(phonon-devel) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [!]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: phonon-qt4-4.10.3-10.fc32.x86_64.rpm phonon-qt4-devel-4.10.3-10.fc32.x86_64.rpm phonon-qt4-debuginfo-4.10.3-10.fc32.x86_64.rpm phonon-qt4-debugsource-4.10.3-10.fc32.x86_64.rpm phonon-qt4-4.10.3-10.fc32.src.rpm phonon-qt4.x86_64: W: spelling-error Summary(en_US) api -> API, pi, ape phonon-qt4.x86_64: W: spelling-error %description -l en_US api -> API, pi, ape phonon-qt4.x86_64: W: incoherent-version-in-changelog 4.10.3-1 ['4.10.3-10.fc32', '4.10.3-10'] phonon-qt4.x86_64: W: invalid-url URL: http://phonon.kde.org/ <urlopen error [Errno -2] Name or service not known> phonon-qt4.x86_64: W: no-documentation phonon-qt4-devel.x86_64: W: invalid-url URL: http://phonon.kde.org/ <urlopen error [Errno -2] Name or service not known> phonon-qt4-devel.x86_64: W: no-documentation phonon-qt4-debuginfo.x86_64: W: invalid-url URL: http://phonon.kde.org/ <urlopen error [Errno -2] Name or service not known> phonon-qt4-debugsource.x86_64: W: invalid-url URL: http://phonon.kde.org/ <urlopen error [Errno -2] Name or service not known> phonon-qt4.src: W: spelling-error Summary(en_US) api -> API, pi, ape phonon-qt4.src: W: spelling-error %description -l en_US api -> API, pi, ape phonon-qt4.src: W: invalid-url URL: http://phonon.kde.org/ <urlopen error [Errno -2] Name or service not known> 5 packages and 0 specfiles checked; 0 errors, 12 warnings.
Seems phonon.kde.org used to redirect to https://community.kde.org/Phonon
Spec URL: https://rdieter.fedorapeople.org/rpms/phonon-qt4/phonon-qt4.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/phonon-qt4/phonon-qt4-4.10.3-11.fc31.src.rpm %changelog * Wed Jan 29 2020 Rex Dieter <rdieter> - 4.10.3-11 - qt4-only compat package - fix URL - bump Release to ensure upgrade path from non-compat pkg - add explicit BR: gcc-c++ - add comments for each patch - -devel: %%license: COPYING-CMAKE-SCRIPTS Issues not addressed: * gpg source verification: not required, guidelines only say SHOULD (will likely do that for newer phonon releases, but little point in doing it for a compat package with static unchanging sources) * phonon dir ownership. fixed minor issue, but this (one of) the primary owners of many directories referenced. If multiple ownership needs fixing, it should happen elsewhere (e.g. phonon-backend packaging) instead
Package approved.
Thanks!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/phonon-qt4
imported