Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1795886

Summary:	Validation for disk incremental backup property should be done only for incremental backup operation
Product:	[oVirt] ovirt-engine	Reporter:	Eyal Shenitzky <eshenitz>
Component:	BLL.Storage	Assignee:	Eyal Shenitzky <eshenitz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ilan Zuckerman <izuckerm>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.4.0	CC:	bugs, nsoffer, rdlugyhe, sgoodman, tnisan
Target Milestone:	ovirt-4.4.0	Flags:	pm-rhel: ovirt-4.4+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.4.0 gitb5b5c99ca2f	Doc Type:	Bug Fix
Doc Text:	Before this update, validation succeeded for an incremental backup operation that included raw format disks, even though incremental backup does not support raw format disks. With this update, validation succeeds for a full backup operation for a virtual machine with a raw format disk, but validation fails for an incremental backup operation for a virtual machine with a raw format disk.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-05-20 20:02:40 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Eyal Shenitzky 2020-01-29 06:23:24 UTC

Description of problem:

In the current backup flow, for each backup (full/incremental) engine will validate if all the disks that participate in it are marked as 'Incremental'.

After bug 1793481 will be solved, the validation should occur only for incremental backup.

So the flow will be:
 - full backup - valid for raw / qcow2 disks -> 'Incremental' field ignored.
 - incremental backup - valid for qcow2 disks only -> 'Incremental' field checked.

Version-Release number of selected component (if applicable):
master-4.4.0

How reproducible:
100%

Comment 1 Ilan Zuckerman 2020-03-25 11:29:14 UTC

Hi Eyal, after verified the following BZ [1], are there any additional tests needed for this (current) BZ?
[1]
https://bugzilla.redhat.com/show_bug.cgi?id=1793481

Comment 2 Eyal Shenitzky 2020-03-26 09:20:23 UTC

I guess not.
Currently, incremental backup is not supported so you can't verify it.
I will move the bug to verify.

Comment 3 Sandro Bonazzola 2020-05-20 20:02:40 UTC

This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.