Bug 1796200 - Unsorted network list
Summary: Unsorted network list
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: V2V
Version: 5.10.14
Hardware: All
OS: All
high
high
Target Milestone: GA
: 5.12.0
Assignee: Mike Turley
QA Contact: Md Nadeem
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks: 1805904
TreeView+ depends on / blocked
 
Reported: 2020-01-29 20:23 UTC by Ryan Spagnola
Modified: 2023-09-07 21:37 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1805904 (view as bug list)
Environment:
Last Closed: 2020-06-10 13:13:15 UTC
Category: ---
Cloudforms Team: V2V
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Mapping wizard screenshot with overflowing names (255.59 KB, image/png)
2020-01-29 21:43 UTC, Mike Turley
no flags Details

Description Ryan Spagnola 2020-01-29 20:23:40 UTC
Description of problem: 
When creating a migration plan the list of networks is not sorted, but displayed in random order. Additionally the field width is too narrow to read the name of the network and the dialog field length and width cannot be expanded. In order to map a network it requires to hover over each network in the list until the name displays in a pop up window. Then have to scroll through the other list until the corresponding network is located to map. Adding sorting and adjustable dialogs would make this an easier process.

Version-Release number of selected component (if applicable):
latest

How reproducible:
Always

Steps to Reproduce:
1. Seen when mapping large list of networks
2.
3.

Actual results:


Expected results:


Additional info:

Comment 2 Mike Turley 2020-01-29 20:31:22 UTC
@Vince, we should review the UX here. I can easily sort the networks statically by name, but adding user-configurable sorting is a bit more complex and making the modal size adjustable may be impossible with the current PF3 styles. Let's chat some time about how to address these.

Comment 3 vconzola 2020-01-29 21:23:51 UTC
@mturley Can we make the modals scrollable? I'm surprised they're not scrollable by default. I agree- let's chat about this one.

Comment 4 Mike Turley 2020-01-29 21:41:22 UTC
@vconzola the modals scroll vertically, but the issue here is width. The multi-select lists of networks on the left (source) and right (destination) sides of the modal are narrow enough that long names don't fit well. We could allow horizontal scrolling in those lists, but that doesn't seem ideal. Maybe we just need to make those list boxes bigger and reduce some margins.

Comment 5 Mike Turley 2020-01-29 21:43:22 UTC
Created attachment 1656404 [details]
Mapping wizard screenshot with overflowing names

Attaching a screenshot to demonstrate the issue.

Comment 6 vconzola 2020-01-29 21:53:53 UTC
@mturley Thanks for the screenshot. The issue is what I thought it was. I don't think we could ever reduce margins or increase modal width enough to guarantee we could accommodate really long strings. I think we should just allow horizontal scrolling. Not elegant, but simple and effective.

Comment 7 Mike Turley 2020-01-29 22:01:44 UTC
Ok. There's a pretty big space in the middle between the two lists, maybe we can reduce that in addition to enabling horizontal scrolling inside the two lists.

I think the only problem there is that I won't be able to have both horizontal scrolling and the tooltip-on-hover showing the entire string, since the latter depends on the element being cut off (and it would no longer be cut off if I'm allowing its contents to scroll). I can look into that, but do you think that would be an acceptable tradeoff?

Comment 8 vconzola 2020-01-29 22:16:14 UTC
Yes. I'm OK without the tool tip since it sounds like the mapping task involves scanning the list of source networks for a specific name and this will be much easier if the entire name is visible than having to go one by one looking at tooltips. Needless to say, we should also make this change on the storage mapping page. Not sure about cluster mapping - will have to look at what we're showing for those.

Comment 9 Mike Turley 2020-01-29 22:40:28 UTC
Yeah, I think it should be consistent across all 3 mapping steps including clusters. I'm pretty sure that's common/reused code anyway.

Ok, so I'll do that and then also have the items in all these lists sorted by name ascending. If we want to let the user change that sort I think we can come back to it as a separate enhancement.

Comment 10 vconzola 2020-01-30 14:41:50 UTC
Sounds good. Thanks.

Comment 11 vconzola 2020-02-03 18:52:31 UTC
See above.

Comment 12 Fabien Dupont 2020-02-05 15:42:52 UTC
@Mike, for CFME 5.11.4, the code has to be merged by Feb 21.

Comment 13 Mike Turley 2020-02-06 19:45:53 UTC
Ack, thanks Fabien. I'm aiming to get to this by early next week.


Note You need to log in before you can comment on or make changes to this bug.