Spec URL: https://jjames.fedorapeople.org/ocaml-lablgtk3/ocaml-lablgtk3.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-lablgtk3/ocaml-lablgtk3-3.1.0-1.fc32.src.rpm RPMLINTRC URL: https://jjames.fedorapeople.org/ocaml-lablgtk3/ocaml-lablgtk3.rpmlintrc Fedora Account System Username: jjames Description: LablGTK3 is is an Objective Caml interface to gtk3. It uses the rich type system of Objective Caml to provide a strongly typed, yet very comfortable, object-oriented interface to gtk3.
The package fails to build in Rawhide with the following error: cairo_pango_stubs.c:31:10: fatal error: cairo_ocaml.h: No such file or directory 31 | #include "cairo_ocaml.h" | ^~~~~~~~~~~~~~~ compilation terminated. Maybe a missing BuildRequires?
It looks like the ocaml-cairo build from the mass rebuild, which contains ocaml-cairo-0.6.1, has not yet been tagged into Rawhide. If you see ocaml-cairo-0.4.7-0.28.gitbe5a298.fc32 in your build root, then that is the problem. Hopefully the tagging operation will not take much longer. In the meantime, if you checkout the ocaml-cairo repo and do a build, then put that build into a repo that mock can pull from, the ocaml-lablgtk3 build should succeed.
I tried to run the review in f31 instead (there are problems with the GPG keys right now in rawhide), and I see: File "src/dune", line 39, characters 20-26: 39 | (libraries threads cairo2)) ^^^^^^ Error: Library "cairo2" not found. Hint: try: dune external-lib-deps --missing @@default File "tools/dune", line 26, characters 12-29: 26 | (libraries dune.configurator)) ^^^^^^^^^^^^^^^^^ Error: Library "dune.configurator" not found. Hint: try: dune external-lib-deps --missing @@default
Yes, the necessary prerequisites do not exist in F31. This package can only be built in F32 or Rawhide. Hopefully the GPG key situation has been resolved now.
No significant complaints from the fedora-review tool. Some comments: - The devel subpackage misses the %{?_isa} flag in "Requires: %{name} = %{version}-%{release}". - Why is the sourceview3 subpackage named without the gtk prefix? - The examples directory is cleaned up, but it's not installed. Not sure if this is intentional. - If you decide to pack the examples, they are in the Public Domain. - License check ok for the rest of the files, final provides and requires look good.
(In reply to Iñaki Ucar from comment #5) > - The devel subpackage misses the %{?_isa} flag in "Requires: %{name} = > %{version}-%{release}". Good catch. Added. > - Why is the sourceview3 subpackage named without the gtk prefix? Because I want the subpackage names to match the opam names. If you look inside the build directory, you will find these files: - lablgtk3.opam - lablgtk3-gtkspell3.opam - lablgtk3-sourceview3.opam Hence the subpackages are named gtkspell3 and sourceview3. Yes, it seems inconsistent, but that's what upstream chose. > - The examples directory is cleaned up, but it's not installed. Not sure if > this is intentional. I started work on packaging the examples, decided I didn't really want to package them after all, then forgot to remove that. I have removed it now. And now the package is failing to build in mock, with a segfault. I'm not sure what changed. I got a clean build when I filed the original review request. I will have to track this down before I can make a new SRPM.
The problem turned out to be a bug in ocaml-dune. A fixed version has been built in Rawhide, but there has been no Rawhide compose since then. You'll either have to wait for the next compose or pass --enablerepo=local for a build to work. New URLs: Spec URL: https://jjames.fedorapeople.org/ocaml-lablgtk3/ocaml-lablgtk3.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-lablgtk3/ocaml-lablgtk3-3.1.0-2.fc32.src.rpm
The link provided for the SRPM doesn't exist. But there exists a fc33.src.rpm. Is that the right one?
With the fc33.src.rpm referred above, everything ok, no further issues. Package review below for reference. Package is APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Package does not contain kernel modules. [-]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Public domain", "Public domain", "*No copyright* GNU Lesser General Public License (v2)", "GNU Lesser General Public License (v3 or later)", "GNU Lesser General Public License (v2)", "GNU Lesser General Public License", "GNU Lesser General Public License (v2.1 or later)". 288 files have unknown license. Detailed output of licensecheck in /home/iucar/fedora- review/ocaml-lablgtk3/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122880 bytes in 10 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Ocaml: [x]: This should never happen ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ocaml- lablgtk3-gtkspell3-devel , ocaml-lablgtk3-sourceview3-devel [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: ocaml-lablgtk3-3.1.0-2.fc33.x86_64.rpm ocaml-lablgtk3-devel-3.1.0-2.fc33.x86_64.rpm ocaml-lablgtk3-doc-3.1.0-2.fc33.noarch.rpm ocaml-lablgtk3-gtkspell3-3.1.0-2.fc33.x86_64.rpm ocaml-lablgtk3-gtkspell3-devel-3.1.0-2.fc33.x86_64.rpm ocaml-lablgtk3-sourceview3-3.1.0-2.fc33.x86_64.rpm ocaml-lablgtk3-sourceview3-devel-3.1.0-2.fc33.x86_64.rpm ocaml-lablgtk3-debuginfo-3.1.0-2.fc33.x86_64.rpm ocaml-lablgtk3-debugsource-3.1.0-2.fc33.x86_64.rpm ocaml-lablgtk3-3.1.0-2.fc33.src.rpm ocaml-lablgtk3.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/gdk_pixbuf_mlsource3 ocaml-lablgtk3.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/lablgladecc3 ocaml-lablgtk3-devel.x86_64: W: no-documentation ocaml-lablgtk3-gtkspell3.x86_64: W: no-documentation ocaml-lablgtk3-gtkspell3-devel.x86_64: W: no-documentation ocaml-lablgtk3-sourceview3.x86_64: W: no-documentation ocaml-lablgtk3-sourceview3-devel.x86_64: W: no-documentation 10 packages and 0 specfiles checked; 2 errors, 5 warnings. Rpmlint (debuginfo) ------------------- Checking: ocaml-lablgtk3-debuginfo-3.1.0-2.fc33.x86_64.rpm ocaml-lablgtk3-gtkspell3-debuginfo-3.1.0-2.fc33.x86_64.rpm ocaml-lablgtk3-sourceview3-debuginfo-3.1.0-2.fc33.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "es_ES.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "es_ES.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). ocaml-lablgtk3-sourceview3.x86_64: W: invalid-url URL: http://lablgtk.forge.ocamlcore.org/ <urlopen error [Errno -2] Name or service not known> ocaml-lablgtk3-sourceview3.x86_64: W: no-documentation ocaml-lablgtk3-debuginfo.x86_64: W: invalid-url URL: http://lablgtk.forge.ocamlcore.org/ <urlopen error [Errno -2] Name or service not known> ocaml-lablgtk3-gtkspell3.x86_64: W: invalid-url URL: http://lablgtk.forge.ocamlcore.org/ <urlopen error [Errno -2] Name or service not known> ocaml-lablgtk3-gtkspell3.x86_64: W: no-documentation ocaml-lablgtk3.x86_64: W: invalid-url URL: http://lablgtk.forge.ocamlcore.org/ <urlopen error [Errno -2] Name or service not known> ocaml-lablgtk3.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/gdk_pixbuf_mlsource3 ocaml-lablgtk3.x86_64: E: missing-call-to-chdir-with-chroot /usr/bin/lablgladecc3 ocaml-lablgtk3-debugsource.x86_64: W: invalid-url URL: http://lablgtk.forge.ocamlcore.org/ <urlopen error [Errno -2] Name or service not known> ocaml-lablgtk3-devel.x86_64: W: invalid-url URL: http://lablgtk.forge.ocamlcore.org/ <urlopen error [Errno -2] Name or service not known> ocaml-lablgtk3-devel.x86_64: W: no-documentation ocaml-lablgtk3-doc.noarch: W: invalid-url URL: http://lablgtk.forge.ocamlcore.org/ <urlopen error [Errno -2] Name or service not known> ocaml-lablgtk3-gtkspell3-devel.x86_64: W: invalid-url URL: http://lablgtk.forge.ocamlcore.org/ <urlopen error [Errno -2] Name or service not known> ocaml-lablgtk3-gtkspell3-devel.x86_64: W: no-documentation ocaml-lablgtk3-sourceview3-debuginfo.x86_64: W: invalid-url URL: http://lablgtk.forge.ocamlcore.org/ <urlopen error [Errno -2] Name or service not known> ocaml-lablgtk3-gtkspell3-debuginfo.x86_64: W: invalid-url URL: http://lablgtk.forge.ocamlcore.org/ <urlopen error [Errno -2] Name or service not known> ocaml-lablgtk3-sourceview3-devel.x86_64: W: invalid-url URL: http://lablgtk.forge.ocamlcore.org/ <urlopen error [Errno -2] Name or service not known> ocaml-lablgtk3-sourceview3-devel.x86_64: W: no-documentation 11 packages and 0 specfiles checked; 2 errors, 16 warnings. Unversioned so-files -------------------- ocaml-lablgtk3: /usr/lib64/ocaml/stublibs/dlllablgtk3_stubs.so ocaml-lablgtk3-gtkspell3: /usr/lib64/ocaml/stublibs/dlllablgtk3_gtkspell3_stubs.so ocaml-lablgtk3-sourceview3: /usr/lib64/ocaml/stublibs/dlllablgtk3_sourceview3_stubs.so Source checksums ---------------- https://github.com/garrigue/lablgtk/releases/download/3.1.0/lablgtk3-3.1.0.tbz : CHECKSUM(SHA256) this package : 5b1fb2d7618c050995fdeeb15ac3d552abcafa26db66daac3488f1f93826c0ba CHECKSUM(SHA256) upstream package : 5b1fb2d7618c050995fdeeb15ac3d552abcafa26db66daac3488f1f93826c0ba Requires -------- ocaml-lablgtk3 (rpmlib, GLIBC filtered): libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libharfbuzz.so.0()(64bit) libm.so.6()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) libpthread.so.0()(64bit) ocaml(Cairo) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(CamlinternalOO) ocaml(Condition) ocaml(GContainer) ocaml(GData) ocaml(GDraw) ocaml(GFile) ocaml(GMenu) ocaml(GObj) ocaml(GPack) ocaml(GPango) ocaml(GTree) ocaml(GWindow) ocaml(Gaux) ocaml(Gdk) ocaml(GdkEnums) ocaml(GdkEvent) ocaml(GdkPixbuf) ocaml(Glib) ocaml(Gobject) ocaml(Gpointer) ocaml(Gtk) ocaml(GtkActionProps) ocaml(GtkAssistantProps) ocaml(GtkBase) ocaml(GtkBaseProps) ocaml(GtkBinProps) ocaml(GtkBuilderProps) ocaml(GtkButtonProps) ocaml(GtkContainersProps) ocaml(GtkEditProps) ocaml(GtkEnums) ocaml(GtkFileProps) ocaml(GtkMenuProps) ocaml(GtkMiscProps) ocaml(GtkObject) ocaml(GtkPackProps) ocaml(GtkRangeProps) ocaml(GtkSignal) ocaml(GtkStock) ocaml(GtkTextProps) ocaml(GtkTreeProps) ocaml(Mutex) ocaml(Pango) ocaml(PangoEnums) ocaml(Stdlib) ocaml(Stdlib__arrayLabels) ocaml(Stdlib__bigarray) ocaml(Stdlib__buffer) ocaml(Stdlib__bytesLabels) ocaml(Stdlib__callback) ocaml(Stdlib__char) ocaml(Stdlib__complex) ocaml(Stdlib__format) ocaml(Stdlib__gc) ocaml(Stdlib__hashtbl) ocaml(Stdlib__int32) ocaml(Stdlib__lazy) ocaml(Stdlib__list) ocaml(Stdlib__listLabels) ocaml(Stdlib__nativeint) ocaml(Stdlib__obj) ocaml(Stdlib__oo) ocaml(Stdlib__printexc) ocaml(Stdlib__printf) ocaml(Stdlib__queue) ocaml(Stdlib__seq) ocaml(Stdlib__stdLabels) ocaml(Stdlib__stringLabels) ocaml(Stdlib__sys) ocaml(Stdlib__uchar) ocaml(Thread) ocaml(Unix) ocaml(runtime) rtld(GNU_HASH) ocaml-lablgtk3-devel (rpmlib, GLIBC filtered): gtk3-devel(x86-64) ocaml-cairo-devel(x86-64) ocaml-lablgtk3(x86-64) ocaml-lablgtk3-doc (rpmlib, GLIBC filtered): ocaml-lablgtk3-gtkspell3 (rpmlib, GLIBC filtered): gtkspell3-devel(x86-64) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libenchant-2.so.2()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgtkspell3-3.so.0()(64bit) libharfbuzz.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) ocaml(Cairo) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(GData) ocaml(GDraw) ocaml(GObj) ocaml(GPango) ocaml(GText) ocaml(Gaux) ocaml(Gdk) ocaml(GdkEnums) ocaml(GdkEvent) ocaml(GdkPixbuf) ocaml(Glib) ocaml(Gobject) ocaml(Gpointer) ocaml(Gtk) ocaml(GtkEnums) ocaml(GtkSignal) ocaml(GtkStock) ocaml(Pango) ocaml(Stdlib) ocaml(Stdlib__bigarray) ocaml(Stdlib__buffer) ocaml(Stdlib__callback) ocaml(Stdlib__complex) ocaml(Stdlib__hashtbl) ocaml(Stdlib__int32) ocaml(Stdlib__lazy) ocaml(Stdlib__list) ocaml(Stdlib__obj) ocaml(Stdlib__seq) ocaml(Stdlib__uchar) ocaml(Unix) ocaml(runtime) ocaml-lablgtk3(x86-64) rtld(GNU_HASH) ocaml-lablgtk3-gtkspell3-devel (rpmlib, GLIBC filtered): ocaml-lablgtk3-devel(x86-64) ocaml-lablgtk3-gtkspell3(x86-64) ocaml-lablgtk3-sourceview3 (rpmlib, GLIBC filtered): gtksourceview3-devel(x86-64) libatk-1.0.so.0()(64bit) libc.so.6()(64bit) libcairo-gobject.so.2()(64bit) libcairo.so.2()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libgtksourceview-3.0.so.1()(64bit) libharfbuzz.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangocairo-1.0.so.0()(64bit) ocaml(Cairo) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(CamlinternalOO) ocaml(GContainer) ocaml(GData) ocaml(GDraw) ocaml(GFile) ocaml(GObj) ocaml(GPack) ocaml(GPango) ocaml(GText) ocaml(GWindow) ocaml(Gaux) ocaml(Gdk) ocaml(GdkEnums) ocaml(GdkEvent) ocaml(GdkPixbuf) ocaml(Glib) ocaml(Gobject) ocaml(Gpointer) ocaml(Gtk) ocaml(GtkBase) ocaml(GtkBaseProps) ocaml(GtkEnums) ocaml(GtkObject) ocaml(GtkSignal) ocaml(GtkSourceView3Props) ocaml(GtkSourceView3_types) ocaml(GtkStock) ocaml(GtkText) ocaml(GtkTextProps) ocaml(OgtkSourceView3Props) ocaml(Pango) ocaml(PangoEnums) ocaml(SourceView3Enums) ocaml(Stdlib) ocaml(Stdlib__bigarray) ocaml(Stdlib__buffer) ocaml(Stdlib__complex) ocaml(Stdlib__hashtbl) ocaml(Stdlib__int32) ocaml(Stdlib__lazy) ocaml(Stdlib__list) ocaml(Stdlib__obj) ocaml(Stdlib__seq) ocaml(Stdlib__uchar) ocaml(Unix) ocaml(runtime) ocaml-lablgtk3(x86-64) rtld(GNU_HASH) ocaml-lablgtk3-sourceview3-devel (rpmlib, GLIBC filtered): ocaml-lablgtk3-devel(x86-64) ocaml-lablgtk3-sourceview3(x86-64) ocaml-lablgtk3-debuginfo (rpmlib, GLIBC filtered): ocaml-lablgtk3-debugsource (rpmlib, GLIBC filtered): Provides -------- ocaml-lablgtk3: ocaml(Cairo_pango) ocaml(GAction) ocaml(GAssistant) ocaml(GBin) ocaml(GBuilder) ocaml(GButton) ocaml(GContainer) ocaml(GData) ocaml(GDraw) ocaml(GEdit) ocaml(GFile) ocaml(GMain) ocaml(GMenu) ocaml(GMisc) ocaml(GObj) ocaml(GPack) ocaml(GPango) ocaml(GRange) ocaml(GText) ocaml(GToolbox) ocaml(GTree) ocaml(GUtil) ocaml(GWindow) ocaml(Gaux) ocaml(Gdk) ocaml(GdkEnums) ocaml(GdkEvent) ocaml(GdkKeysyms) ocaml(GdkPixbuf) ocaml(Glib) ocaml(Gobject) ocaml(Gpointer) ocaml(Gtk) ocaml(GtkActionProps) ocaml(GtkAssistant) ocaml(GtkAssistantProps) ocaml(GtkBase) ocaml(GtkBaseProps) ocaml(GtkBin) ocaml(GtkBinProps) ocaml(GtkBuilder) ocaml(GtkBuilderProps) ocaml(GtkButton) ocaml(GtkButtonProps) ocaml(GtkContainers) ocaml(GtkContainersProps) ocaml(GtkData) ocaml(GtkEdit) ocaml(GtkEditProps) ocaml(GtkEnums) ocaml(GtkFile) ocaml(GtkFileProps) ocaml(GtkMain) ocaml(GtkMenu) ocaml(GtkMenuProps) ocaml(GtkMisc) ocaml(GtkMiscProps) ocaml(GtkObject) ocaml(GtkPack) ocaml(GtkPackProps) ocaml(GtkRange) ocaml(GtkRangeProps) ocaml(GtkSignal) ocaml(GtkStock) ocaml(GtkText) ocaml(GtkTextProps) ocaml(GtkThread) ocaml(GtkTree) ocaml(GtkTreeProps) ocaml(GtkWindow) ocaml(Gutf8) ocaml(OgtkActionProps) ocaml(OgtkAssistantProps) ocaml(OgtkBaseProps) ocaml(OgtkBinProps) ocaml(OgtkBuilderProps) ocaml(OgtkButtonProps) ocaml(OgtkContainersProps) ocaml(OgtkEditProps) ocaml(OgtkFileProps) ocaml(OgtkMenuProps) ocaml(OgtkMiscProps) ocaml(OgtkPackProps) ocaml(OgtkRangeProps) ocaml(OgtkTextProps) ocaml(OgtkTreeProps) ocaml(Pango) ocaml(PangoEnums) ocaml-lablgtk3 ocaml-lablgtk3(x86-64) ocaml-lablgtk3-devel: ocaml-lablgtk3-devel ocaml-lablgtk3-devel(x86-64) ocaml-lablgtk3-doc: ocaml-lablgtk3-doc ocaml-lablgtk3-gtkspell3: ocaml(GtkSpell) ocaml-lablgtk3-gtkspell3 ocaml-lablgtk3-gtkspell3(x86-64) ocaml-lablgtk3-gtkspell3-devel: ocaml-lablgtk3-gtkspell3-devel ocaml-lablgtk3-gtkspell3-devel(x86-64) ocaml-lablgtk3-sourceview3: ocaml(GSourceView3) ocaml(GtkSourceView3) ocaml(GtkSourceView3Props) ocaml(GtkSourceView3_types) ocaml(OgtkSourceView3Props) ocaml(SourceView3Enums) ocaml-lablgtk3-sourceview3 ocaml-lablgtk3-sourceview3(x86-64) ocaml-lablgtk3-sourceview3-devel: ocaml-lablgtk3-sourceview3-devel ocaml-lablgtk3-sourceview3-devel(x86-64) ocaml-lablgtk3-debuginfo: debuginfo(build-id) ocaml-lablgtk3-debuginfo ocaml-lablgtk3-debuginfo(x86-64) ocaml-lablgtk3-debugsource: ocaml-lablgtk3-debugsource ocaml-lablgtk3-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -rn ocaml-lablgtk3-3.1.0-2.fc33.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api, Ocaml Disabled plugins: fonts, Python, SugarActivity, Haskell, R, PHP, Java, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Oops, sorry about the f32/f33 confusion. I'm glad you figured it out. Thank you for the review!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-lablgtk3
FEDORA-2020-17573fc8ee has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-17573fc8ee
ocaml-lablgtk3-3.1.0-2.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-17573fc8ee
FEDORA-2020-17573fc8ee has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.