Red Hat Bugzilla – Bug 179709
Review Request: dap-hdf4_handler - HDF4 data handler for the OPeNDAP Data server
Last modified: 2007-11-30 17:11:22 EST
SRPM Name or Url: http://www.environnement.ens.fr/perso/dumas/fc-srpms/hdf4_handler-3.5.0-1.src.rpm
This is the hdf4 data handler for our data server. It reads HDF4 and HDF-EOS
files and returns DAP responses that are compatible with DAP2 and the
dap-server 3.5 software.
This bug depends on #179707, but circular dependencies are not allowed.
Hi Patrice, heres a review:
+ license is acceptable for FE and included
+ source matches upstream
+ spec file is clean and has no obviuous errors
+ builds in mock on FC4
+ dir ownership and permissions look good
+ very simple package
- please re-name it to "dap-hdf4_handler" or similar
- license is LGPL not GPL
new srpm here:
Both items from comment #2 are fixed so its APPROVED.
Ed, thanks for all the reviews, and sorry for the dap-server mess... Everything
builds in FC3 and FC4, and I reported upstream the issues (including the
HTML::Parser issue) and they're working on it.
Normalize summary field for easy parsing