Red Hat Bugzilla – Bug 179710
Review Request: dap-netcdf_handler - NetCDF 3 data handler for the OPeNDAP Data server
Last modified: 2007-11-30 17:11:22 EST
SRPM Name or Url: http://www.environnement.ens.fr/perso/dumas/fc-srpms/netcdf_handler-3.5.2-1.src.rpm
This is the netcdf data handler for our data server. It reads netcdf 3
files and returns DAP responses that are compatible with DAP2 and the
dap-server 3.5 software.
This bug depends on #179707, but circular dependencies are not allowed.
Hi Patrice, I took a quick look at this package and noticed two blockers:
- License is LGPL not GPL
- The package naming does not follow the packaging guidelines in two
1) the "_" delimiter is not permitted
2) this is an addon package so its name should be
"dap-server-netcdf-handler" or similar
There is an exception when there is a _ in the upstream name:
"packages where the upstream name naturally contains an underscore are excluded
But I agree that there should be dap somewhere in the name. After some thinking,
I am not convinced anymore that the handlers should depend on dap-server.
Although it is unlikely, they could be used as stand alone apps, so I propose
removing dependency on dap-server and calling the handler
and so on, to retain the upstream _ but have a more informative name. Would this
Hi Patrice, yes the "dap-netcdf_handler" name is fine so please go ahead
and post an updated SRPM and I'll continue with the review.
Here is the updated srpm:
Looks good, I don't see any blockers:
+ source matches upstream
+ builds in mock on FC4
+ rpmlint reports no warnings or errors
+ spec is simple and easily read
+ dir ownership is good
+ license is good, and correctly included
+ no shared libs
Normalize summary field for easy parsing