Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-influxdata-promql.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-influxdata-promql-2.12.0-1.fc32.src.rpm Description: The PromQL module in this package is a pruned version of the native Prometheus promql package, but extracted into a single module with fewer dependencies. This module removes the promql engine and keeps anything related to lexing and parsing the PromQL language. Fedora Account System Username: eclipseo
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41306813
License should include MIT also. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [!]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "*No copyright* Apache License (v2.0)", "Unknown or generated", "Apache License (v2.0)", "Expat License". 4 files have unknown license. Detailed output of licensecheck in 1797121-golang-github-influxdata-promql/licensecheck.txt [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-influxdata-promql-2.12.0-1.fc32.src.rpm golang-github-influxdata-promql.src: W: spelling-error %description -l en_US lexing -> flexing, sexing, hexing golang-github-influxdata-promql.src: W: no-%build-section golang-github-influxdata-promql.src: E: specfile-error warning: -u use in %forgemeta is deprecated, use -z instead to select a separate set of rpm variables! 1 packages and 0 specfiles checked; 1 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- golang-github-influxdata-promql-devel.noarch: W: spelling-error %description -l en_US lexing -> flexing, sexing, hexing golang-github-influxdata-promql-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/influxdata/promql/.goipath 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/influxdata/promql/archive/v2.12.0/promql-2.12.0.tar.gz : CHECKSUM(SHA256) this package : 271c8d8802c3d52184248650f86e72d98a08e7856643f9cbb074992b65a99698 CHECKSUM(SHA256) upstream package : 271c8d8802c3d52184248650f86e72d98a08e7856643f9cbb074992b65a99698 Requires -------- go-filesystem golang(github.com/cespare/xxhash) golang(github.com/pkg/errors) golang(github.com/prometheus/common/model) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Provides -------- golang(github.com/influxdata/promql) = 2.12.0-1.fc32 golang(github.com/influxdata/promql/pkg/labels) = 2.12.0-1.fc32 golang(github.com/influxdata/promql/pkg/value) = 2.12.0-1.fc32 golang(github.com/influxdata/promql/util/strutil) = 2.12.0-1.fc32 golang(github.com/influxdata/promql/util/testutil) = 2.12.0-1.fc32 golang-github-influxdata-promql-devel = 2.12.0-1.fc32 golang-ipath(github.com/influxdata/promql) = 2.12.0-1.fc32 Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07 Command line :/usr/bin/fedora-review -b 1797121 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: fonts, SugarActivity, Ocaml, Python, R, PHP, Perl, Java, C/C++, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-influxdata-promql.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-influxdata-promql-2.12.0-1.fc33.src.rpm
Approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-influxdata-promql
FEDORA-2020-7ee19550fb has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-7ee19550fb
FEDORA-2020-d288b645b0 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-d288b645b0
FEDORA-2020-7ee19550fb has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-7ee19550fb \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7ee19550fb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-d288b645b0 has been pushed to the Fedora 31 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-d288b645b0 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d288b645b0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-d288b645b0 has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2020-7ee19550fb has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.