Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-google-jsonnet.spec SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-google-jsonnet-0.14.0-1.fc32.src.rpm Description: This an implementation of Jsonnet in pure Go. It is feature complete but is not as heavily exercised as the Jsonnet C++ implementation. Please try it out and give feedback. Fedora Account System Username: eclipseo
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41307727
Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41307804
A new release is out; should fix most tests.
Got new fails with 32 bits. Gotta report it upstream.
New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-google-jsonnet.spec New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-google-jsonnet-0.15.0-1.fc33.src.rpm
Please report the s390x errors upstream. Approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ===== MUST items ===== C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "*No copyright* Apache License (v2.0)", "Apache License (v2.0)". 1245 files have unknown license. Detailed output of licensecheck in 1797130-golang-github-google-jsonnet/licensecheck.txt [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: golang-github-google-jsonnet (description) [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-google-jsonnet-0.15.0-1.fc33.x86_64.rpm golang-github-google-jsonnet-0.15.0-1.fc33.src.rpm golang-github-google-jsonnet.x86_64: W: no-manual-page-for-binary dumpstdlibast golang-github-google-jsonnet.x86_64: W: no-manual-page-for-binary jsonnet golang-github-google-jsonnet.src: E: specfile-error warning: -u use in %forgemeta is deprecated, use -z instead to select a separate set of rpm variables! 2 packages and 0 specfiles checked; 1 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: golang-github-google-jsonnet-debuginfo-0.15.0-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- golang-github-google-jsonnet.x86_64: W: no-manual-page-for-binary dumpstdlibast golang-github-google-jsonnet.x86_64: W: no-manual-page-for-binary jsonnet 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/google/go-jsonnet/archive/v0.15.0/go-jsonnet-0.15.0.tar.gz : CHECKSUM(SHA256) this package : cddc3462151de4c5c65183b613895575db06297edd12a63e740f09e5e0ed98dd CHECKSUM(SHA256) upstream package : cddc3462151de4c5c65183b613895575db06297edd12a63e740f09e5e0ed98dd Requires -------- golang-github-google-jsonnet (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) Provides -------- golang-github-google-jsonnet: golang-github-google-jsonnet golang-github-google-jsonnet(x86-64) Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07 Command line :/usr/bin/fedora-review -b 1797130 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Python, SugarActivity, fonts, Ocaml, Haskell, R, PHP, Java, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to Elliott Sales de Andrade from comment #6) > Please report the s390x errors upstream. > > Approved. > Thanks, I did but they are not interested in fixing it for such an exotic arch.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-google-jsonnet
FEDORA-2020-b1f1c0fbfa has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-b1f1c0fbfa
golang-github-google-jsonnet-0.15.0-1.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-7de1f4f32c
golang-github-google-jsonnet-0.15.0-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-b1f1c0fbfa
golang-github-google-jsonnet-0.15.0-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.
golang-github-google-jsonnet-0.15.0-1.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.