Bug 1797500 - Add disk operation failed to complete.
Summary: Add disk operation failed to complete.
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 4.4.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-4.4.0
: ---
Assignee: Benny Zlotnik
QA Contact: meital avital
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-03 10:00 UTC by Jiri Macku
Modified: 2020-08-04 13:21 UTC (History)
5 users (show)

Fixed In Version: org.ovirt.engine-root-4.4.0-19
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-08-04 13:21:33 UTC
oVirt Team: Storage
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
ovirt-engine-logs (3.95 MB, application/gzip)
2020-02-03 10:00 UTC, Jiri Macku
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2020:3247 0 None None None 2020-08-04 13:21:52 UTC
oVirt gerrit 106629 0 None MERGED core: skip validation for floating disks 2020-08-03 12:39:40 UTC

Description Jiri Macku 2020-02-03 10:00:53 UTC
Created attachment 1657319 [details]
ovirt-engine-logs

Description of problem:

While importing image from glace the import is failing with the following engine ERROR:

2020-02-03 04:00:21,065+02 ERROR [org.ovirt.engine.core.bll.storage.disk.AddDiskCommand] (EE-ManagedScheduledExecutorService-engineScheduledThreadPool-Thread-52) [2dc8b894] Error during ValidateFailure.: java.lang.NullPointerExc
eption
        at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.validator.storage.DiskVmElementValidator.verifyVirtIoScsi(DiskVmElementValidator.java:80)
        at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.validator.storage.DiskVmElementValidator.isVirtIoScsiValid(DiskVmElementValidator.java:54)
        at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.storage.disk.AddDiskCommand.checkIfImageDiskCanBeAdded(AddDiskCommand.java:299)
        at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.storage.disk.AddDiskCommand.validate(AddDiskCommand.java:195)
        at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.CommandBase.internalValidate(CommandBase.java:804)
        at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.CommandBase.executeAction(CommandBase.java:413)
        at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.executor.DefaultBackendActionExecutor.execute(DefaultBackendActionExecutor.java:13)
        at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.Backend.runAction(Backend.java:451)
        at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.Backend.runActionImpl(Backend.java:433)
        at deployment.engine.ear.bll.jar//org.ovirt.engine.core.bll.Backend.runInternalAction(Backend.java:639)
        at jdk.internal.reflect.GeneratedMethodAccessor195.invoke(Unknown Source)
...


Version-Release number of selected component (if applicable):
ovirt-engine-4.4.0-0.18.master.el7.noarch


How reproducible:
100%

Steps to Reproduce:
1. Install engine
2. In UI select image in glance 
3. Try to import the image as template

Actual results:
The image is not added:
User admin@internal-authz failed to import image GlanceDisk-502938d as template GlanceTemplate-ecb6cb7 to domain iscsi_0.


Expected results:
The image is added.

Additional info:
The error appears also when  oVirt/ovirt-ansible-image-template is used for adding the template.

Comment 1 Michal Skrivanek 2020-02-03 11:17:55 UTC
seems like a regression introduced by https://gerrit.ovirt.org/#/c/106367/

Comment 4 Tal Nisan 2020-02-03 11:51:37 UTC
(In reply to Michal Skrivanek from comment #1)
> seems like a regression introduced by https://gerrit.ovirt.org/#/c/106367/

Indeed, Benny discovered that regression and fixed it

Comment 13 Daniel 2020-03-01 10:03:54 UTC
Verified via web-admin on version 4.4.0-0.20.master.el7.
Checked logs and it all seems clear and work as expected. Logs were clean without any errors nor warnings.
The image is added as it should.

Comment 16 errata-xmlrpc 2020-08-04 13:21:33 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: RHV Manager (ovirt-engine) 4.4 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3247


Note You need to log in before you can comment on or make changes to this bug.