Bug 1798387 - fedora-review does not "url-decode" spec file name
Summary: fedora-review does not "url-decode" spec file name
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: fedora-review
Version: 31
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Stanislav Ochotnicky
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-05 08:47 UTC by Alejandro Alvarez
Modified: 2020-11-20 01:29 UTC (History)
7 users (show)

Fixed In Version: fedora-review-0.7.6-1.fc33 fedora-review-0.7.6-1.fc32 fedora-review-0.7.6-1.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-13 03:47:07 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Alejandro Alvarez 2020-02-05 08:47:33 UTC
Description of problem:
When the link to a spec file contains url encoded characters (i.e. %2B for '+'),  fedora-review uses it as-is, and mock fails with something along the lines


  File "/usr/lib/python3.7/site-packages/mockbuild/util.py", line 1320, in set_config_opts_per_cmdline
    if is_in_dir(config_opts['resultdir'] % config_opts, rootdir):
ValueError: unsupported format character 'B' (0x42) at index 60



Version-Release number of selected component (if applicable): 0.7.4-1.fc31


Steps to Reproduce:
1. fedora-review -b 1797524

Actual results:

INFO: Using review directory: /home/aalvarez/Work/Projects/Fedora/1797524-sourcextractor%2B%2B
ERROR: unsupported format character 'B' (0x42) at index 60
Traceback (most recent call last):
  File "/usr/libexec/mock/mock", line 980, in <module>
    exitStatus = main()
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 95, in trace
    result = func(*args, **kw)
  File "/usr/libexec/mock/mock", line 622, in main
    util.set_config_opts_per_cmdline(config_opts, options, args)
  File "/usr/lib/python3.7/site-packages/mockbuild/trace_decorator.py", line 95, in trace
    result = func(*args, **kw)
  File "/usr/lib/python3.7/site-packages/mockbuild/util.py", line 1320, in set_config_opts_per_cmdline
    if is_in_dir(config_opts['resultdir'] % config_opts, rootdir):
ValueError: unsupported format character 'B' (0x42) at index 60


Expected results:
The spec name is url-decoded, and sourcextractor++ is used for the result directory.

Comment 1 Leandro Correa 2020-03-10 15:21:49 UTC
This issue should be resolved as of https://pagure.io/FedoraReview/pull-request/384

Comment 2 Ben Cotton 2020-11-03 16:18:14 UTC
This message is a reminder that Fedora 31 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '31'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 31 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Fedora Update System 2020-11-11 02:45:55 UTC
FEDORA-2020-20c4ebf164 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-20c4ebf164

Comment 4 Fedora Update System 2020-11-11 02:46:03 UTC
FEDORA-2020-af607360e8 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-af607360e8

Comment 5 Fedora Update System 2020-11-11 02:46:11 UTC
FEDORA-2020-219835ab79 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-219835ab79

Comment 6 Fedora Update System 2020-11-12 04:07:57 UTC
FEDORA-2020-20c4ebf164 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-20c4ebf164`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-20c4ebf164

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2020-11-12 04:24:31 UTC
FEDORA-2020-219835ab79 has been pushed to the Fedora 33 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-219835ab79`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-219835ab79

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2020-11-12 04:42:24 UTC
FEDORA-2020-af607360e8 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2020-af607360e8`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-af607360e8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2020-11-13 03:47:07 UTC
FEDORA-2020-219835ab79 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2020-11-20 01:26:09 UTC
FEDORA-2020-af607360e8 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2020-11-20 01:29:09 UTC
FEDORA-2020-20c4ebf164 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.