Bug 1798393 - Review Request: ghc-lens-family-core - Haskell 98 Lens Families
Summary: Review Request: ghc-lens-family-core - Haskell 98 Lens Families
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Elliott Sales de Andrade
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-02-05 08:56 UTC by Jens Petersen
Modified: 2020-02-27 17:29 UTC (History)
2 users (show)

Fixed In Version: ghc-lens-family-core-1.2.3-1.fc33
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-02-27 17:29:34 UTC
Type: ---
Embargoed:
quantum.analyst: fedora-review+


Attachments (Terms of Use)

Description Jens Petersen 2020-02-05 08:56:58 UTC
Spec URL: https://petersen.fedorapeople.org/reviews//ghc-lens-family-core.spec
SRPM URL: https://petersen.fedorapeople.org/reviews//ghc-lens-family-core-1.2.3-1.fc31.src.rpm

Description:
This package provides first class(†) functional references. In addition to the
usual operations of getting, setting and composition, plus integration with the
state monad, lens families provide some unique features:

* Polymorphic updating

* Traversals

* Cast projection functions to read-only lenses

* Cast "toList" functions to read-only traversals

* Cast semantic editor combinators to modify-only traversals.

(†) For optimal first-class support use the 'lens-family' package with rank 2 /
rank N polymorphism. "Lens.Family.Clone" allows for first-class support of
lenses and traversals for those who require Haskell 98.

Comment 1 Jens Petersen 2020-02-05 08:57:10 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=41387164

Comment 2 Jens Petersen 2020-02-15 07:13:57 UTC
Needed for dhall

Comment 3 Elliott Sales de Andrade 2020-02-15 09:54:45 UTC
Is there a reason you don't have a %check?

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "BSD 2-clause "Simplified" License". 13
     files have unknown license. Detailed output of licensecheck in
     1798393-ghc-lens-family-core/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ghc-lens-family-core-1.2.3-1.fc32.x86_64.rpm
          ghc-lens-family-core-devel-1.2.3-1.fc32.x86_64.rpm
          ghc-lens-family-core-1.2.3-1.fc32.src.rpm
ghc-lens-family-core.x86_64: W: spelling-error %description -l en_US monad -> nomad, gonad, lemonade
ghc-lens-family-core.x86_64: W: spelling-error %description -l en_US toList -> to List, to-list, violist
ghc-lens-family-core.x86_64: W: spelling-error %description -l en_US combinators -> combinations, combination, contaminators
ghc-lens-family-core.x86_64: W: spelling-error %description -l en_US polymorphism -> polymorphic, polymorphous
ghc-lens-family-core.x86_64: E: library-not-linked-against-libc /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so
ghc-lens-family-core.x86_64: W: no-documentation
ghc-lens-family-core.src: W: spelling-error %description -l en_US monad -> nomad, gonad, lemonade
ghc-lens-family-core.src: W: spelling-error %description -l en_US toList -> to List, to-list, violist
ghc-lens-family-core.src: W: spelling-error %description -l en_US combinators -> combinations, combination, contaminators
ghc-lens-family-core.src: W: spelling-error %description -l en_US polymorphism -> polymorphic, polymorphous
3 packages and 0 specfiles checked; 1 errors, 9 warnings.




Rpmlint (installed packages)
----------------------------
ghc-lens-family-core.x86_64: W: spelling-error %description -l en_US monad -> nomad, gonad, lemonade
ghc-lens-family-core.x86_64: W: spelling-error %description -l en_US toList -> to List, to-list, violist
ghc-lens-family-core.x86_64: W: spelling-error %description -l en_US combinators -> combinations, combination, contaminators
ghc-lens-family-core.x86_64: W: spelling-error %description -l en_US polymorphism -> polymorphic, polymorphous
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so RtsFlags
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so __hscore_get_saved_termios
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so __hscore_set_saved_termios
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so __int_encodeDouble
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so _assertFail
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so backtraceFree
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so cmp_thread
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so debugBelch
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so dirty_MUT_VAR
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so enabled_capabilities
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so errorBelch
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so foreignExportStablePtr
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so forkOS_createThread
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so freeHaskellFunctionPtr
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so getFullProgArgv
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so getMonotonicNSec
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so getNumberOfProcessors
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so getOrSetGHCConcSignalSignalHandlerStore
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so getOrSetSystemEventThreadEventManagerStore
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so getOrSetSystemEventThreadIOManagerThreadStore
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so getOrSetSystemTimerThreadEventManagerStore
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so getOrSetSystemTimerThreadIOManagerThreadStore
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so getProcessElapsedTime
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so getProgArgv
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so getRTSStats
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so getRTSStatsEnabled
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so hs_free_stable_ptr
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so hs_spt_key_count
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so hs_spt_keys
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so hs_spt_lookup
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so libdwGetBacktrace
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so libdwLookupLocation
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so libdwPoolClear
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so libdwPoolRelease
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so libdwPoolTake
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so lockFile
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so newCAF
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so newSpark
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so performGC
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so performMajorGC
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so reportHeapOverflow
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so reportStackOverflow
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so resumeThread
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so rtsSupportsBoundThreads
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so rts_apply
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so rts_checkSchedStatus
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so rts_disableThreadAllocationLimit
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so rts_enableThreadAllocationLimit
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so rts_evalIO
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so rts_getThreadId
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so rts_lock
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so rts_mkStablePtr
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so rts_setMainThread
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so rts_unlock
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so setIOManagerControlFd
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so setIOManagerWakeupFd
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so setNumCapabilities
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so setProgArgv
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so setTimerManagerControlFd
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so shutdownHaskellAndExit
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so shutdownHaskellAndSignal
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so startProfTimer
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so stg_*
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so stopProfTimer
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so suspendThread
ghc-lens-family-core.x86_64: W: undefined-non-weak-symbol /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so unlockFile
ghc-lens-family-core.x86_64: E: library-not-linked-against-libc /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so
ghc-lens-family-core.x86_64: W: no-documentation
2 packages and 0 specfiles checked; 1 errors, 449 warnings.



Unversioned so-files
--------------------
ghc-lens-family-core: /usr/lib64/libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so

Source checksums
----------------
https://hackage.haskell.org/package/lens-family-core-1.2.3/lens-family-core-1.2.3.tar.gz :
  CHECKSUM(SHA256) this package     : 914f5f077d7bed8a93866ac696e69c35bb8d0fbe81314236288b057941703901
  CHECKSUM(SHA256) upstream package : 914f5f077d7bed8a93866ac696e69c35bb8d0fbe81314236288b057941703901


Requires
--------
ghc-lens-family-core (rpmlib, GLIBC filtered):
    libHSbase-4.12.0.0-ghc8.6.5.so()(64bit)
    libHScontainers-0.6.0.1-ghc8.6.5.so()(64bit)
    libHSghc-prim-0.5.3-ghc8.6.5.so()(64bit)
    libHSinteger-gmp-1.0.2.0-ghc8.6.5.so()(64bit)
    libHStransformers-0.5.6.2-ghc8.6.5.so()(64bit)
    rtld(GNU_HASH)

ghc-lens-family-core-devel (rpmlib, GLIBC filtered):
    /bin/sh
    ghc-compiler
    ghc-devel(base-4.12.0.0)
    ghc-devel(containers-0.6.0.1)
    ghc-devel(transformers-0.5.6.2)
    ghc-lens-family-core(x86-64)



Provides
--------
ghc-lens-family-core:
    ghc-lens-family-core
    ghc-lens-family-core(x86-64)
    libHSlens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1-ghc8.6.5.so()(64bit)

ghc-lens-family-core-devel:
    ghc-devel(lens-family-core-1.2.3-7TyZ81EA7yr9wnNg3rSSu1)
    ghc-lens-family-core-devel
    ghc-lens-family-core-devel(x86-64)
    ghc-lens-family-core-static
    ghc-lens-family-core-static(x86-64)



Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07
Command line :/usr/bin/fedora-review -b 1798393 -m fedora-rawhide-x86_64
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Haskell, Shell-api, C/C++
Disabled plugins: Perl, Python, SugarActivity, R, fonts, PHP, Java, Ocaml
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 4 Jens Petersen 2020-02-17 08:18:05 UTC
(In reply to Elliott Sales de Andrade from comment #3)
> Is there a reason you don't have a %check?

Good question.
Well the library doesn't have any tests.

Comment 5 Elliott Sales de Andrade 2020-02-17 08:26:31 UTC
Guess that's a good enough reason.

Comment 6 Jens Petersen 2020-02-18 11:00:23 UTC
Thank you for the review

https://pagure.io/releng/fedora-scm-requests/issue/22246

Comment 7 Igor Raits 2020-02-18 12:01:33 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ghc-lens-family-core

Comment 8 Jens Petersen 2020-02-18 16:14:38 UTC
https://pagure.io/releng/fedora-scm-requests/issue/22256 (f32)

Comment 9 Jens Petersen 2020-02-18 16:16:13 UTC
https://pagure.io/releng/fedora-scm-requests/issue/22257 (f31)

Comment 10 Fedora Update System 2020-02-20 05:45:02 UTC
ghc-lens-family-core-1.2.3-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-271ea56e5c

Comment 11 Fedora Update System 2020-02-27 17:29:34 UTC
ghc-lens-family-core-1.2.3-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.