Bug 179877 - RFE: support multiple commands on command line
Summary: RFE: support multiple commands on command line
Alias: None
Product: Fedora
Classification: Fedora
Component: ethtool
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jeff Garzik
QA Contact: Fedora Extras Quality Assurance
Depends On:
TreeView+ depends on / blocked
Reported: 2006-02-03 16:10 UTC by Tom "spot" Callaway
Modified: 2013-07-03 02:27 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Enhancement
Doc Text:
Clone Of:
Last Closed: 2008-08-21 19:35:29 UTC
Type: ---

Attachments (Terms of Use)
add ETHTOOL_PAUSE_OPTS handing (1.38 KB, patch)
2006-02-03 16:10 UTC, Tom "spot" Callaway
no flags Details | Diff

Description Tom "spot" Callaway 2006-02-03 16:10:23 UTC
Description of problem:

Currently, there is no easy way similar to ETHTOOL_OPTS in ifcfg-eth* to
automatically configure pause control. ETHTOOL_OPTS in ifup-eth always uses
"ethtool -s", but to do flow control, we really want a second invocation of
"ethtool -A ...". 

This is a trivial item to fix, it involves the creation of ETHTOOL_PAUSE_OPTS,
and handling it in ifup-eth the same way as ETHTOOL_OPTS. Patch is attached to
this bug ticket.

Comment 1 Tom "spot" Callaway 2006-02-03 16:10:23 UTC
Created attachment 124108 [details]

Comment 3 Bill Nottingham 2006-02-03 16:34:00 UTC
Hm, but what if someone then wants to change the -G settings, etc - another
commandline option and invocation?

Perhaps we can... convince... the ethtool upstream to allow multiple commands on
the command line.

Comment 4 Tom "spot" Callaway 2006-02-03 16:44:24 UTC
That would also be an acceptable approach.

Comment 5 Bill Nottingham 2006-02-03 16:56:57 UTC
Pushing to ethtool for the moment - allowing multiple commands on the command
line would make this much simpler.

Comment 6 Jon Stanley 2008-04-23 20:29:23 UTC
Adding FutureFeature keyword to RFE's.

Comment 9 Jeff Garzik 2008-08-21 19:35:29 UTC
To repeat the answer that has been repeated since 2002:

ethtool utility is a small, lightweight utility that has a 1-1 correspondence between ethtool commands and the ethtool ioctls it issues to the kernel. (some of 'list' commands excepted)  A single ethtool invocation performs a single ethtool ioctl.

Inside the kernel, a single ethtool ioctl is the smallest unit of atomicity available.  The userspace utility matches that interface.

If you want to issue multiple ioctls, fix your infrastructure to perform multiple ethtool(1) invocations.

A simple, looping shell script will easily solve this bug.  If it makes people happy, call this script "ethtool-multi".

Note You need to log in before you can comment on or make changes to this bug.