Bug 179916 - Review Request: docbook2X - Convert docbook into man and Texinfo
Review Request: docbook2X - Convert docbook into man and Texinfo
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: José Matos
Fedora Package Reviews List
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2006-02-03 15:45 EST by Patrice Dumas
Modified: 2010-07-12 12:41 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-02-14 15:33:33 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Patrice Dumas 2006-02-03 15:45:46 EST
SRPM Name or Url:http://www.environnement.ens.fr/perso/dumas/fc-srpms/docbook2X-0.8.5-1.src.rpm 
Description: 

docbook2X converts DocBook documents into man pages and Texinfo
documents.
Comment 1 José Matos 2006-02-06 15:14:58 EST
Expect a review soon. :-) 
Comment 2 José Matos 2006-02-07 06:26:33 EST
I like the package but it fails to build in mock:  
  
Checking for unpackaged  
file(s): /usr/lib/rpm/check-files /var/tmp/docbook2X-0.8.5-1.fc4-root-mockbuild  
error: Installed (but unpackaged) file(s) found:  
   /usr/share/info/dir  
  
  
RPM build errors:  
    Installed (but unpackaged) file(s) found:  
   /usr/share/info/dir  
  
Comment 3 Patrice Dumas 2006-02-07 16:00:06 EST
An updated version that builds in mock, and with minor fixes is there:

http://www.environnement.ens.fr/perso/dumas/fc-srpms/docbook2X-0.8.5-2.src.rpm

rpmlint isn't happy with libxslt as Require, but docbook2X requires xsltproc
which is in libxslt.
Comment 4 Paul Howarth 2006-02-08 03:08:32 EST
(In reply to comment #3)
> rpmlint isn't happy with libxslt as Require, but docbook2X requires xsltproc
> which is in libxslt.

Perhaps you could change the dependency from libxslt to /usr/bin/xsltproc then?
Comment 5 José Matos 2006-02-08 05:36:02 EST
(In reply to comment #4) 
>  
> Perhaps you could change the dependency from libxslt to /usr/bin/xsltproc 
then? 
 
I think that in this case this it is just a style issue. I don't have 
any problem with the dependency as it is. :-) 
Comment 6 José Matos 2006-02-09 14:57:27 EST
Preliminary review: 
 
Review for release 2: 
* RPM name is OK 
* Source docbook2X-0.8.5.tar.gz is the same as upstream 
* Spec file is readable 
* License is correct 
* This is the latest version 
* Builds fine in mock 
* rpmlint of docbook2X looks OK 
  it complains about the lib nature of one of its dependencies but in this 
case it is bogus. 
 
* Package follows packaging rules OK 
* File list of docbook2X looks OK 
 
One minor question, since the package searches tidy is there any reason not 
to BR it? 
 
Package is APPROVED. 
Comment 7 Patrice Dumas 2006-02-09 15:51:21 EST
It searches tidy and xmllint to rebuild the doc, but the doc needs not to be
rebuilt, as they are packaged.
Comment 8 Marc Bradshaw 2010-07-08 18:48:12 EDT
Package Change Request
======================
Package Name: docbook2X
New Branches: EL-4 EL-5 EL-6
Owners: deebs
InitialCC: 

As discussed with Patrice on epel-devel-list, I would like to take ownership of these packages for the EPEL branches only.
Comment 9 Kevin Fenzi 2010-07-09 14:00:50 EDT
cvs done.
Comment 10 Marc Bradshaw 2010-07-11 23:01:03 EDT
Package Change Request
======================
Package Name: docbook2X
New Branches: EL-6
Owners: deebs
InitialCC: 

Branch for EL-6 does not appear to be created in cvs, have removed the 
nobranch file from EL-5 branch, please create branch for EL-6. Thanks.
Comment 11 Kevin Fenzi 2010-07-12 12:41:08 EDT
Should be there now.

Note You need to log in before you can comment on or make changes to this bug.